Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Oct 2022 19:14:11 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     'Guanjun' <guanjun@linux.alibaba.com>
Cc:     elliott@hpe.com, zelin.deng@linux.alibaba.com,
        xuchun.shang@linux.alibaba.com, artie.ding@linux.alibaba.com,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/9] crypto/ycc: Add YCC (Yitian Cryptography Complex)
 accelerator driver
Message-ID: <Y1J/A//it5SeNKeL@gondor.apana.org.au>
References: <1664350687-47330-1-git-send-email-guanjun@linux.alibaba.com>
 <1664350687-47330-2-git-send-email-guanjun@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1664350687-47330-2-git-send-email-guanjun@linux.alibaba.com>
Precedence: bulk

On Wed, Sep 28, 2022 at 03:37:59PM +0800, 'Guanjun' wrote:
>
> diff --git a/drivers/crypto/ycc/Makefile b/drivers/crypto/ycc/Makefile
> new file mode 100644
> index 00000000..7065273
> --- /dev/null
> +++ b/drivers/crypto/ycc/Makefile
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0
> +obj-(CONFIG_CRYPTO_DEV_YCC) += ycc.o
> +ycc-objs := ycc_drv.o ycc_isr.o

This doesn't even compile.  When I fixed that it generates loads
of warnings with sparse turned on.  Please fix them all before you
resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt