Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2490275rwi; Fri, 21 Oct 2022 04:36:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM45/9fQBcAnBuZ06jjD5FS8EEy1VDKkEXCVclnfatc4FipEjf6VDtdNy+Hd4xpWJLlxhZwH X-Received: by 2002:a62:19cd:0:b0:56b:6a55:ffba with SMTP id 196-20020a6219cd000000b0056b6a55ffbamr20877pfz.85.1666352200161; Fri, 21 Oct 2022 04:36:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666352200; cv=none; d=google.com; s=arc-20160816; b=QB43O3sFSZZCkL6iiy/WXgOK68fwsuxjO+B6N/r6jd4x7GxCeheocncc3+8r5ko8t7 CStlV/bEzOyAkgHNy3H0sCw90MxllPvPEmEH2F0Zg59xLxxv0Swxv2QYNdq91ya2bpMt MVeSnJ3LBrXbNXWg0duEZe2M7f4ZS/k0508lG2Fesy18WrIHk70cC+LUauj1kqXkBRt9 gjo66RTZ/1uBsNy/7coO+R/n5R0oZZByKU/STMODCyiVH7Nu9H9GwwOW/5oh6TwI1lFm ZCymzJHX4hvNbyIkxR2ZGpCpeCziRGawHTpkSVHh9Hi+foQeK1FjzKy2CpLQx6PFR7D5 lhjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=FqAHXDVzu+U5t7RHxBDiG9yhTXuCEgrdsPsHK+YiifI=; b=s6IOlpC2Ant4TZMUE/eETZKVuqMUygqU6sHrWq8L2+N7pcTJ9Ykrj5CV9smj32IMX0 fCFkqyz45neGuE1r6XhkA0UwBYYGRHuXfWPPLAguslrefyJOHMkmrQbsLczy1xfrTpfw Zu5pYWLdP6F8YjK0vP9lOgnEpw0a/umQQiHKv8Xk1XfdI2pBjW6+QfUmqS9kGKdy0v4n UEzDJLHds5A2dqtIdqMnGAq04br6d4YgNFpmy5Dsck7h4vDpz9INz4FQUb8AknLma2My e/8byUB3mfyIKdDAgZ6x5PwRybb8balI7XHbLxLEUBojEeuZvilL5iNtBtSOk34PJ0I4 cKRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n12-20020a170902f60c00b0018663949529si5078051plg.162.2022.10.21.04.36.26; Fri, 21 Oct 2022 04:36:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230099AbiJULcp (ORCPT + 99 others); Fri, 21 Oct 2022 07:32:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230314AbiJULcf (ORCPT ); Fri, 21 Oct 2022 07:32:35 -0400 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 314BA265C70; Fri, 21 Oct 2022 04:32:34 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1olqFm-004deB-Vx; Fri, 21 Oct 2022 19:32:32 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 21 Oct 2022 19:32:31 +0800 Date: Fri, 21 Oct 2022 19:32:31 +0800 From: Herbert Xu To: Weili Qian Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, wangzhou1@hisilicon.com, liulongfang@huawei.com Subject: Re: [PATCH] crypto: hisilicon/qm - fix incorrect parameters usage Message-ID: References: <20220924101442.33833-1-qianweili@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220924101442.33833-1-qianweili@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Sep 24, 2022 at 06:14:42PM +0800, Weili Qian wrote: > In qm_get_xqc_depth(), parameters low_bits and high_bits save > the values of the corresponding bits. However, the values saved by the > two parameters are opposite. As a result, the values returned to the > callers are incorrect. > > Fixes: 129a9f340172 ("crypto: hisilicon/qm - get qp num and depth from hardware registers") > Signed-off-by: Weili Qian > --- > drivers/crypto/hisilicon/qm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt