Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9d24aab7df6898e4da6d9510cdab8a7bd6323cfc.camel@gmx.de>
Subject: Re: [PATCH 3/6] crypto/realtek: hash algorithms
From:   Markus Stockhausen <markus.stockhausen@gmx.de>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     linux-crypto@vger.kernel.org
Date:   Fri, 21 Oct 2022 14:02:37 +0200
In-Reply-To: <Y1J5amO8CWp23Rk7@gondor.apana.org.au>
References: <Y1J5amO8CWp23Rk7@gondor.apana.org.au>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

Am Freitag, dem 21.10.2022 um 18:50 +0800 schrieb Herbert Xu:
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (rtcr_check_fallback(areq))
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 return crypto_ahash_import(freq, fexp);
> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 memcpy(hreq, hexp, sizeof(struct =
rtcr_ahash_req));
> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return 0;
> > +}
>=20
> What happens when you import a fallback export but
> rtcr_check_fallback
> returns false?

Hi Herbert,

rtcr_ahash_export() will always generate a consistent state prior to
export because it calls rtcr_check_fallback() too. So the export state
will be one of the following:

- fallback active flag not set + normal state data=20
- fallback active flag set + fallback state data

Thus said a fallback export will always have the fallback active flag
set. So rtcr_check_fallback() cannot return false in this case.

Best regards.

Markus