Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Oct 2022 17:35:40 -0400
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Nicolai Stange <nstange@suse.de>
Cc:     Steffen Klassert <steffen.klassert@secunet.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Martin Doucha <mdoucha@suse.cz>, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] padata: fix liftime issues after ->serial() has
 completed
Message-ID: <20221021213540.7zlhwbbbp7og4lrl@parnassus.localdomain>
References: <20221019083708.27138-1-nstange@suse.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221019083708.27138-1-nstange@suse.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KJtHB8aqFEZJukcMOxBje6+UOFzr0WUl+mkMVSgqsKsgwTMnrw/cRGzW02J3?=
 =?us-ascii?Q?HXYuIbFvpnfUHN1OJ2F9d0mby6wmPJBJTGa1syst8o48Omq39JuiqrNGpOsh?=
 =?us-ascii?Q?Q1kJCH6N3FE00CjEzGsZ94RJeCXaVbQPJBzTas0d4D7yqxDcSw7UzM5pmx2n?=
 =?us-ascii?Q?wM1DCAgJAISCaDCNxmDsBk9CjaakSlSNwCj+2Nv0trizvtFxA/leOeglYjTh?=
 =?us-ascii?Q?THGK0PxQR9tKTvou4pDdZEbCv14ad7yz3P0nq93sPlpLfObYTZGs0GArA2Kw?=
 =?us-ascii?Q?0bYFu5CIAulsAQEWYnwa2ydwQ3mCgJFEeDjoonN6wB7IACvXj6zlDYDJXFt6?=
 =?us-ascii?Q?YqdVqBXhF8B2vxE0hMROqjUzTCnRJHxtkq0BaN7dXkMOvEEDP5QvRyMnEE0u?=
 =?us-ascii?Q?GbzM+53DapICAum3gi1FqdokRr3Gj/wW33Sp5ivHqiXP/G74oNWCuGba8sEW?=
 =?us-ascii?Q?ZzHUxfDzPzdbQ5QMvCjxH5DAt99waxfyfCwFAlk6Yd9b/CZhjUhaWlwJBJzd?=
 =?us-ascii?Q?9XtXL9mrhLRzjenhLI/UYWz+87O/FBZrgSd/2PnuiAOKKhVy85f5JLIoAS+A?=
 =?us-ascii?Q?O4IpT6G09jlg+hgOJWvL0c7GAaTYed5qd2CS0op/QCKUzhCFbXpC3JrcDhmN?=
 =?us-ascii?Q?UtuuDlvlv/3dIe3UC9SXtQ2IPZEAHTYGnvKAVGbdWrjxNBObZ58HqPMDA4cA?=
 =?us-ascii?Q?PabwPp309j05AvCklSFNDJTeO+PMRB9ESs1NcLVEG08moQJzrlj3hT3aLmaC?=
 =?us-ascii?Q?5r+pqj9taMXs8vlZi+P9HscwQIyWVdxfEfkSomYRYtMclSObMTGBBhdVBaJ5?=
 =?us-ascii?Q?XK746GzIw1sXjjkRRAmUuF7MYmX6ZrISUjEtLch608C98Hj0yKuk0FAwmrAs?=
 =?us-ascii?Q?k+1pmJzj0xbWSFJJ97NYtIxadW2+u9m65bRCJJUB+jvbwIqyZphBhQVMcFRP?=
 =?us-ascii?Q?XWM019zKr3UD5SJ29N7wMCi2ta+V1hgcmotlPBb9O/ZQDNjfzBc0b5ugMtsV?=
 =?us-ascii?Q?yMkwd3n2gNwB7Ayp96gVSahn1tFwPjHQp8iyX0joMMToKi0vF8+9mhOmh2Mw?=
 =?us-ascii?Q?QsOWulP3OOI7t7HYv3bxbhL0ZKn1ZsWPwnk4d1OnWDru9s83qAN2o5UH7pMV?=
 =?us-ascii?Q?azu2QJrKlGdoHwKxLXF1zrEGfGEtS49V9lgnq70XVBRbXjPpzLgoG28VGB5F?=
 =?us-ascii?Q?2G31fbRrYXo5Mp7hbzEY34/bvgsALMZCeYWKeJkX+3gQuALP/fvL/ykCohpB?=
 =?us-ascii?Q?zv2DrHC51Kr3HaCXK29jplqq2tQCQnWZbfKBuaMLYez4kxsn3gjVNotaZMxU?=
 =?us-ascii?Q?eq2nmf+ZyJym/dMw9MJNEDRlx59nbADtlLu+JYs9OpmCg7vZlGXjSNXwcU5t?=
 =?us-ascii?Q?Y++cipBGRnWXioLvf35LubzGTf9IhjMKSq4brBX1U0reaKaYnrgo7rUlbjho?=
 =?us-ascii?Q?bPOYrcDeKEmy/1ga+mEZ3rAzpF6gxLb9RGJ9b+/MEXYKbKrNtewk40Sn60c5?=
 =?us-ascii?Q?iVX24bRcJ/rjCbsFXKRW9/2kb/wsEjQdBDjd9pvkiqAjXadDEDiqvckvs1kk?=
 =?us-ascii?Q?4TFgjOWstUYDhMCg7pcquRvMcLRhmL0cxi3/2JDCDx3vuh3e5pmAofeXdxhN?=
 =?us-ascii?Q?qQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d64677d-b153-467f-dc4d-08dab3ac39c7
X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5711.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2022 21:35:51.3367
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vFwEM7ShwjUWS8QIlhCGKUTvdQ9lVhef/kfGid63MIbi/X+mvOwdkvjb+XK6QS11kd9Sr+aLWmeB4O9HsLz1JZLGe0ASN+a8TGil+Ma7LVg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5292
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-21_04,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 mlxscore=0
 spamscore=0 bulkscore=0 malwarescore=0 mlxlogscore=883 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2210210125
X-Proofpoint-ORIG-GUID: aiwAREzHf2MaxBUJUB4FOYckgk8_V4_0
X-Proofpoint-GUID: aiwAREzHf2MaxBUJUB4FOYckgk8_V4_0
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hi Nicolai,

On Wed, Oct 19, 2022 at 10:37:03AM +0200, Nicolai Stange wrote:
> Hi all,
> 
> this series is supposed to fix some lifetime issues all related to the fact that
> once the last ->serial() has been invoked, the padata user (i.e. pcrypt) is well
> with its right to tear down the associated padata_shell or parallel_data
> instance respectively.
> 
> Only the first one, addressed by patch [2/5], has actually been observed, namely
> on a (downstream) RT kernel under a very specific workload involving LTP's
> pcrypt_aead01. On non-RT, I've been unable to reproduce.

I haven't been able to hit the issue in 2/5 on RT on a v6.0 kernel in an
x86 vm.  Were there any other things running on the system besides
pcrypt_aead01?  More details about your environment and your kernel
config would be helpful.

The first two patches seem ok but I want to think about the second more
next week.  I'll look over the rest of the series then too.