Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     Ard Biesheuvel <ardb@kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
CC:     "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "ebiggers@kernel.org" <ebiggers@kernel.org>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "jason@zx2c4.com" <jason@zx2c4.com>,
        "nikunj@amd.com" <nikunj@amd.com>
Subject: RE: [PATCH v4 3/3] crypto: aesgcm - Provide minimal library
 implementation
Thread-Topic: [PATCH v4 3/3] crypto: aesgcm - Provide minimal library
 implementation
Thread-Index: AQHY53JRmROP5LQjMk6M+X0YaXvnqK4dtRDQ
Date:   Mon, 24 Oct 2022 16:21:52 +0000
Message-ID: <MW5PR84MB1842E8E6C99E4C9F25A1E95EAB2E9@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20221024063052.109148-1-ardb@kernel.org>
 <20221024063052.109148-4-ardb@kernel.org>
In-Reply-To: <20221024063052.109148-4-ardb@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?U4YWTgTiOsJY5eZJFVfgJHv/QBGcGKxfuVr8ZvSRMlp2m5XKDJxX10AAlIte?=
 =?us-ascii?Q?mzeaRnMsaERORPz2nFH24gs4pci0kAIeILlUxSHh2gT61R2cbY3zMUYTcj+n?=
 =?us-ascii?Q?IieWOQETyjOMk9uQnKmCo2xuol0iUIpHlxt9C/ftCBXOl6sD+3JiTwiGjH/n?=
 =?us-ascii?Q?k7dOUPhzXMCj0aAiXYrA7gEBATGIe4fk6Ovoe5WzRkhGxnk0nIpa/1MjIKB6?=
 =?us-ascii?Q?unFthnBSkYmpd+Qky/m/KKAm5iMmOpcnSQ54VnIKhek0tk2ZIjt7N3KVX8h8?=
 =?us-ascii?Q?mv2VPq9VnuiFB9ysz+xlSOyc1+H34sFQZwO35s9L1xNgvpN0OPxlOPrCgKrY?=
 =?us-ascii?Q?cxDqDu/eHg5iALmTlRQYOLVSUGsNo+TueMYA3VaVC8DJBd+RTco7GE6mfGJB?=
 =?us-ascii?Q?SBFVz146IcOhPodjk2QS0nG57mOffnnxDyWD25mtkCE8b95lFQCI4GDseSjE?=
 =?us-ascii?Q?/iQtDI7hXvPQPTyJxvRfZhKXw34jEook3cb6GcDE0HYDE6cNO/0cDT3i8LGn?=
 =?us-ascii?Q?8qDKeQj3yJICIIl0kyCvd7XYZzdLe7zG+ThSPLlVOmhXqMox2AgzhL7VtD48?=
 =?us-ascii?Q?loa2l7SajEKfdXIsugHiMvW0bOXWaLUq8ibEzB4waA+MgXeUkNa0x0f+e2Gs?=
 =?us-ascii?Q?FyDa5C86P01asSdqnyDJqfRn70MPkTfjpsSlZ2uch7IuWvaGH6+C740he7c/?=
 =?us-ascii?Q?ptxZN1CPTDiYLFArsZ/UO3QovKwoJ8LzhOAtXTaX8Al2SSQFoJEqOaRkaTFK?=
 =?us-ascii?Q?krN7tBqD8hQAddZ4ii7SEfsJN2aCHsIzvSNVrHTfLswL10bb/CbchPfBBp/G?=
 =?us-ascii?Q?bsZB2ABqsMmwgS7A+kfSkMxbYzr/YsG6SFKY18E0PG+AfdHa2EHCmXR8CyjV?=
 =?us-ascii?Q?jecw46d9/bmgQfayAEEWz5r9gTU/6OthHTOjgFFww0oPajXyz6Hjy/zv01h3?=
 =?us-ascii?Q?iwYah+dALtO77l3q4CztgI9D1Ff8K+cDYBNB27hjSYCCCWnN/FsSad9OtmlU?=
 =?us-ascii?Q?BX251T8q2Bsco6fAogRe3zGM8FughVkj+poCTp19qPdCoYmqj4i4B+Hgb5zF?=
 =?us-ascii?Q?8JOUNAnJ37s2WUkH4TgdGzRkGIQcZXfX0WbXy4E8uRK9c3ry63RDcdaMpDiW?=
 =?us-ascii?Q?w8/UElR4D5bYVEL9MSliKbzwKuZk6lgKey60ymAM3jA/LwKEfB8W2HBKppr9?=
 =?us-ascii?Q?g1xW9TFjWcC02OJwuBQA6VdCTHvVqpUm4IqBoGxWLFTkIAcxcICgC1naah5J?=
 =?us-ascii?Q?7ztTu+GvhzhM2rk/YuQkVo7H6k1WuWFNSGoAxHM8o3k5Lcpq43RInawd4TnB?=
 =?us-ascii?Q?teuTmVWG9CSxtP+DTwBId7mRGbXybRPBTdTkpsMHZoSCsu+Pp9acl61FY7Pp?=
 =?us-ascii?Q?gQAEB7VzKvhifRV420XahcfQKhmgsvE+bvyYxV2fVOEmEyAJFltUIzfgOiGe?=
 =?us-ascii?Q?mbQ1X8GQCkgMEM4dhOpBkHyzfSu74Asns3T2sD26cnTARqR4iO7uSyjkYmXk?=
 =?us-ascii?Q?jN9P2S6ufR+S8R5T28HQxx0hP4l1s8Xh/vIVk82PZzZdq3fvwMf9k3vzi/Yv?=
 =?us-ascii?Q?UfBKrgQFMgkLbENzJDw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: cec10f3b-e38c-4e83-46e4-08dab5dbdc68
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2022 16:21:52.6320
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jbGHfJ8K/cOv1Bgo0wso20xf7oTod28e7HSozB2sGM/EE8I3fWGzFCoqmYvRWcor
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR84MB1704
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: F68xgm4xrCxm0reyx2mYl_Eytd3OGor7
X-Proofpoint-GUID: F68xgm4xrCxm0reyx2mYl_Eytd3OGor7
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-24_05,2022-10-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0
 phishscore=0 mlxlogscore=999 spamscore=0 adultscore=0 malwarescore=0
 clxscore=1011 bulkscore=0 suspectscore=0 priorityscore=1501
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210240100
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> diff --git a/lib/crypto/aesgcm.c b/lib/crypto/aesgcm.c
> +static int __init libaesgcm_init(void)
...
> +		if (aesgcm_expandkey(&ctx, aesgcm_tv[i].key, aesgcm_tv[i].klen,
> +				     aesgcm_tv[i].clen - plen)) {
> +			WARN(1, "aesgcm_expandkey() failed on vector %d\n", i);
> +			return -EINVAL;
> +		}

Other self-test errors in lib/crypto (blake2s, chacha20poly1305,
and curve25519) are reported with pr_err. Could you add that in
addition to the WARNs?

Also, they return -ENODEV rather than -EINVAL on self-test failures,
like this:

static int __init blake2s_mod_init(void)
{
        if (!IS_ENABLED(CONFIG_CRYPTO_MANAGER_DISABLE_TESTS) &&
            WARN_ON(!blake2s_selftest()))
                return -ENODEV;
        return 0;
}