Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp9246784rwi; Tue, 25 Oct 2022 17:26:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7zgw6AIHnwl1kC091LWvtfQor7ntDiRTAK9dfVrSXgy3oWTEMhGrX0/fyPMdnIEck54td3 X-Received: by 2002:a63:4753:0:b0:462:b3f0:a984 with SMTP id w19-20020a634753000000b00462b3f0a984mr33999413pgk.501.1666744010505; Tue, 25 Oct 2022 17:26:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666744010; cv=none; d=google.com; s=arc-20160816; b=V56DUKy9n6eQOKpSUiUtPWcCSsgrmrkclfgOXonsCcbVSEWjE3owFjIQdTZusLWETu iTOs05P2909UzagwAeYICh+XZCK6m5TbHRTuqTHusoMbdzaHOsDisbrQEGPMHLeh3Rl7 FM8zwwZR/sl4EEi5/3Chwoc9FwgFmSmt5rUxjyEJCP6XZOC7d/veG7C6fWsSjxcyWE3n p4Z8fmC3NTEnqM8vSy2whGQ0dAaI6RybpVNTeXfzVZ5OVW8QDiAmbOPAtCssh0SDTaiw /Y5g2CNjKRH5IIhraBQcgEtYFVIXMYg2jZYgNWPCHYZ4jBGrc9sBuSVm09AUQbHzRZR4 OE0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ecM88qPAiDVuofEeX5jLAWfnFF6RrwYEZ8GggoMUX3w=; b=YnogI9t8H7s+u2RQJq66HDZ8DMiQRmvQJaQzi2z3FWoCMzsyXHSPCEIY8+rgCnZfby zwnlFIpjxz42sFeB8fxs5HqRTME/iqzy7U4XGOBvWBYCMeiPJkGIwF+EKTTcHRU1399h Qz4uZ13uNKUKILxJhtLFtkh0cssK78FlLyAyF9Mf4zUIiJQ5hhOYHKWg07PnegKpozmr 3k+VLnuV85kOpZL/jcBdNgIKWCMqFRmwLHzb1D0FKg4IZ3+8YazXo/rLs/gKVgxvu1b5 z4ev3a0Ri1M1SFTXizQ2GDhlwTDTXQ816XeZbFTu96J0r1RHRbw/lRNYrnw+yKBBezlg viCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ViiLVItq; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 2-20020a630902000000b0041aaa841692si4731570pgj.108.2022.10.25.17.26.37; Tue, 25 Oct 2022 17:26:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ViiLVItq; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232237AbiJZAOe (ORCPT + 99 others); Tue, 25 Oct 2022 20:14:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232201AbiJZAO2 (ORCPT ); Tue, 25 Oct 2022 20:14:28 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87F7AF0A for ; Tue, 25 Oct 2022 17:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666743265; x=1698279265; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CwqlATylNXQ/41W/TI6pwG8wa/tqCwk66PnLDF3n8jc=; b=ViiLVItqgycop5bWxbHEEyk3L2Os/x0lwun6vj/WgVS27hc/TAyQ/ZGS sRwmYQu/s5LtEVUIoZpI8j6veIcpEPI9BFLL6/pIMYUXOd4A8KyW0Dcou qfTwqzWXRUCoxYqvTbiiteGaCq5xy/C5rKZa8MCuWfjheipUAiIpt3AEY YlfbXfeu/ElDZxVKt0J/CiWkKDMPqpcg8MqocT2PwrIGs7LZaVOedttPN dqdeIs71h20dTu3/zVY0RO9ZgawSVOqhLDK7WSO3ROQHmuM+W4hhmdZX+ JqB1dLafWgs5c0QrM5Olduaqg2lNway1p8ibOWDbaVJonhU9ItoeXIjbu A==; X-IronPort-AV: E=McAfee;i="6500,9779,10511"; a="288219043" X-IronPort-AV: E=Sophos;i="5.95,213,1661842800"; d="scan'208";a="288219043" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2022 17:14:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10511"; a="662999547" X-IronPort-AV: E=Sophos;i="5.95,213,1661842800"; d="scan'208";a="662999547" Received: from avenkata-desk0.sc.intel.com ([172.25.112.42]) by orsmga008.jf.intel.com with ESMTP; 25 Oct 2022 17:14:23 -0700 From: Anirudh Venkataramanan To: Herbert Xu , linux-crypto@vger.kernel.org Cc: Anirudh Venkataramanan Subject: [PATCH 1/4] crypto: tcrypt - Use pr_cont to print test results Date: Tue, 25 Oct 2022 17:15:18 -0700 Message-Id: <20221026001521.4222-2-anirudh.venkataramanan@intel.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20221026001521.4222-1-anirudh.venkataramanan@intel.com> References: <20221026001521.4222-1-anirudh.venkataramanan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org For some test cases, a line break gets inserted between the test banner and the results. For example, with mode=211 this is the output: [...] testing speed of rfc4106(gcm(aes)) (rfc4106-gcm-aesni) encryption [...] test 0 (160 bit key, 16 byte blocks): [...] 1 operation in 2373 cycles (16 bytes) --snip-- [...] testing speed of gcm(aes) (generic-gcm-aesni) encryption [...] test 0 (128 bit key, 16 byte blocks): [...] 1 operation in 2338 cycles (16 bytes) Similar behavior is seen in the following cases as well: modprobe tcrypt mode=212 modprobe tcrypt mode=213 modprobe tcrypt mode=221 modprobe tcrypt mode=300 sec=1 modprobe tcrypt mode=400 sec=1 This doesn't happen with mode=215: [...] tcrypt: testing speed of multibuffer rfc4106(gcm(aes)) (rfc4106-gcm-aesni) encryption [...] tcrypt: test 0 (160 bit key, 16 byte blocks): 1 operation in 2215 cycles (16 bytes) --snip-- [...] tcrypt: testing speed of multibuffer gcm(aes) (generic-gcm-aesni) encryption [...] tcrypt: test 0 (128 bit key, 16 byte blocks): 1 operation in 2191 cycles (16 bytes) This print inconsistency is because printk() is used instead of pr_cont() in a few places. Change these to be pr_cont(). checkpatch warns that pr_cont() shouldn't be used. This can be ignored in this context as tcrypt already uses pr_cont(). Signed-off-by: Anirudh Venkataramanan --- crypto/tcrypt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 59eb8ec..7c84206 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -517,8 +517,8 @@ static int test_aead_cycles(struct aead_request *req, int enc, int blen) out: if (ret == 0) - printk("1 operation in %lu cycles (%d bytes)\n", - (cycles + 4) / 8, blen); + pr_cont("1 operation in %lu cycles (%d bytes)\n", + (cycles + 4) / 8, blen); return ret; } @@ -738,8 +738,8 @@ static int test_ahash_jiffies_digest(struct ahash_request *req, int blen, return ret; } - printk("%6u opers/sec, %9lu bytes/sec\n", - bcount / secs, ((long)bcount * blen) / secs); + pr_cont("%6u opers/sec, %9lu bytes/sec\n", + bcount / secs, ((long)bcount * blen) / secs); return 0; } -- 2.37.2