Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1733273rwi; Thu, 27 Oct 2022 21:01:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM66EkFVKhg8iIBHWhdb9wqH9ZJ2ib0CV7monvTOTjyt91HppgJs9gmfId3E4c27EnS0r54H X-Received: by 2002:a17:902:c24d:b0:186:a2d6:9f7f with SMTP id 13-20020a170902c24d00b00186a2d69f7fmr25888023plg.131.1666929716201; Thu, 27 Oct 2022 21:01:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666929716; cv=none; d=google.com; s=arc-20160816; b=YXSCMsELsXPMXzYn510lsfLQw1QkgR3Ups5LpLgFchEuCYSnoZBpByZa5jcF0Xv1Yv fDq4MswqJvljGdXSluHwRmClRu1PL4yB3rIN1n93tt+fCQSXKLhkoPbJ45hOSOpS7DUJ R4jGuqNVIYVLovPxo8+OaJbxF7S6C4/oSRd5OWH7uvHz69J07WeIoYyVGeCX8J/B4vMu JJ3v5D04vOv6JDJk3KDVME1jcd/2r42GEqtJQILeOKkcc74pvWdxVorI2QYxRMfr/dWQ Bm6KW2sBDF2xFy+HCJMtiD+kyhX8sQUWWamO6S0z0gUR5It4F2s9OhtOWs+QEd6I/8tS rMCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=0wvSCajDbfdlNtUI+zBgw5yyzsaCut+H88kSYeDMSD8=; b=euf1DXQXwuuaCR/uRWj473o3IBBwgdDVJvAZm0LZS3ceUJlN2heIyv2DXPetPMTlfT 3oP+wvj4ylic9aQxbev0qVBhD5aoHsGoqSQabH7qr0//ZdPPzhq+QxtPMT8fhwdaErGT Mb8Gi9NmIe/AtsqyUuWvuZcwuLBgG8/aJa2SHZVduXziojqArIhdS7S/nCoHSTaQU0AX YwaUZlVDDWRwUUIchBAmZGz7WY6DMZ5aXjb2YJJysWWw84wqB47Wv1gIOzz5ld9FNphj 5I8K1TbPRY2hR4VShbzXQASI+JCdBeGvfQnlSZ+5ptSlG1WqwbKRMTHu8IYZ1Hwh+Gsi BXrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f17-20020a170902ab9100b001781c1abee9si3397359plr.587.2022.10.27.21.01.12; Thu, 27 Oct 2022 21:01:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235409AbiJ1D5p (ORCPT + 99 others); Thu, 27 Oct 2022 23:57:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234558AbiJ1D5p (ORCPT ); Thu, 27 Oct 2022 23:57:45 -0400 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46A919F76F; Thu, 27 Oct 2022 20:57:44 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1ooGUK-007Tiz-FE; Fri, 28 Oct 2022 11:57:34 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 28 Oct 2022 11:57:32 +0800 Date: Fri, 28 Oct 2022 11:57:32 +0800 From: Herbert Xu To: liulongfang Cc: wangzhou1@hisilicon.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto/hisilicon: Add null judgment to the callback interface Message-ID: References: <20220930024320.29922-1-liulongfang@huawei.com> <717adf23-3080-5041-14ed-6ab5dcaddbf9@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <717adf23-3080-5041-14ed-6ab5dcaddbf9@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Sep 30, 2022 at 11:48:02AM +0800, liulongfang wrote: > > Even if the task is sent in synchronous mode, when using the hardware > driver, the hardware still informs the driver software through an > interrupt after completing the task, and the workqueue in the driver > software will call this callback function. > > And I found that the device drivers of other manufacturers under the > crypto subsystem are also in this asynchronous mode, and this problem > is also encountered when using the synchronous mode. This still makes no sense to me. Who is making an async request with no callback? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt