Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Rob Herring <robh@kernel.org>
CC:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        ChiaWei Wang <chiawei_wang@aspeedtech.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 4/4] dt-bindings: bus: add documentation for Aspeed
 AHBC
Thread-Topic: [PATCH v2 4/4] dt-bindings: bus: add documentation for Aspeed
 AHBC
Thread-Index: AQHY16FydoFvy/tRik2dFUNH8arC163/yrUAgADxsdCAItIJUA==
Date:   Fri, 28 Oct 2022 07:30:40 +0000
Message-ID: <HK0PR06MB3202285F061E0DFD0967395380329@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20221004032841.3714928-1-neal_liu@aspeedtech.com>
 <20221004032841.3714928-5-neal_liu@aspeedtech.com>
 <20221005131840.GA3256371-robh@kernel.org>
 <HK0PR06MB32020E4C2124FDD9C68F811A805C9@HK0PR06MB3202.apcprd06.prod.outlook.com>
In-Reply-To: <HK0PR06MB32020E4C2124FDD9C68F811A805C9@HK0PR06MB3202.apcprd06.prod.outlook.com>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uduGAWhyMZePaaQ5CN1qrzBJBWMMa8sCOFOdKQeQOGHp/bQFSaHegPmeRS8y?=
 =?us-ascii?Q?p+zOLekcvp1QSCI2CMUqUsVG/Hd1zLUgnIS3nzwMvJyl5eBGfHMacyqNJbz0?=
 =?us-ascii?Q?VPquRaOiKU/6L5PZRHrhCp/ZyHMyhZazw26lIDAwvTLN9ayrmoVutfmJOLPI?=
 =?us-ascii?Q?l4xrBo6e+XLflgrQpT1HSQQDlpYEmiEeyTYnmOdjMJ2fP8rQX5e8WvwPzzPZ?=
 =?us-ascii?Q?vUwteSTZ/K1MGeruEbxp9Imnleh052aC0J/IlUQIlPywBBa/h1b5ZN1e9GLP?=
 =?us-ascii?Q?MLDxL8ZpUSYiCyDgVvt5TWWuF8cp+hRzFE+vW5b1c7EXIMCZQQg1FOf8gdV0?=
 =?us-ascii?Q?KhFZpeKijKOWbKEGdnfrurJ3+fk574FjjikcV9NiXTSiMmDOVaMc2wjydBBZ?=
 =?us-ascii?Q?xf2GDDCHk6hZQnvgoGXf0TH6p7fW3X0DgJqpvJkF22YlTlIMYwxgSjCZjuh5?=
 =?us-ascii?Q?6ebuI6Rx9jT6ga8FiRmo+dGl5kvvxifl2wVa1V5Nevk7OWwejlJlO9fQbRXc?=
 =?us-ascii?Q?yam+oUPPuXQKLJ6a70wgCbIwu8C0bzcuBDtHKhG4BWbyKbb32DyYquEygAI1?=
 =?us-ascii?Q?X7G91r7/ULjxCzHdD3U8fiYFEI+dGqQTg6AB0+R1tTjvsi29hHi/pCTzot3e?=
 =?us-ascii?Q?3wcYRIf5t8NzH+61W+Kx7NXt6q+7zl6TgvNySI2L5vQ+Njxl4g9NAIz1bepj?=
 =?us-ascii?Q?t/gSPtozBmO/cHnYzU+IKQKr6+/YlRTmWZdfOVeL7JdbjL5ZL6y53D7DazVp?=
 =?us-ascii?Q?sHedjJlHsZK7oRbBr5I2WeyPzbzfr7WhHdkSHth9N47pugLvksRho40aqJRh?=
 =?us-ascii?Q?UAFA4RgskM3sAZQSwtZpaU8/dD19SEUGWJNlmT4rph2S8L2IBJJwOQ1xYiDl?=
 =?us-ascii?Q?op9A/JQ0G/a40uLy4F0VsXMzaC2WpoNxe3EylIax3xlUi83fPTJt2o9tY2yU?=
 =?us-ascii?Q?oxQyHba422scyJCyL65JytHIdQ/h/qp3Q/VIBL45WRIbk5U3cpd/onVRplph?=
 =?us-ascii?Q?pVnWaSdNBNro5R5Bi7FZ8p/OB0HtfksbRYxFBfo2gPY4ZJrPJgyLMyNsyn2g?=
 =?us-ascii?Q?aQ7CBcwCJwELqlNGAZjZ61pkDt58CSky9KoRROqdUEOj/f8vnTUiEoa/kWSD?=
 =?us-ascii?Q?wFomxdfIs1DsYK1ZMTntVolJo3/xA4sx1y83W+OGyZKomDFLZjnq0jVrK9C7?=
 =?us-ascii?Q?x16UYc5tjXuv3Nr/RWyn4CfjCVv2UTtGExdtrxKJ3sw2HsNj/5WaXisnnF/q?=
 =?us-ascii?Q?ys7k4oye2MbtixFsxqRPb0dhLiQkcS0k0/Wn29aHKnOkZfRdFbtT8ATGbOtj?=
 =?us-ascii?Q?nAk9OQ77rgqFSrKYMorGn89ZnWXLLZsuMUuBlX4zT6BjSQdj71hENWcF/bxI?=
 =?us-ascii?Q?K4Pt0J0F3Xa5aXojZuLiV9tMgfrnXX/r055J1mazujapqsOV3x4Ok7dNtu5M?=
 =?us-ascii?Q?edqskWTePkDXAnxUSPHdMWeIlMsQbgkMB+GROnrzO91yRilTsW+ke6hLh9Ga?=
 =?us-ascii?Q?ZOjLARNwwTvvYHCsRHBoN87N+cYDZNEd2VVrj850uiDnnaUdmV/Bkw6NEJ8y?=
 =?us-ascii?Q?M4MfyL2OUKX7Iy4k9V/PnmeR2GKmNwyLrMCJBVQ1?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1d1bf34-8ce3-4620-9aef-08dab8b650cb
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2022 07:30:40.5113
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /PMHnwVcAKXq2Uy9c3TpFW0avahZTD1T/3Gw9w7qflOOA4MsfebO7hRNTSB7/Nqb2Rt3s2x5Yu4wUruSp80QKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5719
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> > > Add device tree binding documentation for the Aspeed Advanced
> > > High-Performance Bus (AHB) Controller.
> > >
> > > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > > ---
> > >  .../bindings/bus/aspeed,ast2600-ahbc.yaml     | 46
> > +++++++++++++++++++
> > >  1 file changed, 46 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/bus/aspeed,ast2600-ahbc.yaml
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/bus/aspeed,ast2600-ahbc.yaml
> > > b/Documentation/devicetree/bindings/bus/aspeed,ast2600-ahbc.yaml
> > > new file mode 100644
> > > index 000000000000..c42a350d30a1
> > > --- /dev/null
> > > +++
> b/Documentation/devicetree/bindings/bus/aspeed,ast2600-ahbc.yaml
> > > @@ -0,0 +1,46 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/bus/aspeed,ast2600-ahbc.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: ASPEED Advanced High-Performance Bus Controller (AHBC)
> > > +Device Tree Bindings
> > > +
> > > +maintainers:
> > > +  - Neal Liu <neal_liu@aspeedtech.com>
> > > +  - Chia-Wei Wang <chiawei_wang@aspeedtech.com>
> > > +
> > > +description: |
> > > +  Advanced High-performance Bus Controller (AHBC) supports plenty
> > > +of mechanisms
> > > +  including a priority arbiter, an address decoder and a data
> > > +multiplexer
> > > +  to control the overall operations of Advanced High-performance
> > > +  Bus (AHB). AHB is the main system bus for ARM CPU to communicate
> > > +with the
> > > +  related peripherals.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - aspeed,ast2600-ahbc
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > +  - |
> > > +    bus {
> > > +        compatible =3D "simple-bus";
> > > +        #address-cells =3D <1>;
> > > +        #size-cells =3D <1>;
> > > +        ranges;
> > > +
> > > +        ahbc: bus@1e600000 {
> > > +            compatible =3D "aspeed,ast2600-ahbc";
> > > +            reg =3D <0x1e600000 0x100>;
> >
> > Devices on the AHB bus should be child nodes here. Unless this is just
> > for device master interface to memory, but that's not what the descript=
ion
> says.
>=20
> Sorry, I don't understand. "ahbc" device is already a child node here und=
er
> AHB bus.
> "ahbc" is a controller to control the overall operations of AHB, which is
> described in the description.
> Could you explain more details?
> Thanks.

Hi Rob,

This controller is a device master interface to memory, not the bus itself.=
 Maybe the description confuse it, I'll try to revise it.
Thanks.