Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Oct 2022 12:22:36 -0400
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     Nicolai Stange <nstange@suse.de>
Cc:     Steffen Klassert <steffen.klassert@secunet.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Martin Doucha <mdoucha@suse.cz>, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] padata: make padata_free_shell() to respect pd's
 ->refcnt
Message-ID: <20221028162236.5hvgga57bhfsdwmo@parnassus.localdomain>
References: <20221019083708.27138-1-nstange@suse.de>
 <20221019083708.27138-3-nstange@suse.de>
 <20221028143546.3xc6rnfkfcml373c@parnassus.localdomain>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221028143546.3xc6rnfkfcml373c@parnassus.localdomain>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8aMU5I/2Rcw2bmht9bM2Lj0R0zJKnhTK4MGDb/iPtMUYKeq24fD8pSF/aX34?=
 =?us-ascii?Q?7USOC1FdpwmPuO8rJUYILDc1VCpLahcN2xroavT9560mBBkdHK5Q+R/E3ywr?=
 =?us-ascii?Q?RFbywsiWdK5c4T5lbcsyGy/s3AhmWGt/FI25OfVlFsP+Px9VgoRbKGjOa6cT?=
 =?us-ascii?Q?G00w7qutKnMWp/48WRuRUc4p+iTjs7/nwtw3p8EI4602uqyO3/h6ejfve2Ri?=
 =?us-ascii?Q?8gKCVAFhiilvALsgRRKN456wexZtNDnKtYuwYAxTLHLbR63lyYTd2wqiPDHi?=
 =?us-ascii?Q?wMnbJIRB7QpdndT4Bm7Zlykiv3OgksIuBuhI83h2hap1HpFzV809nB1Bz07s?=
 =?us-ascii?Q?JlK9TrIxSe9lUUSSCtiJ86lXMxveinwB51oKe1sX4YdGVuFW59djTILJo7vt?=
 =?us-ascii?Q?R2CbY6/i4GkgpIYXDzSNJcvntQgSVg134GtOAiFDxLamwqtLSjSnDsPP6Faa?=
 =?us-ascii?Q?XbB5vdR0jDvM+9rZizYjZcAgQj1tVoFYQLqjWECpu1cKiLrpfEi8P/g9RK0U?=
 =?us-ascii?Q?RGQF7nxQhWgILEgxqGdiTq+2cU+98r05cqnEQbSBI9air9mMvaqJjobS3xxl?=
 =?us-ascii?Q?/SvhGj8UKaLwYpqSLoYP0L3hkcNA43yRE5xfiDRck7SbW+B3yhILjCP6Dtnt?=
 =?us-ascii?Q?+jPK5/B/wTsXQ9qDiKqyki1psEBoPOlmEDGNDLVcc/lG6tE4Kb1MQg5Mb792?=
 =?us-ascii?Q?KFO2nfB6y+oDme4cehygd9ROPU5l877Wpv73WyFIP/Mc836k9TFP1BT1kOBA?=
 =?us-ascii?Q?uoVJydgmxbPmvoAKOhcFyEu0STJ7GEBSdZDRaiZ3pHgYl5l5CCwM4vocwk28?=
 =?us-ascii?Q?vSsJGZGHEJ/29L+3SjfvzsQcuAXQgIZGNsbzs48+cimFsSk9yFQhjvMO3IVX?=
 =?us-ascii?Q?ugkB2qkQ38GgUk7doHcKYjeGQlsMJlyLn52pI/jgTHPltI+1gstidMBi1v5B?=
 =?us-ascii?Q?HtyD/fwxln6m4fkepdD+ObpC2ZKksJRU9aiP7deRyRtHVns3fdk7vUqcW7wv?=
 =?us-ascii?Q?1c0gfvKsJyErwbNPYznH3T+mf+yOVlMdJ8KMejVkYqixGQmbVOaqxp+0FPPb?=
 =?us-ascii?Q?4TSxT/YmDLtPNgJ8zJWG/CmzLMgNoHq5/7OIdRab1AaV7Dd+nIQJxhW9zk5M?=
 =?us-ascii?Q?rqdziOMaHYqBzscdVeQlWzOVa/jsV2OrwLJJg29s41byo6pCsF4/5jmq+nj+?=
 =?us-ascii?Q?VGfDAKQ44+Znhh5ubgZIQFkgdlvcr7YiOdSSbu9dnQCuBqmKaNYK5ghCME2U?=
 =?us-ascii?Q?D+G2rTY0SB6JdSfWangLrmr4VUFWd377Px9GrozY2rRm3JqGN5gpTrJe0X7t?=
 =?us-ascii?Q?vawTj/D6Ui8T4j8SPIpwXKHNIurFrifZN1UFCkYEkYzDtnz5e+XQY1bHoK20?=
 =?us-ascii?Q?ftp8Tl/A8NvEPchRsN4EnbhgagWJDISKd4Pud35d4UHYfJj+ADJhWiAdQi6Z?=
 =?us-ascii?Q?sriQB9byISfbP6enEHsXCSe/r/YAqlfpJb2MnVP6NQRRxfSsC/K7qokeVE2B?=
 =?us-ascii?Q?5XIlOGJaqNJgItqURCPz0r6TpjqbxXzQe7KQvhkurFilrYZzeLtOqOw/5euw?=
 =?us-ascii?Q?H31lvVH5EWnKkcmsI+JUgJHJifI/w+Xf+WaXFM29p/GSK5xEsP0lPmfuXI4x?=
 =?us-ascii?Q?aA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea5e92e5-7b9b-4150-cac3-08dab900a274
X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5711.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 16:22:40.3985
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qNr1GRuIUlIFZceAgxC3poGG3sZCGbKUILs0cxbV0qDjicAuEjSofm7QxHzGKGXvCU+A1W/t1MmR039OhBv5LEhrs3j2tciHpbHn5MpIwjI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6689
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-28_07,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 malwarescore=0
 phishscore=0 mlxlogscore=631 mlxscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2210280102
X-Proofpoint-ORIG-GUID: fxwBLdul1dM86Lxk6gcqBdF4k4sjV66N
X-Proofpoint-GUID: fxwBLdul1dM86Lxk6gcqBdF4k4sjV66N
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Fri, Oct 28, 2022 at 10:35:49AM -0400, Daniel Jordan wrote:
> On Wed, Oct 19, 2022 at 10:37:05AM +0200, Nicolai Stange wrote:
> > Fixes: 07928d9bfc81 ("padata: Remove broken queue flushing")
> 
> It looks like this issue goes back to the first padata commit.  For
> instance, pd->refcnt goes to zero after the last _priv is serialized,
> padata_free is called in another task, and a particularly sluggish
> padata_reorder call touches pd after.
> 
> So wouldn't it be
> 
> Fixes: 16295bec6398 ("padata: Generic parallelization/serialization interface")
> 
> ?

I guess not, by my own logic from 2/5.  I think it might be

Fixes: d46a5ac7a7e2 ("padata: Use a timer to handle remaining objects in the reorder queues")