Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e7bdd6dd-f698-aea5-c2f2-bb0aab7923fb@gmail.com>
Date:   Fri, 4 Nov 2022 19:42:20 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 2/2] crypto: aria: implement aria-avx512
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     linux-crypto@vger.kernel.org, davem@davemloft.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, x86@kernel.org,
        jussi.kivilinna@iki.fi
References: <20221026052057.12688-1-ap420073@gmail.com>
 <20221026052057.12688-3-ap420073@gmail.com>
 <Y2TcH5CeGZxIpcnO@gondor.apana.org.au>
Content-Language: en-US
From:   Taehee Yoo <ap420073@gmail.com>
In-Reply-To: <Y2TcH5CeGZxIpcnO@gondor.apana.org.au>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Herbert,
Thank you so much for your review!

On 11/4/22 18:32, Herbert Xu wrote:
 > On Wed, Oct 26, 2022 at 05:20:57AM +0000, Taehee Yoo wrote:
 >>
 >> +		while (nbytes >= ARIA_GFNI_AVX512_PARALLEL_BLOCK_SIZE) {
 >> +			u8 keystream[ARIA_GFNI_AVX512_PARALLEL_BLOCK_SIZE];
 >
 > This is too big for the stack.  Perhaps put it into the reqctx.
 >
 > Cheers,

Thanks, I will put the keystream array into the struct aria_ctx.

Thanks a lot!
Taehee Yoo