Received: by 2002:a05:6358:16cd:b0:dc:6189:e246 with SMTP id r13csp2186241rwl; Sat, 5 Nov 2022 03:24:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Bj9pmYa2YGFoaTqpZxKYtnWIqtuloQ4EjR7mornB/B6U6MU7FckfiA9U9/Y6WIQSswlw4 X-Received: by 2002:a17:903:2d0:b0:183:ba7f:a67b with SMTP id s16-20020a17090302d000b00183ba7fa67bmr40355121plk.42.1667643863619; Sat, 05 Nov 2022 03:24:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667643863; cv=none; d=google.com; s=arc-20160816; b=TGYg581WkGsj5ma1eZW8sXfOOzx7zbqcOYZxSRfaGejlv6pZd8zI2Uyv4Rrp+NLQjY 71+r0Op0miGBu02orvvcUZmlyOM1+275d77UlExvcYvw0kEkzUTPkQLa09MEuS9QZj1h qnzEhMHihbbrkP463/o7Y1hmLUF141pABvjhxr8Tx9tb4Bpp9YYGPE45krLtXpXtJaC4 1lMf7A1cdQ0EYY/tSGRozE8egJF8h1Ff7gONZTyxcrMeGV0nw8svimRwGV0Pv8XU7pGR 9ly6Yth1oy7U3052XjK+rBqdZ5K5JQ/5FlpGZFv5hiHr0DsUQSsD+GA4FFwoYW0nqbQ9 YliA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=K+/oFHLq6hqhraUC+sHV9vma1TC3Nn59A2CjSMH7kBs=; b=XFAdNOuhphvi8r/yuT2UA1XqD+h36jyD1HOemRztdHxlDsh5np1CB5w2A70jk4AqNC u97LMrkBcUhSILDG4HTXlU+pAu5o76gZoz39onxKhAyPiQm4cGfJeecqjsXubvYHB6eT JQpQprMhu/gxbfwCY+RSSOKrr0M4q9ZhixDjq41qqF3LaHR4pfX3PYY/dZ3cbOU4H/Zh +mLtYPBm/6kIl0WYCRi15MLHmDBzCMpG6/H2olc8CBCglAtEkRA/PZ6733mWxBInpY4R 6PsW+VFyyENH8E6dQ7+hCEMZK6oR7Hw7hk/XFwoY82uHzJ6moqOgcZyHiVwX3NXEYe/g KPsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d23-20020a17090ab31700b0021414ac5cc2si6292598pjr.131.2022.11.05.03.24.01; Sat, 05 Nov 2022 03:24:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229486AbiKEKSv (ORCPT + 99 others); Sat, 5 Nov 2022 06:18:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbiKEKSu (ORCPT ); Sat, 5 Nov 2022 06:18:50 -0400 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 944B3E9F; Sat, 5 Nov 2022 03:18:49 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1orGFc-00APzR-O6; Sat, 05 Nov 2022 18:18:46 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sat, 05 Nov 2022 18:18:45 +0800 Date: Sat, 5 Nov 2022 18:18:45 +0800 From: Herbert Xu To: Kai Ye Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, wangzhou1@hisilicon.com Subject: Re: [PATCH v2 1/4] crypto: hisilicon/qm - modify the process of regs dfx Message-ID: References: <20221105095357.21199-1-yekai13@huawei.com> <20221105095357.21199-2-yekai13@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221105095357.21199-2-yekai13@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Nov 05, 2022 at 09:53:54AM +0000, Kai Ye wrote: > > +static void dfx_regs_uninit(struct hisi_qm *qm, > + struct dfx_diff_registers *dregs, int reg_len) > +{ > + int i; > + > + /* Setting the pointer is NULL to prevent double free */ > + for (i = 0; i < reg_len; i++) { > + kfree(dregs[i].regs); > + dregs[i].regs = NULL; > + } > + kfree(dregs); > + dregs = NULL; > +} The line that I complained about is still here. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt