Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1324312rwb; Sun, 6 Nov 2022 23:41:19 -0800 (PST) X-Google-Smtp-Source: AMsMyM6FjNJEaDVNlofimcxQZPCTfQA/C+8eyC8jO5jvF1tFeGr4e1evAz06003JY+VX79Ru/SUq X-Received: by 2002:a63:f47:0:b0:46a:e00c:24c7 with SMTP id 7-20020a630f47000000b0046ae00c24c7mr42376200pgp.239.1667806879476; Sun, 06 Nov 2022 23:41:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667806879; cv=none; d=google.com; s=arc-20160816; b=rMjBA+RvyYRsQvp2aUodzc7YdF0qWS+faWQoVfNiqvmZkJ6q0IF1tzYgsmlqDxOasb Gc5GpZh3stc6UBGWG9oSa4HwohzUE5geY+kh/1rUnqbaROBep9Y9jceu3WWAzzpZkkJ+ dD2T0UJBRRY6GVmCfxyhGEVJvnsv1BMgDDXdz6OF8DbHU2ZyWj/gHOJMVpOvQGuhgCnm +pR53HHxDuu/enY+0waONG1oG01pw1tm4Kine1/M9iKDVvcoMa9Ctjw82TALwp0dcMUK jDTCQT950wz/FAxFLfqz6PSL+KsYvE3w9fI/4QKc03F4xI7HDZu4smzvcBl9z+I07g25 d4aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=4sbKm7ugKyPOatSz2gssncnt8zx17x7Y18481MGwQp8=; b=grGFj3pKHvK3Ibc0QKZmLW31OgGgFyx+TTdoRt5b7g8vhkolEiVb55OR1Y2LFJPJh8 vF5IYjlCK3TqA8omcArEVz42u7n+NaOwRwNeXPc/c3qGT/DZNNEbCahYrDdqb1CmM1O+ I1Bn+5vVDK72uHdLhNXSvvu3uiSGKohc4k0VBvkCIJ4lXnQrXlPDGWvq073YdRluYJ7A KBzmz3gzH0b2x/89/QlfWd05Q/w4QJyl708A2LuzuxUXt2m0sq5ryjDrdMD8JsfO/aQb uUYw55lxniwlot8e5I+j3GDt7Usmgt1qESqrMUnl1d9bnwjyD+huqFDlPSRk12vq7H03 3wgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w6-20020a17090a8a0600b0021406fde039si8120686pjn.156.2022.11.06.23.40.57; Sun, 06 Nov 2022 23:41:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231252AbiKGHjc (ORCPT + 99 others); Mon, 7 Nov 2022 02:39:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231201AbiKGHjb (ORCPT ); Mon, 7 Nov 2022 02:39:31 -0500 Received: from isilmar-4.linta.de (isilmar-4.linta.de [136.243.71.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9471D56 for ; Sun, 6 Nov 2022 23:39:30 -0800 (PST) X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES Received: from owl.dominikbrodowski.net (owl.brodo.linta [10.2.0.111]) by isilmar-4.linta.de (Postfix) with ESMTPSA id D24DB201481; Mon, 7 Nov 2022 07:39:28 +0000 (UTC) Received: by owl.dominikbrodowski.net (Postfix, from userid 1000) id 2F07E8082C; Mon, 7 Nov 2022 08:39:06 +0100 (CET) Date: Mon, 7 Nov 2022 08:39:06 +0100 From: Dominik Brodowski To: "Jason A. Donenfeld" Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org Subject: Re: [PATCH v3] hw_random: use add_hwgenerator_randomness() for early entropy Message-ID: References: <20221106150243.150437-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221106150243.150437-1-Jason@zx2c4.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Am Sun, Nov 06, 2022 at 04:02:43PM +0100 schrieb Jason A. Donenfeld: > Rather than calling add_device_randomness(), the add_early_randomness() > function should use add_hwgenerator_randomness(), so that the early > entropy can be potentially credited, which allows for the RNG to > initialize earlier without having to wait for the kthread to come up. > > This requires some minor API refactoring, by adding a `sleep_after` > parameter to add_hwgenerator_randomness(), so that we don't hit a > blocking sleep from add_early_randomness(). > > Cc: Herbert Xu > Cc: Dominik Brodowski > Signed-off-by: Jason A. Donenfeld Reviewed-by: Dominik Brodowski Thanks, Dominik