Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Nov 2022 16:47:22 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     "yekai (A)" <yekai13@huawei.com>
Cc:     linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        wangzhou1@hisilicon.com
Subject: Re: [PATCH v2 1/4] crypto: hisilicon/qm - modify the process of regs
 dfx
Message-ID: <Y2jGGuewePunGPtl@gondor.apana.org.au>
References: <20221105095357.21199-1-yekai13@huawei.com>
 <20221105095357.21199-2-yekai13@huawei.com>
 <Y2Y4hWc+cUJ4VZgy@gondor.apana.org.au>
 <45cf9fba-fae6-8279-bfac-f70110df42dc@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <45cf9fba-fae6-8279-bfac-f70110df42dc@huawei.com>
Precedence: bulk

On Mon, Nov 07, 2022 at 02:53:28PM +0800, yekai (A) wrote:
> 
> 
> On 2022/11/5 18:18, Herbert Xu wrote:
> > On Sat, Nov 05, 2022 at 09:53:54AM +0000, Kai Ye wrote:
> >> +static void dfx_regs_uninit(struct hisi_qm *qm,
> >> +		struct dfx_diff_registers *dregs, int reg_len)
> >> +{
> >> +	int i;
> >> +
> >> +	/* Setting the pointer is NULL to prevent double free */
> >> +	for (i = 0; i < reg_len; i++) {
> >> +		kfree(dregs[i].regs);
> >> +		dregs[i].regs = NULL;
> >> +	}
> >> +	kfree(dregs);
> >> +	dregs = NULL;
> >> +}
> > The line that I complained about is still here.
> >
> > Cheers,
> 
> ok

Just to be clear, it's the last line "dregs = NULL" that I was
referring to.  It makes no sense to zero a variable that is on
the stack.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt