Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3128852rwb; Tue, 8 Nov 2022 00:32:46 -0800 (PST) X-Google-Smtp-Source: AMsMyM4pwU3W89U/4TBnp1fc9bquJWYSpz338khftL2o6ZFVo7Rnd0c3wA3sC6EUJNlGz2rmE6A+ X-Received: by 2002:a17:90b:38ca:b0:214:2cff:fbb5 with SMTP id nn10-20020a17090b38ca00b002142cfffbb5mr34129587pjb.79.1667896366256; Tue, 08 Nov 2022 00:32:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667896366; cv=none; d=google.com; s=arc-20160816; b=o36tf27IlBbiYmlSjgrosWsnt+CJBwwxB5uMTXAB11fPbVXU1P4wlmh8cLnBLrdivu cL34FE92fi/KW+FIjbQYlhCX2f5D2nMMheoPksxxeKmNm2w05Q8FSflObr0AyeY7Eagi LtVaHlGg6XpFDQMPJOprzfUhi9xUNkHUsCbziFtKwL75gbNWaAaIdInISqjG8kQmidwJ 5aPXROReS/THhJ0N0w49Roawb2ShW/Y0WBMmLotOo90qj2N86OTHW/l6Egcc61/z+khL cdIozTLg0w9E/u28RwPoU8lvjLLdXF8ehj/PXTUXcn9hfZGiLw6Wzi5+QsvTT/91mfnG Dgwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=8pfGe51aDCtJLfkDBJjFWz87K+4Z00C3/Nyvbv/ZufU=; b=pBpRDdPk3Vxpl0egDK33HfcnzfwgFsSSVd/lGQ47X+J8E8aI1+LVlE6CbL/Y02PwOe FgcFmP2iotcFjnAF+DiRo4VIZEgOnDfrQnZBjhoXic+Vpzdis2Q8XaLDnixRyqgrwpxr L+tG6dddXL0MgMC+q226Dysu4F/QkPYLiKN2b32wo9MBkQv1hf2QvF6GbfAbo9wmWEhZ Zca5CMGqQycbjficjlOENjQKy35KjDn/fG/8g55xofeIxP2kUX7rN1PGp/w4sD+TgfjY KbyngZgW0Xa41693+PLPNAyKWU8ds0IbBNyRNcbGZi22SBnFR9jm1LbO3tPELvQZ3KKL VOrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=JpkRroxI; dkim=neutral (no key) header.i=@linutronix.de header.b=JNbl06FF; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e8-20020a170902744800b001732b4e99c4si11555063plt.377.2022.11.08.00.32.30; Tue, 08 Nov 2022 00:32:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=JpkRroxI; dkim=neutral (no key) header.i=@linutronix.de header.b=JNbl06FF; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232125AbiKHIcY (ORCPT + 99 others); Tue, 8 Nov 2022 03:32:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232901AbiKHIcW (ORCPT ); Tue, 8 Nov 2022 03:32:22 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D98B22791E; Tue, 8 Nov 2022 00:32:21 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1667896339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8pfGe51aDCtJLfkDBJjFWz87K+4Z00C3/Nyvbv/ZufU=; b=JpkRroxIuiKYwNNwCR62L0nUkId0vv0KShqlTvtcbwIFOCXmEK1Ijp6DbOoS9YGEfgOhdb qnCIz2Nhq1+3lkOIFVb5j9Qp2FmgjRS+mfOJAKaf5MssGCyTWvQONI/GE3aTnnuKCHB0rj o2sk6/YTdTcWd1YoGwb6D/ET7RTIML9F9woehAWA7HzZdSZY6YIi9Q3sZnNV31FtGmT9HM Q/lONxT1dfgO4ZFvDOY6jGLKlmzeYD1sCXHXAoCY0tjw0ITRqqDoQy4XWh7dWlhCbUMn3b QR2+HcSrNam0G4NS1AqsQujDnUNnGXeEaK5d4FO2bFCzPf5YU9ABn3vhGl1U+A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1667896339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8pfGe51aDCtJLfkDBJjFWz87K+4Z00C3/Nyvbv/ZufU=; b=JNbl06FFH9Wdisu/eOljA6OMgxZlx7ILLDSAmU8yGh65tKdxBzI/f2QG9iJ6oUj+orRUMr TTNDfr64odE2a/BQ== To: "Jason A. Donenfeld" , linux-kernel@vger.kernel.org Cc: "Jason A. Donenfeld" , linux-crypto@vger.kernel.org, x86@kernel.org, Greg Kroah-Hartman , Adhemerval Zanella Netto , Carlos O'Donell Subject: Re: [PATCH RFC v3] random: implement getrandom() in vDSO In-Reply-To: <20220916125916.652546-1-Jason@zx2c4.com> References: <20220916125916.652546-1-Jason@zx2c4.com> Date: Tue, 08 Nov 2022 09:32:19 +0100 Message-ID: <87v8np978s.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Sep 16 2022 at 13:59, Jason A. Donenfeld wrote: > --- > MAINTAINERS | 2 + > arch/x86/entry/syscalls/syscall_32.tbl | 1 + > arch/x86/entry/syscalls/syscall_64.tbl | 1 + > arch/x86/entry/vdso/Makefile | 3 +- > arch/x86/entry/vdso/vdso.lds.S | 2 + > arch/x86/entry/vdso/vgetrandom.c | 16 ++++ > arch/x86/include/asm/vdso/getrandom.h | 37 ++++++++ > arch/x86/include/asm/vvar.h | 16 ++++ > drivers/char/random.c | 64 ++++++++++++++ > include/vdso/datapage.h | 6 ++ > lib/crypto/chacha.c | 4 + > lib/vdso/getrandom.c | 117 +++++++++++++++++++++++++ > lib/vdso/getrandom.h | 25 ++++++ > 13 files changed, 293 insertions(+), 1 deletion(-) > create mode 100644 arch/x86/entry/vdso/vgetrandom.c > create mode 100644 arch/x86/include/asm/vdso/getrandom.h > create mode 100644 lib/vdso/getrandom.c > create mode 100644 lib/vdso/getrandom.h This is not how it works. Please split this apart into reviewable bits and pieces: 1) Add the new syscall 2) Add the vdso infrastructure 3) Wire it up on x86 Thanks, tglx