Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3367671rwb; Tue, 8 Nov 2022 03:53:18 -0800 (PST) X-Google-Smtp-Source: AMsMyM7RH0SmtsSHQ3f3/FZhefyyKp087Mnn/SzbDFqUxMafzRet1oqvB4GY3QI3L6lUVlSrXYkH X-Received: by 2002:a17:907:a47:b0:79e:56dc:5373 with SMTP id be7-20020a1709070a4700b0079e56dc5373mr53012593ejc.148.1667908398589; Tue, 08 Nov 2022 03:53:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667908398; cv=none; d=google.com; s=arc-20160816; b=bslI+Y2ml+fpnEBU5DC2Etqg5G2hmjDUsx9TaEpDpbsnkFWOIm9jRPxjs+nsGiILLL SJ7s5EhAjUvv0YiK4YD0sHPmMGksKuAwlmLy6FPmnT6Oo5hiHqNZS2Wrp55QWdIT+WBt kTZCadawmFaGe2SbyhpkGUJW29qjZb2dqehgjyB5fO6RbCegnmFH75DwaTBXEUys1arF 1/2SJp8Ut+FvNRjGSv0w0KExGih8NJ1fwfARDKuL27TTrZOQoEhu7IDZpFaemvBxCcX5 T+CLFNZXTp4fUPz7zapC5+yUaXnxaFqxBdvc/FC7T6rmOGkMIPCNSMe7aTFXE1JN9XC6 xDtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=/QRzaz/OenfJp+r6yaKiscfmlDS/YWjOXCyB1m+YgKk=; b=hi9Zqn8lrkitTlG6W5b7MhbvPP1WKxFpuA3Nz8I9avHgMg0+2txp1BaXoTVlpTcCiu w5qYgIMzb14YVESP9gBPCoFvcxtg0PFyR2xKUTJlZR3X7Cfvx+w2oquXBHy+H1pQa7Ya Hb5Lh35Hvmwls+XxjZF5G7thWulrIXafAKNzQCh9KlALegOya1/juCH0Ach0FlXMFBfQ KtIXiKE3xd1T2DH6k3RRWjW4rodgJYwKfNbHP8t9ID2AECLL39tVDPfcp933jFDzTg/g Xsp27KlZWubyRKvLtxAZCVFps2eeveDNWYDbIL/BOD4K735gvXBIceivEXsEHI6HTxvL mW6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=OV+k2FSW; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho15-20020a1709070e8f00b007763cc7093csi13179687ejc.884.2022.11.08.03.52.47; Tue, 08 Nov 2022 03:53:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=OV+k2FSW; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233748AbiKHLkl (ORCPT + 99 others); Tue, 8 Nov 2022 06:40:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233910AbiKHLki (ORCPT ); Tue, 8 Nov 2022 06:40:38 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F422F4C27C; Tue, 8 Nov 2022 03:40:36 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AAB72B81912; Tue, 8 Nov 2022 11:40:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08E81C433C1; Tue, 8 Nov 2022 11:40:33 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="OV+k2FSW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1667907631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/QRzaz/OenfJp+r6yaKiscfmlDS/YWjOXCyB1m+YgKk=; b=OV+k2FSWl23wVW/XgY+M0THCyXgIwWOOnscqiT0kTaFqt9OM2LXZ+a3NYSlhhTW0Q1YeXM fz+EPyXERDas5CJJOIKcbhxi25MdszTwTplARLxBbg4aVTRVWAMWDVchmDFe1oF1UBaNVP 2KCv55EBic/9ijDa0c4ls+WGF8Kt15I= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 1e063cfe (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 8 Nov 2022 11:40:31 +0000 (UTC) Received: by mail-vs1-f41.google.com with SMTP id k67so13388010vsk.2; Tue, 08 Nov 2022 03:40:31 -0800 (PST) X-Gm-Message-State: ACrzQf2eO2lnR83ykqYxVdiByM9QyjsUqgXP7uw/FI+3WNIqVoSDYUXg +NVlLF7Ow/kYKOk2Kp5BNYA0pZeH8yCIJHyjJTA= X-Received: by 2002:a67:c297:0:b0:3aa:3cac:97b6 with SMTP id k23-20020a67c297000000b003aa3cac97b6mr29936878vsj.76.1667907630270; Tue, 08 Nov 2022 03:40:30 -0800 (PST) MIME-Version: 1.0 References: <20220916125916.652546-1-Jason@zx2c4.com> <87v8np978s.ffs@tglx> In-Reply-To: <87v8np978s.ffs@tglx> From: "Jason A. Donenfeld" Date: Tue, 8 Nov 2022 12:40:19 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RFC v3] random: implement getrandom() in vDSO To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, x86@kernel.org, Greg Kroah-Hartman , Adhemerval Zanella Netto , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Nov 8, 2022 at 9:32 AM Thomas Gleixner wrote: > > On Fri, Sep 16 2022 at 13:59, Jason A. Donenfeld wrote: > > --- > > MAINTAINERS | 2 + > > arch/x86/entry/syscalls/syscall_32.tbl | 1 + > > arch/x86/entry/syscalls/syscall_64.tbl | 1 + > > arch/x86/entry/vdso/Makefile | 3 +- > > arch/x86/entry/vdso/vdso.lds.S | 2 + > > arch/x86/entry/vdso/vgetrandom.c | 16 ++++ > > arch/x86/include/asm/vdso/getrandom.h | 37 ++++++++ > > arch/x86/include/asm/vvar.h | 16 ++++ > > drivers/char/random.c | 64 ++++++++++++++ > > include/vdso/datapage.h | 6 ++ > > lib/crypto/chacha.c | 4 + > > lib/vdso/getrandom.c | 117 +++++++++++++++++++++++++ > > lib/vdso/getrandom.h | 25 ++++++ > > 13 files changed, 293 insertions(+), 1 deletion(-) > > create mode 100644 arch/x86/entry/vdso/vgetrandom.c > > create mode 100644 arch/x86/include/asm/vdso/getrandom.h > > create mode 100644 lib/vdso/getrandom.c > > create mode 100644 lib/vdso/getrandom.h > > This is not how it works. Please split this apart into reviewable bits > and pieces: > > 1) Add the new syscall > 2) Add the vdso infrastructure > 3) Wire it up on x86 No problem, will do. Jason