Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3908286rwb; Tue, 8 Nov 2022 09:40:12 -0800 (PST) X-Google-Smtp-Source: AMsMyM5BF+qKqixiy2rBtCkWEeox2i/N3//n4d+m/BVUqZvTfwd0luALvKZ/4j763C03oOT3o+/Y X-Received: by 2002:a05:6402:5485:b0:459:147a:d902 with SMTP id fg5-20020a056402548500b00459147ad902mr59269437edb.263.1667929212000; Tue, 08 Nov 2022 09:40:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667929211; cv=none; d=google.com; s=arc-20160816; b=Bn6g5dg4aoL/xD+LNlt9UEOD7iL2u9WKq6uxMDRSp841XjyGLXSOY2N5SuKK8SbNoy O4uQQDoO5irYSVkoPI1G4oGGb/KSf7qrtf+f874jWTi76MfgcqshZBaRTIcVuCVh5NTs MoO4L09OS5z8bSOg/F4vbC4slX76qpi5xGK+ETsBCu8sgGNIsYaUTx9VnlXj14tMEiGd cQbVCTaU2LIUhq2JoJwp5M27eWCRFxUIDMsPVmXAlqhPmseynAtdcDZ2+MaBgmRU4EWf sgkdnA8cHHnu2ZW8+nbIRiL36CO7/AKKyHJ94YwjwS2pBORRafjcH414yjXQHCN2rzi+ H4tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=WFchwpYWTZe1uP8NzfYiIHuE3VUM7GlNjwOOVlNkivY=; b=ApLdo7mRwIUgA/mDT0gG3hHVlD9yjVQzR/jfrQum8qdRbLjQyijfmOJZa8fQpysKAd FaZPJcS98mozlFqWvO0nNOArNGMR5temPcQoWdqahA8W50sehQJe0TMd0zgl7U0E7+x9 o01hjgSCAXup2GivXGpvJgk21f0dIDggqt3aTYxK0dISjy9d1wmkrDgxgWdpx4YEvQrb 55zPsWgeCh42LtvlqcM+dPRGgbdoDP2ktRMVSmwLW1YWsnCaicEhCBa7C0Hi9UAnYGbG ZdKanLfE4lJX+rrT87q+8dtFRmDVmn9Eabk4t9ZXTZHQPpOKqHLnuHpHDFDTDJRMwHad b/Jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=X8TWEhxg; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gn1-20020a1709070d0100b00791a41d1b39si13510804ejc.656.2022.11.08.09.39.47; Tue, 08 Nov 2022 09:40:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=X8TWEhxg; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234448AbiKHRbZ (ORCPT + 99 others); Tue, 8 Nov 2022 12:31:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234125AbiKHRbX (ORCPT ); Tue, 8 Nov 2022 12:31:23 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20D031DDDD; Tue, 8 Nov 2022 09:31:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ACB8C616EF; Tue, 8 Nov 2022 17:31:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 795BBC433B5; Tue, 8 Nov 2022 17:31:21 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="X8TWEhxg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1667928678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WFchwpYWTZe1uP8NzfYiIHuE3VUM7GlNjwOOVlNkivY=; b=X8TWEhxgMqUY3ABKegdYHjdTULR1ZAEQzm/G3BRcJHsT3IMdcLhB/GXyxlyHExuWSMEb+L wzLJtg1bPIWtG9zqERGIRh7/8hr1aN3VjKE+y0AE/zjRg+gcSNy5I6AONviXfni+IH363+ QQRKnVbPdHfwtKnwknSH1V9RCICTNsc= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 277c757f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 8 Nov 2022 17:31:18 +0000 (UTC) Received: by mail-vs1-f52.google.com with SMTP id z189so14321125vsb.4; Tue, 08 Nov 2022 09:31:17 -0800 (PST) X-Gm-Message-State: ACrzQf2VaSLNfefNdPDdBntwxPARsvsGkRJWzXtWUlLW/G/v5hbaLTHP VaATmjWqePZdD60rE+yzJhNkGm8RDIsYciiqwwo= X-Received: by 2002:a05:6102:f9a:b0:3aa:1a11:2702 with SMTP id e26-20020a0561020f9a00b003aa1a112702mr29981791vsv.73.1667928676884; Tue, 08 Nov 2022 09:31:16 -0800 (PST) MIME-Version: 1.0 References: <202211080929.F5B344C9F@keescook> In-Reply-To: <202211080929.F5B344C9F@keescook> From: "Jason A. Donenfeld" Date: Tue, 8 Nov 2022 18:31:05 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Coverity: add_early_randomness(): Integer handling issues To: coverity-bot Cc: linux-kernel@vger.kernel.org, "Theodore Ts'o" , Dominik Brodowski , Olivia Mackall , linux-crypto@vger.kernel.org, Herbert Xu , "Gustavo A. R. Silva" , linux-next@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org "If "bytes_read * 8 * rng->quality / 1024" is greater than 0x7FFFFFFF, the upper bits of the result will all be 1." Except "bytes_read" is an int. So false positive. Jason