Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp228354rwb; Wed, 9 Nov 2022 01:24:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf6r/+nE2d6C1DXsmGhUHKrweK5jxpSYOwOlFitRG4l7iHsbUeNV6wVdmYRgY00iw4ZnUfj2 X-Received: by 2002:a17:902:744b:b0:188:8e6b:978a with SMTP id e11-20020a170902744b00b001888e6b978amr5043700plt.11.1667985862037; Wed, 09 Nov 2022 01:24:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667985862; cv=none; d=google.com; s=arc-20160816; b=gZMGlvahtdQE93PdpWnzmuPo5giyqLS7ee8ElUfL1Y+S9H45hzzY6ooiSwUFKnhe6e JUlBGJvtSN8kUz8T1xXXLiNXAQn9m5Dr2AFRO1R7XzndvxvtgBhFToGaDaW3PtpMMOVi k1UPdz9QnlM3A+lnPFygCZ4fV6r6KQdxewxZ/Iq5CCvrlFZiCgq3nEQtmo8kinPcpNGr B+iT7cA3AsHmryNQPcYhG+U7ORpr2NBvEO11tMFRut2vIrCmW2kzwztf0QHPpUw8w1MR 3MrG55eVwm6IYQfGBHP2rGSZWwo0A3ee/9/FkNFbAl9SZN2YWooTCxtuIYBuk/fMX8Ge s6cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=yfKUqAnV4eqOC4A3r1ah3GC34n1oV8QOQ/aNQmn4abU=; b=MX9mVj9f2AsWJFE3cl6VkoG2KsWc7Zg3GF6cvItAvqym6uRkTgvsdI9cTVXgz9GiPU 54ufWFMSfQMhnr7tv3mOuk3W6vaBHicGfNXTjyAczlknnslPqTqrZWeCH5TLaczE4Paq 8M/TjGbR0giRzySq7gP5BzONZsQoQI6PIQ6XHMnhnRBdG8vMbzymkbQQnkUnJz/buMLW 9AcvJCVYwWG/UJIwiLmKK66axoztdsrqL9Gs/ds2xuDzadV9Foq392taNsGSaIr0BYWH 7O7eswmTzz5i8xdePbTj6TyMAjQF1Q+PljNfFLodQmnKPNuE2UOI+uQ1ldCtTMUjTWV2 XnzA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f16-20020a63f110000000b0043954dec8c1si17343785pgi.615.2022.11.09.01.24.01; Wed, 09 Nov 2022 01:24:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229527AbiKIJSz (ORCPT + 99 others); Wed, 9 Nov 2022 04:18:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229750AbiKIJSy (ORCPT ); Wed, 9 Nov 2022 04:18:54 -0500 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1080E13E95; Wed, 9 Nov 2022 01:18:47 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oshDc-00BxsQ-By; Wed, 09 Nov 2022 17:18:37 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Wed, 09 Nov 2022 17:18:36 +0800 Date: Wed, 9 Nov 2022 17:18:36 +0800 From: Herbert Xu To: liulongfang Cc: wangzhou1@hisilicon.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto/hisilicon: Add null judgment to the callback interface Message-ID: References: <20220930024320.29922-1-liulongfang@huawei.com> <717adf23-3080-5041-14ed-6ab5dcaddbf9@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Nov 09, 2022 at 02:21:11PM +0800, liulongfang wrote: > > The trigger method is to not call the function skcipher_request_set_callback() > when using the skcipher interface for encryption and decryption services. Yes but which function exactly? Please give the exact call path leading to this crash. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt