Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <01a24370-895c-465a-c7fb-0c6a86c301bc@amd.com>
Date:   Tue, 15 Nov 2022 16:44:46 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [PATCH Part2 v6 14/49] crypto: ccp: Handle the legacy TMR
 allocation when SNP is enabled
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     Vlastimil Babka <vbabka@suse.cz>, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        linux-crypto@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
        jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com,
        ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com,
        vkuznets@redhat.com, jmattson@google.com, luto@kernel.org,
        dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com,
        peterz@infradead.org, srinivas.pandruvada@linux.intel.com,
        rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com,
        michael.roth@amd.com, kirill@shutemov.name, ak@linux.intel.com,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com,
        dgilbert@redhat.com, jarkko@kernel.org,
        "Kaplan, David" <David.Kaplan@amd.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Oscar Salvador <osalvador@suse.de>
References: <Y0grhk1sq2tf/tUl@zn.tnic>
 <380c9748-1c86-4763-ea18-b884280a3b60@amd.com> <Y1e5oC9QyDlKpxZ9@zn.tnic>
 <6511c122-d5cc-3f8d-9651-7c2cd67dc5af@amd.com> <Y2A6/ZwvKhpNBTMP@zn.tnic>
 <dc89b2f4-1053-91ac-aeac-bb3b25f9ebc7@amd.com> <Y2JS7kn8Q9P4rXso@zn.tnic>
 <c2ce6317-aa51-2a2b-2d75-ad1fd269f3fa@amd.com>
 <7882353e-2b13-d35a-b462-cef35ee56f51@suse.cz> <Y3OuvXCjttfFh++w@zn.tnic>
 <Y3O94GPUECo+Gg6T@zn.tnic>
From:   "Kalra, Ashish" <ashish.kalra@amd.com>
In-Reply-To: <Y3O94GPUECo+Gg6T@zn.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2lqYlNOK09LcmFVaDVBUVhrUXpuYStYZ0VzWEx0ODlKUUd4aE5oNkQzSm12?=
 =?utf-8?B?ZkFXL3gybDZ0ZDBTdzYyb1JzVWZHSkg3cTZsSGFWbTM5SlZJVEdTMUJWeTA1?=
 =?utf-8?B?bHNwK1dGTE1HODBGUGJ3TTZYcldZOEdsejBRbDFBbWczU0JtblJDditneXVq?=
 =?utf-8?B?WEhIcFhlRjY4ZDVUVW51M1l5TkxTTm5uZDdpeDB0L3FzT3dYS3FRZ29IRWZF?=
 =?utf-8?B?Zjl0QW1HbE8zSG5nN2kveFYyQlJEV2hPVW5yb2x0Nk1Jd2pLdG8zcnJ5a3Ro?=
 =?utf-8?B?WUVuMDZUNjI4V3BLSkQzdDUxRDFPMmVMUE0yM1d3VUMwN1hzSzRWUGdaczFO?=
 =?utf-8?B?azJycjltU2lhU0N0YmVnc1cxZk1acUdwQjFTY0VFRlBCVktDbnpKampPMEJG?=
 =?utf-8?B?NDNZajVBZE1hREZjMGorWDVoc08yOS9rbjJrdnh6L0pieEhtWWdsMkMyaTN0?=
 =?utf-8?B?TTErenhGNS9SUm9aeHh4dlNlRktvai9LajF6RUlVOGFSQnpnUzBzanhUSGJj?=
 =?utf-8?B?T1JkRVFiWnNSME5ZeGlPS2lRdTNNbnNjNVBkL1pGL3FFQnBnenBNckhMWkww?=
 =?utf-8?B?QTNhTkhvdEdmMW50WE5QcHF5d3NGRURrc3lTSU9HbVI1L3ZnWmpnNkdsTHhl?=
 =?utf-8?B?VVJJY1YyU0tTa0J2cVBIODlpUlFvMlZlSFg5b0JUb29qN25aODBza2lLak1K?=
 =?utf-8?B?REZhR1hZM29xVUtSak5GZlBPeHhjUGc4cm5CM2d4T0YwdTVwcUxxbUZYUWN5?=
 =?utf-8?B?a3J1Tm45SzRZMG90TGxWODRnVTVlWTRqbnNydjdoUEhMYjZ2SHJQMnhsNW5s?=
 =?utf-8?B?aXhJYmpsdndZc0RiWHNxNEcxdHlFcXorWStEOWtweTN3blBHNkUranV1cG1L?=
 =?utf-8?B?MjNUUFNGR09vdUdFcGxDMjFlRFpvbWpPVUhCS25aVnB6ODBFVnFDdWtLR1V1?=
 =?utf-8?B?bTJ0ZmhORVBjZ1FQWVpoQW9FRyt3cUxGRDlYdGxEWkZ0TDZpNHRNNTQ5QkM1?=
 =?utf-8?B?dGxKd1U0cjBHN0R0MFQ4a0JQbFB6cmIwMk02MkxlcGQ3VWdZVlVyUzYvd0ZB?=
 =?utf-8?B?Q091YW5OTFF1bGZNNnpQdnV0M21CdWE2ckY3d1ZSS3I4SjFvejF2T0UxR1do?=
 =?utf-8?B?LzBZRVlaaDRPQUtCWEpZSk0yaXdqaC9zY1FUVWpHdjBMcG0yUUIrNWp0L1VQ?=
 =?utf-8?B?RWgvcU82Q2Yrc3VYdno1RklNbituYVdZOC8zZWdoak54Y0NoalMyRTRqdHhQ?=
 =?utf-8?B?NjJXMC9ZNytMekMrY0o2ak9UNFdIcVJaQXlSRXJLUWlzTWhHZHQ2bHhaL0xQ?=
 =?utf-8?B?T0JUOXN3NDR2MUtkUFFrdEMvVUNOTisxUGcvT0dkcXJzZTd5T0Rld3RrMTNo?=
 =?utf-8?B?dldJSjY2K2xIYjJHOElWZFhibWNqbVhpRVFNaCtPL1pLV080WG9CUGtCbDkv?=
 =?utf-8?B?SnE3UnVZSHVFbXpsSy9aK0s2d0pwTUEzSW45K2I1OU05cnorcy9lSkF5VGJ6?=
 =?utf-8?B?SkVSbnVIaEdyZlVhdDZ2Z1l6cC9IKytiUEF3citISDhvaS94YU5ubkhseTNs?=
 =?utf-8?B?S3hvbXNLQytFM2taUk8rKytGRWU0dllZQ1dnUndLdll4aVJ6M3JoaHcwRWl4?=
 =?utf-8?B?Q2lSMndVbTJ3di9BZ2FyMmFTN0FwYVIyQnFsT3UwKzFTWDRlWXM1TktzUVQ5?=
 =?utf-8?B?ZGEvVDN2ZHkwMWZSMVVFQ2N4dC9WZVBKcHZwcHh0OFVZaVI5SllYVXhtbHFJ?=
 =?utf-8?B?MjNVTE8vdDVTZUUra0w1czlabVlnUmFHdjd6SHZZWk9CNGJhZ0s4YldSeFkz?=
 =?utf-8?B?WUVxczVRVitzdmFtT2RHTDJoWXYrWjhOWmZwazJQOTVDWmxQYi9YOHRuUkJi?=
 =?utf-8?B?WUQxblUxbDFFeTF0UW9UWE44d3FQQklvTkd3dTl5QnZYV3g3UHdVK2NPUVVN?=
 =?utf-8?B?RERLZzlIbU5yUDh0bm1obldPQ2RMd3BmcU1DeFpnbG1QUGt1TUVkYXZHSXlx?=
 =?utf-8?B?SmxNOE8yMEs1TjBQVDhxYkxpNWNFbDJPbUFjRnJzMG1zbHFIWHpNTDliYzh6?=
 =?utf-8?B?ejAzcGxnWURaMGMyN2UxS2ZQUG5oTExqazRCRU5XMU5JcjdGQkNZczArK05z?=
 =?utf-8?Q?3wlm/46DukmUB4MRjRahwpR28?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f57ecdb0-55da-424b-3a1c-08dac75b0277
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 22:44:52.5384
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EzPzdr+JPicRVXGn5edXS41rERi4GJVrllTYlB8s9MyY9AGZTk46MiZZuTlzwbfBAadLhYTsDCj274UsvuyEWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6124
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Hello Boris,

On 11/15/2022 10:27 AM, Borislav Petkov wrote:
> And,
> 
> as dhansen connected the dots, this should be the exact same protection
> scenario as UPM:
> 
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F20221025151344.3784230-1-chao.p.peng%40linux.intel.com&amp;data=05%7C01%7Cashish.kalra%40amd.com%7Cbfecf32a51eb499b526d08dac726491e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638041264625164355%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3RqOC3b9qn0%2B2IRsTZURBmhAVtOn7rARR6fOMOsrFpE%3D&amp;reserved=0
> 
> so you should be able to mark them inaccessible the same way and you
> won't need any poisoning dance.

With UPM, the guest pages are all still freed back to the host after 
guest shutdown, so it's not clear how this would help with handling of 
leaked pages, for e.g, the host can still access these pages once the 
guest is shutdown and it will cause the RMP violation #PF at that point.

Additionally, our use case is of host allocated firmware pages as part 
of the crypto driver (to be passed to SNP firmware api calls
and then re-transitioned back to host state on return) so these are not 
guest private pages in the true sense and they need to be
handled differently in case there is a failure in reclaiming them.

Can you elaborate on what you have in mind ?

Thanks,
Ashish

> 
> And Michael has patches so you probably should talk to him...
> 
> Thx.
>