Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1361035rwb; Wed, 16 Nov 2022 16:34:46 -0800 (PST) X-Google-Smtp-Source: AA0mqf41O9W4gZSClTTZNZHZpHvlBTQoYaIfXuHKOekeqOKQrw34CYgnnbxY+SdS3NWKiqAdlU2Q X-Received: by 2002:a17:90b:48cf:b0:205:e1af:68d1 with SMTP id li15-20020a17090b48cf00b00205e1af68d1mr6144643pjb.121.1668645286278; Wed, 16 Nov 2022 16:34:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668645286; cv=none; d=google.com; s=arc-20160816; b=VtA0B7nrWd8/jjBBsgUFgE4N3RVbz1zqUW5acaRaJUisqggUTu7SfuTq4FhtnuDTHZ VSQk3vbYJgQd+zRzofO63fsvELQU2p6OUPpVMwoLIXarYqAudauprggQXthOvticNkf5 Cijk7G0JqaY17xsVLSajWpyr//8PtTyJWtdAqqvBJX4AfQ86YX3cHvjcNb926REbTcZE ZhR/murp9PU866gIYXQQNzoaySMZkzAKUAtCnmUlv631ESTk7XvIi5rfksVx6k5MwVgH osEyg5Vrn4paRAHgFtLfnU0qimzAz0zTHI/oh3BS56CZ19srjysAbhQ6OzMRN9DQFB9l L/bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bfYTHCNCtdWeHJf9pplhisQ2FfqYgZ1s/D8ukZJ0aF0=; b=ZTvUMfPDGxowNTTtpzKfBU3pDAOSEV3NtLPd+IFiFAobIeaYu/CThX4gQeXkD4276E z+qRFF7OSBos9RWZy3JyqlREyl1ycJZUBKIfrU7QobdKP6SGiP/ZlZrfGD1ZeKSLwmr0 xy7Y/rY2AGGKdy8W5p0JR8clOO36eWY0WpfIwNDHUbfy7f93Fjwu4fHM//exEou/kiT9 K6aBDf3CBwWE5csgaqCubte1p1LCoZ9B4ZiZw8QkpWAug9DMOD8tnxE+UBsNqLX9FT+8 fc1FoY9Uc3KY6pMT6t/Pi0Lw/5qrE6FP15dYIeKKJ+LieoZtw6gTJ7GfmhJtMaKf7S9z 1usg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=noLKefdE; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b21-20020a056a000cd500b0056d919bf4a8si16507995pfv.270.2022.11.16.16.34.26; Wed, 16 Nov 2022 16:34:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=noLKefdE; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234430AbiKQAbV (ORCPT + 99 others); Wed, 16 Nov 2022 19:31:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233023AbiKQAbU (ORCPT ); Wed, 16 Nov 2022 19:31:20 -0500 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EF6A532C3 for ; Wed, 16 Nov 2022 16:31:19 -0800 (PST) Received: by mail-pl1-x631.google.com with SMTP id 4so144487pli.0 for ; Wed, 16 Nov 2022 16:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bfYTHCNCtdWeHJf9pplhisQ2FfqYgZ1s/D8ukZJ0aF0=; b=noLKefdE/A5/nbmTvR6mJw3cGxk/a7fIL83IBp5Ph1Sax30+McHCvDQ9202nLf5uce hPc2gZOe0LsvudzlGDyBmEAgwDGtCwPT27+S6nCdQzTHR81ueFyHGEG25Bj0t5HJUYw6 csu11i/pEoPga4S6lvqc8FbzvURZMsHN35+PY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bfYTHCNCtdWeHJf9pplhisQ2FfqYgZ1s/D8ukZJ0aF0=; b=nELOnnVUeUDwy2DFgjgMlCrlGvsWeHRNMIOpwd/uwNNdjivamfxwDqDKZAlNAuSESp lvlzlJEPQNlD1BdCvz1asEaQ7JaQP8oOAGNqDhSlZ+elX9OIzE68/AHtJKkiT4baeg8r ng+2dibHR0K8iZjjm78BaqM/0aEG4OajmgGIP5Sgl2OXaQ0ZV33VhOdRRZyysYBm3xXQ MNSqNXzrdOLdLQlWILU/yt0X9K5B5NPfVgROM0gfs+ep7GRHIGC2EJ3V/b5uTE1dl7+u m5iWQGHAHx+E9Lfq9wOZFcbYIulfyNQrAFSHdwfN9GudSk6MLjS+sYozqwaX74AJnznD N1LA== X-Gm-Message-State: ANoB5plwi9fDYKTH4aFdjB6mj5lf0+rVggWCUQfDc5ZZw5ls0ksvuFG9 QY3/biw26SbaqpJTSgFVVGcNGQ== X-Received: by 2002:a17:90a:6949:b0:213:188c:158d with SMTP id j9-20020a17090a694900b00213188c158dmr343097pjm.11.1668645079035; Wed, 16 Nov 2022 16:31:19 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id s1-20020a170902ea0100b00174f61a7d09sm12946657plg.247.2022.11.16.16.31.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 16:31:18 -0800 (PST) Date: Wed, 16 Nov 2022 16:31:18 -0800 From: Kees Cook To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, Greg Kroah-Hartman , Jakub Kicinski , Russell King , Catalin Marinas , Thomas Bogendoerfer , Heiko Carstens , Herbert Xu , Christoph =?iso-8859-1?Q?B=F6hmwalder?= , Jani Nikula , Jason Gunthorpe , Sakari Ailus , "Martin K . Petersen" , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Richard Weinberger , "Darrick J . Wong" , SeongJae Park , Thomas Gleixner , Andrew Morton , Michael Ellerman , Helge Deller , netdev@vger.kernel.org, linux-crypto@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mmc@vger.kernel.org, linux-parisc@vger.kernel.org, ydroneaud@opteya.com Subject: Re: [PATCH v2 3/3] treewide: use get_random_u32_between() when possible Message-ID: <202211161628.164F47F@keescook> References: <20221114164558.1180362-1-Jason@zx2c4.com> <20221114164558.1180362-4-Jason@zx2c4.com> <202211161436.A45AD719A@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Nov 17, 2022 at 01:03:14AM +0100, Jason A. Donenfeld wrote: > On Thu, Nov 17, 2022 at 12:55:47AM +0100, Jason A. Donenfeld wrote: > > 2) What to call it: > > - between I still like, because it mirrors "I'm thinking of a number > > between 1 and 10 and..." that everybody knows, > > - inclusive I guess works, but it's not a preposition, > > - bikeshed color #3? > > - between > - ranged > - spanning > > https://www.thefreedictionary.com/List-of-prepositions.htm > - amid > > Sigh, names. I think "inclusive" is best. The other words still don't provide unambiguous language. It's the language used in formal math, e.g. sigma-notation, etc. It's an adjective for "get random" (verb, noun). -- Kees Cook