Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1519482rwb; Wed, 16 Nov 2022 20:01:24 -0800 (PST) X-Google-Smtp-Source: AA0mqf7JGCZSmyulTqGCdACHSnW4kD89gEn+Yu9OS1693sdxT9ndCOBId/eLKiiNk1eHqKLMYxSt X-Received: by 2002:a17:90a:4b81:b0:213:5a4d:8138 with SMTP id i1-20020a17090a4b8100b002135a4d8138mr985194pjh.17.1668657683875; Wed, 16 Nov 2022 20:01:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668657683; cv=none; d=google.com; s=arc-20160816; b=LTjFlhi/8+vYYHrlSNphe5pP1/WII7tGUkxKqvcUiU1oDCq2M2cVIcim1zvMSw1rDp iQK26POt1OKV2rtpj20gARvu0YkMVyjp/vCtuHKzhBoGAxH6Z+vERqts6oglIVhDk/aE X/J1sisK05PNYYbWx9zLTAaSN9qHGfHG4jd1o9vSo9od5ZGf1YzU73Jfg/meXogLNrKl 4eYPs/8rlwDH8BP9Ffjze56mp+PkV/3iq/iVk4GOQNvS8BNuKWh1uCoQA0VXAhJnIOEr vqZ1unfa8ZsoeH6V8si6a5xS4Hxq8DsMT9AZNHZsC2ndPTQWjZ2FxFD0N6VFNntlY/uI mZnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=2mE+yeeFm62IHb7SJN63V8lm5JptGRNrH0IV7aWFb38=; b=pnTmXacN2DZkehGvp65nW/fmSFnQm9x8jCQ+E8fvpXUFjeCkOMlwKNeqOFJKfFAjfO +Pqbi3Fr7i2MLul27ae1l/Tezxg0qXFCm8Gcpl3aEVpBis+eINLR8UW5pXUSWGzQhz8N pB01HfRfrmRhTyQkoRVfxENiPu6kmPQuKWi/u+BOhC1/C+zsm9t6OG/TqibJRo/zuo6U AKNNSk4Sr/6kQ5BP//7p6qp6PggFLK59I9QGWB4t5VOsCnlwbH1SdXQUrgaKUY7BtEsd hwhXTT1cAlIC0iCWgi1ImasB8VV6NrsM/MaBNM0FCKbJan2JV/Y4DfQ/ue4BZ9C6xkiG I/aA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b37-20020a631b25000000b004704b8534c9si16965734pgb.809.2022.11.16.20.01.02; Wed, 16 Nov 2022 20:01:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233477AbiKQD7H (ORCPT + 99 others); Wed, 16 Nov 2022 22:59:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234045AbiKQD7G (ORCPT ); Wed, 16 Nov 2022 22:59:06 -0500 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 635A21403D; Wed, 16 Nov 2022 19:59:02 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1ovW30-00F4UP-Dk; Thu, 17 Nov 2022 11:58:43 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Thu, 17 Nov 2022 11:58:42 +0800 Date: Thu, 17 Nov 2022 11:58:42 +0800 From: Herbert Xu To: Robert Elliott Cc: davem@davemloft.net, tim.c.chen@linux.intel.com, ap420073@gmail.com, ardb@kernel.org, Jason@zx2c4.com, David.Laight@aculab.com, ebiggers@kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/24] crypto: fix RCU stalls Message-ID: References: <20221103042740.6556-1-elliott@hpe.com> <20221116041342.3841-1-elliott@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221116041342.3841-1-elliott@hpe.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Nov 15, 2022 at 10:13:18PM -0600, Robert Elliott wrote: > This series fixes the RCU stalls triggered by the x86 crypto > modules discussed in > https://lore.kernel.org/all/MW5PR84MB18426EBBA3303770A8BC0BDFAB759@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM/ > > Two root causes were: > - too much data processed between kernel_fpu_begin and > kernel_fpu_end calls (which are heavily used by the x86 > optimized drivers) > - tcrypt not calling cond_resched during speed test loops > > These problems have always been lurking, but improving the > loading of the x86/sha512 module led to it happening a lot > during boot when using SHA-512 for module signature checking. Can we split this series up please? The fixes to the stalls should stand separately from the changes to how modules are loaded. The latter is more of an improvement while the former should be applied ASAP. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt