Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Nov 2022 12:59:34 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Taehee Yoo <ap420073@gmail.com>
Cc:     linux-crypto@vger.kernel.org, davem@davemloft.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        kirill.shutemov@linux.intel.com, richard@nod.at,
        viro@zeniv.linux.org.uk,
        sathyanarayanan.kuppuswamy@linux.intel.com, jpoimboe@kernel.org,
        elliott@hpe.com, x86@kernel.org, jussi.kivilinna@iki.fi
Subject: Re: [PATCH v4 1/4] crypto: aria: add keystream array into request ctx
Message-ID: <Y3cRNuYd92QUthDC@gondor.apana.org.au>
References: <20221113165645.4652-1-ap420073@gmail.com>
 <20221113165645.4652-2-ap420073@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221113165645.4652-2-ap420073@gmail.com>
Precedence: bulk

On Sun, Nov 13, 2022 at 04:56:42PM +0000, Taehee Yoo wrote:
>
> @@ -130,6 +135,13 @@ static int aria_avx_ctr_encrypt(struct skcipher_request *req)
>  	return err;
>  }
>  
> +static int aria_avx_init_tfm(struct crypto_skcipher *tfm)
> +{
> +	crypto_skcipher_set_reqsize(tfm, sizeof(struct aria_avx_request_ctx));
> +
> +	return 0;
> +}
> +
>  static struct skcipher_alg aria_algs[] = {
>  	{
>  		.base.cra_name		= "__ecb(aria)",
> @@ -160,6 +172,7 @@ static struct skcipher_alg aria_algs[] = {
>  		.setkey			= aria_avx_set_key,
>  		.encrypt		= aria_avx_ctr_encrypt,
>  		.decrypt		= aria_avx_ctr_encrypt,
> +		.init			= aria_avx_init_tfm,
>  	}
>  };

You need to set the new flag CRYPTO_ALG_SKCIPHER_REQSIZE_LARGE
or else users of sync_skcipher may pick up this algorithm and
barf.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt