Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4c7c3b8f-f6f3-cd74-239c-af93bb2642a6@gmail.com>
Date:   Fri, 18 Nov 2022 15:08:13 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v4 1/4] crypto: aria: add keystream array into request ctx
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     linux-crypto@vger.kernel.org, davem@davemloft.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        kirill.shutemov@linux.intel.com, richard@nod.at,
        viro@zeniv.linux.org.uk,
        sathyanarayanan.kuppuswamy@linux.intel.com, jpoimboe@kernel.org,
        elliott@hpe.com, x86@kernel.org, jussi.kivilinna@iki.fi
References: <20221113165645.4652-1-ap420073@gmail.com>
 <20221113165645.4652-2-ap420073@gmail.com>
 <Y3cRNuYd92QUthDC@gondor.apana.org.au>
Content-Language: en-US
From:   Taehee Yoo <ap420073@gmail.com>
In-Reply-To: <Y3cRNuYd92QUthDC@gondor.apana.org.au>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Herbert,
Thank you so much for your review!

On 11/18/22 13:59, Herbert Xu wrote:
 > On Sun, Nov 13, 2022 at 04:56:42PM +0000, Taehee Yoo wrote:
 >>
 >> @@ -130,6 +135,13 @@ static int aria_avx_ctr_encrypt(struct 
skcipher_request *req)
 >>   	return err;
 >>   }
 >>
 >> +static int aria_avx_init_tfm(struct crypto_skcipher *tfm)
 >> +{
 >> +	crypto_skcipher_set_reqsize(tfm, sizeof(struct aria_avx_request_ctx));
 >> +
 >> +	return 0;
 >> +}
 >> +
 >>   static struct skcipher_alg aria_algs[] = {
 >>   	{
 >>   		.base.cra_name		= "__ecb(aria)",
 >> @@ -160,6 +172,7 @@ static struct skcipher_alg aria_algs[] = {
 >>   		.setkey			= aria_avx_set_key,
 >>   		.encrypt		= aria_avx_ctr_encrypt,
 >>   		.decrypt		= aria_avx_ctr_encrypt,
 >> +		.init			= aria_avx_init_tfm,
 >>   	}
 >>   };
 >
 > You need to set the new flag CRYPTO_ALG_SKCIPHER_REQSIZE_LARGE
 > or else users of sync_skcipher may pick up this algorithm and
 > barf.
 >

Okay, I will set CRYPTO_ALG_SKCIPHER_REQSIZE_LARGE flag in the v5 patch.

Thanks a lot!
Taehee Yoo

 > Cheers,