Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp291030rwb; Fri, 18 Nov 2022 01:15:44 -0800 (PST) X-Google-Smtp-Source: AA0mqf716VPpcV16IyPPx7sQjwVpSxEYptLQ+UwFUEQmUEobMTRLlL6SUg2SkAQHStM8l0EYtYgT X-Received: by 2002:aa7:dd4d:0:b0:45c:98a9:7bbf with SMTP id o13-20020aa7dd4d000000b0045c98a97bbfmr5406051edw.372.1668762943973; Fri, 18 Nov 2022 01:15:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668762943; cv=none; d=google.com; s=arc-20160816; b=M5wLm3QSHeydCwMAXu2Ihe8HN2Ujn+qTF5Sv/+z2dW62ilJigJfw8gWtM0Ra57YMcd 7Gwy4m1Ka/szPwR5+WD/du78Ca5YMYtz9F23a0AAUeGmPT7Fy7IMr2QR9hg+c3Isr2Kb UEfGTf8EGgU+hkR1cKGIZvHVRx5Vg1AioXSpfE/h7wFbjTlVDLRcbRdxWJKI0655Ciqe FcRsvry5tf/s6k1CJEOvRHhjCIG1QVpPwmzoMLnnmTgP1D8ndBKNDi9mrCzMXxGW5mC+ u4c99C6dp5WmyU9wjQzfi1RGHPTn5bDoAcsVZ2aLwpHE9BB1l+vSGgmIvxVK0RHaWYGA W84w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=q8gAB+7RNjfWD37G1z1ZitEzjITHtmLlYfv4nJIOX9Q=; b=yE8DA283tx8isg7nRkSTyJgUCgisHd0WZXcyKbaBCIeIaBdV2LKvaXsGMHYVRZmxeX O+ilSvKJ3wt1+XBWrqGUTr0mt8+2fjkwmKGvJZUMYstqEsh7BtAUaipklAAGRM8IVVH8 uM00y54uaCFn2PLhpqtlIUSl5pUs69w7Olk250n7zIeLYS3RtmCcZo+CXbYY0lWQm9oj I3dSrjtB54fbDPmCRW9sEVUB4jVOGulWVw1C/sHu1A6luZC/75qa6bzrKdTyZ3v4b2uh 1b6z/UaOiWBZKdScs8ccjDXT5+odAg0sV8B+kNG00msdCmnCuuV+I7pugHtbjUc3Zp/2 xNCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds11-20020a170907724b00b0078bcc872a6esi2923903ejc.360.2022.11.18.01.15.19; Fri, 18 Nov 2022 01:15:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240700AbiKRJKo (ORCPT + 99 others); Fri, 18 Nov 2022 04:10:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241776AbiKRJKj (ORCPT ); Fri, 18 Nov 2022 04:10:39 -0500 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E52B86A5C for ; Fri, 18 Nov 2022 01:10:38 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1ovxOG-00FYNl-Em; Fri, 18 Nov 2022 17:10:29 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 18 Nov 2022 17:10:28 +0800 Date: Fri, 18 Nov 2022 17:10:28 +0800 From: Herbert Xu To: Gaosheng Cui Cc: gilad@benyossef.com, davem@davemloft.net, linux-crypto@vger.kernel.org Subject: Re: [PATCH] crypto: ccree - Remove debugfs when platform_driver_register failed Message-ID: References: <20221108082912.1818219-1-cuigaosheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221108082912.1818219-1-cuigaosheng1@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Nov 08, 2022 at 04:29:12PM +0800, Gaosheng Cui wrote: > When platform_driver_register failed, we need to remove debugfs, > which will caused a resource leak, fix it. > > Failed logs as follows: > [ 32.606488] debugfs: Directory 'ccree' with parent '/' already present! > > Fixes: 4c3f97276e15 ("crypto: ccree - introduce CryptoCell driver") > Signed-off-by: Gaosheng Cui > --- > drivers/crypto/ccree/cc_driver.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt