Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp294969rwb; Fri, 18 Nov 2022 01:20:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf5zEsfs6GpLEmw+1Bfl30c3dhIgvxeZ4rQL5aZqDBZ7dhnDsCWvDs5RWUueo+86MWqRBDEZ X-Received: by 2002:a63:602:0:b0:439:ac9b:34ee with SMTP id 2-20020a630602000000b00439ac9b34eemr5894873pgg.437.1668763211917; Fri, 18 Nov 2022 01:20:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668763211; cv=none; d=google.com; s=arc-20160816; b=EnLodFo1fwM0rXUulMUDZdJrV6AUsgNtmeO3pVhf+yv4zMQfKOfTWbh/x+KNeptqsW WA2I/vlsg35jilWejj+UhHLtDdtRHBS+Uyz+5dfIEnoYC+pJG5OAQy/kITw/02R96egT TfUq7OD1KQucVSMOoYQ6xeJ/uVf6o2Dxy9bvkQqIqo9J/cKGmFmnCYw5yXuBPZwBeykE sYw51+7He/MYUWh4XOQr6E8tt7Lzt2l8o7uMIpk6zzrjGbHhQHoq1/o41GO1eKuulrfL waONKnWNqcoHzGbH9M/Z5Ul4Jc6pSCzoNBW5EdOt+fqI04PbJAea7h+PmzehfwxQKD2b Hcrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=xmG7vUlruWnMP8+ZQYV4kZqii6ZjKjFGAnOgB0Jo1X8=; b=dUzajZwAl8dEsFagnpIZA9ef/3aF+GC/CsvmS3bFpgbVkzn80WypZw++/TuLgE8lR/ XCrsy8Yp8eq7yUEf1lV1LXna14/4nucbdH61XWSI6BTT7jKR4Cxfu13cdEqJyIhT/2gl rgniF+vrFXRVCtyRftUNcd7oS6KERuKx62vA3Mj/Ac1VafF1k9iz4b2OJafoltGdtpS2 F4rgLnbHTq5MXYrUQl1YiyU7JHOrKYfI73PXbUp7USAgwPxgHyV6EJkBu1DRAW/yPzaQ i9vKOPtHxdeBM/B9W/QuNTb5HoXoBdkMNRASlaProDKfz3sSd/Vt/XORQGFQ5DSXlB9S OYgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 73-20020a63064c000000b00476d1591b76si3344977pgg.119.2022.11.18.01.19.58; Fri, 18 Nov 2022 01:20:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241867AbiKRJSW (ORCPT + 99 others); Fri, 18 Nov 2022 04:18:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241901AbiKRJRr (ORCPT ); Fri, 18 Nov 2022 04:17:47 -0500 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4EC8942F2 for ; Fri, 18 Nov 2022 01:17:25 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1ovxUw-00FYZS-SE; Fri, 18 Nov 2022 17:17:23 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 18 Nov 2022 17:17:22 +0800 Date: Fri, 18 Nov 2022 17:17:22 +0800 From: Herbert Xu To: Xiongfeng Wang Cc: qianweili@huawei.com, wangzhou1@hisilicon.com, linux-crypto@vger.kernel.org, yangyingliang@huawei.com Subject: Re: [PATCH] crypto: hisilicon/qm - add missing pci_dev_put() in q_num_set() Message-ID: References: <20221111100036.129685-1-wangxiongfeng2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221111100036.129685-1-wangxiongfeng2@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Nov 11, 2022 at 06:00:36PM +0800, Xiongfeng Wang wrote: > pci_get_device() will increase the reference count for the returned > pci_dev. We need to use pci_dev_put() to decrease the reference count > before q_num_set() returns. > > Signed-off-by: Xiongfeng Wang > --- > include/linux/hisi_acc_qm.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt