Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <07f353fd-1f36-2f58-63da-b15d3473ab40@gmail.com>
Date:   Fri, 18 Nov 2022 19:45:13 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v5 3/4] crypto: aria: implement aria-avx2
Content-Language: en-US
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
        davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com,
        kirill.shutemov@linux.intel.com, richard@nod.at,
        viro@zeniv.linux.org.uk,
        sathyanarayanan.kuppuswamy@linux.intel.com, jpoimboe@kernel.org,
        elliott@hpe.com, x86@kernel.org, jussi.kivilinna@iki.fi
References: <20221118072252.10770-1-ap420073@gmail.com>
 <20221118072252.10770-4-ap420073@gmail.com>
 <Y3dK9hHXZSgpVdV1@sol.localdomain>
From:   Taehee Yoo <ap420073@gmail.com>
In-Reply-To: <Y3dK9hHXZSgpVdV1@sol.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Eric,
Thank you so much for your review!

On 11/18/22 18:05, Eric Biggers wrote:
 > On Fri, Nov 18, 2022 at 07:22:51AM +0000, Taehee Yoo wrote:
 >> +SYM_FUNC_START(aria_aesni_avx2_encrypt_32way)
 >
 > Please use SYM_TYPED_FUNC_START (and include <linux/cfi_types.h>) for all
 > assembly functions that are called via indirect function calls. 
Otherwise the
 > code will crash when built with CONFIG_CFI_CLANG=y.
 >
 > - Eric

Okay, I will use SYM_TYPED_FUNC_START for avx2 and avx512 in the v6 
patchset.

Thanks a lot!
Taehee Yoo