Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221116161642.1670235-1-Jason@zx2c4.com> <20221116161642.1670235-3-Jason@zx2c4.com>
 <Y3eT0fd/t270Qeaj@alley>
In-Reply-To: <Y3eT0fd/t270Qeaj@alley>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Fri, 18 Nov 2022 15:20:03 +0100
Message-ID: <CAHmME9pdPCkk=yiT74QjxkgX7TH24-YVb-0NU-=D7WrP95NcEw@mail.gmail.com>
Subject: Re: [PATCH RFC v1 2/6] vsprintf: initialize siphash key using notifier
To:     Petr Mladek <pmladek@suse.com>
Cc:     linux-efi@vger.kernel.org, linux-crypto@vger.kernel.org,
        Ard Biesheuvel <ardb@kernel.org>,
        Lennart Poettering <lennart@poettering.net>,
        Mike Galbraith <efault@gmx.de>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 18, 2022 at 3:16 PM Petr Mladek <pmladek@suse.com> wrote:
> > +     return 0;
>
> I believe that we should rather return NOTIFY_DONE here.
> It is rather a formal change. The value is 0 as well.
>
> That said, I have never really understood the difference between
> NOTIFY_OK and NOTIFY_DONE.

Ah yes, the varying degrees of apathy:

#define NOTIFY_DONE             0x0000          /* Don't care */
#define NOTIFY_OK               0x0001          /* Suits me */

In a sense, the fact that there's this return value at all indicates a
notifier block isn't *quite* the API we want, since this happens only
once and it really should never stop. But it's so convenient and small
to use that I think it's fine. Anyway, I'll use the right constant
here as you suggested.

Jason