Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     Eric Biggers <ebiggers@kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
CC:     "x86@kernel.org" <x86@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Sami Tolvanen <samitolvanen@google.com>
Subject: RE: [PATCH 0/11] crypto: CFI fixes
Thread-Topic: [PATCH 0/11] crypto: CFI fixes
Thread-Index: AQHY+yzRYe3fakVHM0eSxOcY4VJpEq5Ey7FA
Date:   Fri, 18 Nov 2022 15:43:55 +0000
Message-ID: <MW5PR84MB18424C160896BF9081E8CFCAAB099@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20221118090220.398819-1-ebiggers@kernel.org>
In-Reply-To: <20221118090220.398819-1-ebiggers@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Vx7e72cHtrxSIrksRcDJNr/c7qL+5OY1cJ3SxG7CKUnPrtKl1bNNzkFtuXQR?=
 =?us-ascii?Q?k2ffdfhS26td3d4hajnF4PQ6cVPqVjzjzNbHbZiHm+UllJW1uzq4JXTSBRr8?=
 =?us-ascii?Q?V+ucgluRUKh18NFNk6tphXZLPOvPR4r/ZYhkaiJkoidUtGBacpI/VYBpxNrQ?=
 =?us-ascii?Q?p3SA/luH6MHeqGBZAqPrcYVNUwXwTrm+fxbwg5hfM0HCF8T7Aj7VpGQHp4xa?=
 =?us-ascii?Q?zD3PSACvd4GlIp9JlYaI2r9iQoWGSItiniI8lOiwa1ops4Mp3Q49lpjTIJ8p?=
 =?us-ascii?Q?wvn4Tuqk6lA4bmxOifygaDFPhIo29+amEY4usluZeIutcrZvBr/g9uNZwogs?=
 =?us-ascii?Q?3nMJYahrHEbPsbh/hpkYtOVI7yDWGKzYcj3CujY7F+rrEtVPlxpO64Fkb6Go?=
 =?us-ascii?Q?LmDr2IzCU7W+TUUlBdITpSd1cPoCFT85Kb2C+M3XnKYajfTQEBD1h9A+EnP7?=
 =?us-ascii?Q?c4ywuY4bS8BnH+I/BMMyShrM8nBz9+inRfKTRlACgaUva+62K/jKDcdVY8E0?=
 =?us-ascii?Q?4xxIOghukAH5SR7JkYjuMIs62SprnvNdE4mYb+BJBALtisLB/ZsvwBTueJmp?=
 =?us-ascii?Q?mSpgbKvMNmQmayvHtLTrng3JkZuM1muIaWHoR6ecH02sGFO3roqHIPROWRy7?=
 =?us-ascii?Q?h6fGg/lWKT8LFyXskpthJ2q7Z0xRsHqiFdW/G6EyyfmiJlLZhl6tJ9SQESYz?=
 =?us-ascii?Q?HGgFswyGw0OVoLTfrakUL+bAJ9On1xIesLgp5KeGuQ6YmfJSeJ+/G+lsjnWl?=
 =?us-ascii?Q?vJ4TWfKlA4njrGwsYSNM6NHcFjtR5yiNNkkSuZbpAmmLfcnVsCQ/Og6bEYCy?=
 =?us-ascii?Q?wlN4ze0MYs5enZanEjizadmjYQZISCoU+b+2t3HDSEC0BuiHvV2N6wqXnrkd?=
 =?us-ascii?Q?tmElNUnrWuf5DTn0LRVfidROkOqVlKGWdnTyZXmUPmftiGF7GBto4CKkeo3s?=
 =?us-ascii?Q?wxx3Q//LdAe6u1RJZ9Dx2YQSdV+qRTuIQY8RCwyuPi6k77H1YxKLApMRqJl/?=
 =?us-ascii?Q?jOWwINEgMv/PaU/vDOsRoAz+jQPGqia9xrNn1YcSBinjqZZOyNhrFIN41eas?=
 =?us-ascii?Q?UI3aqBGBgNdbIt2od6xtvv8Ip7cN4Eb1t2TSFZJZSv8JNPqe/Ve5sLXZzdoY?=
 =?us-ascii?Q?B2HwzjXugYURBm6rEw5kjG86N3AQP2pO8fDFbdODMjoT4OK/CeoPbWX57Zox?=
 =?us-ascii?Q?77T0D+AEzT9DS155l4gS7n81hOmcFAsvL5RXYK7TWXbMj7dTSUct767G5zpU?=
 =?us-ascii?Q?rbq511hxetXXkl9DaBqaEttkypbzqpxcqs32XDA0jzvgbnS+Yz2EvQuKFtJw?=
 =?us-ascii?Q?LXZJSEll9ZDdAZ25ZSqq59RMdNC81uGLZuJi8+w8d+czlmH4/yhXLEo9re2W?=
 =?us-ascii?Q?IYZC3BA1xxZ9U1p9P4dNegm4Ch/5aQ35YT5ecbP/XE3ExFi/Yc+/Lx2kpapt?=
 =?us-ascii?Q?6poUPhMDdkFes/1XFSrFOI4ae3RPCjHhEDLxKDLTm06ApyuPK/KooHWZ1YDS?=
 =?us-ascii?Q?mq8n6TrrWgWlH8scmN1uaguxeKe10Dh/4+wkE6/X/No8mRgSCRfXdI4sgrKn?=
 =?us-ascii?Q?ssVP5+vQ/jjgYXhhpaE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: dde284d9-e36d-45ca-fb60-08dac97bb3a8
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2022 15:43:55.8546
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FXUtOtjjUPFhHWUmjcSqKBd2gMmAlSawG68mczUf1zXZb2fkpAXJm0wIrT6Sivzb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR84MB1693
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: qtFMSw048R60vRvTW9td9NXct2rbbLre
X-Proofpoint-ORIG-GUID: qtFMSw048R60vRvTW9td9NXct2rbbLre
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-18_04,2022-11-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0
 priorityscore=1501 adultscore=0 mlxscore=0 spamscore=0 malwarescore=0
 mlxlogscore=988 lowpriorityscore=0 phishscore=0 clxscore=1011
 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2211180091
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


> -----Original Message-----
> From: Eric Biggers <ebiggers@kernel.org>
> Sent: Friday, November 18, 2022 3:02 AM
> To: linux-crypto@vger.kernel.org
> Cc: x86@kernel.org; linux-arm-kernel@lists.infradead.org; Sami Tolvanen
> <samitolvanen@google.com>
> Subject: [PATCH 0/11] crypto: CFI fixes
>=20
> This series fixes some crashes when CONFIG_CFI_CLANG (Control Flow
> Integrity) is enabled, with the new CFI implementation that was merged
> in 6.1 and is supported on x86.  Some of them were unconditional
> crashes, while others depended on whether the compiler optimized out the
> indirect calls or not.  This series also simplifies some code that was
> intended to work around limitations of the old CFI implementation and is
> unnecessary for the new CFI implementation.

Some of the x86 modules EXPORT their asm functions. Does that leave them
at risk of being called indirectly?

arch/x86/crypto/camellia-aesni-avx-asm_64.S:SYM_FUNC_START(camellia_ecb_dec=
_16way)
arch/x86/crypto/camellia-aesni-avx-asm_64.S:SYM_FUNC_START(camellia_ecb_enc=
_16way)
arch/x86/crypto/camellia-aesni-avx-asm_64.S:SYM_FUNC_START(camellia_cbc_dec=
_16way)
arch/x86/crypto/camellia_aesni_avx_glue.c:asmlinkage void camellia_ecb_enc_=
16way(const void *ctx, u8 *dst, const u8 *src);
arch/x86/crypto/camellia_aesni_avx_glue.c:EXPORT_SYMBOL_GPL(camellia_ecb_en=
c_16way);
arch/x86/crypto/camellia_aesni_avx_glue.c:asmlinkage void camellia_ecb_dec_=
16way(const void *ctx, u8 *dst, const u8 *src);
arch/x86/crypto/camellia_aesni_avx_glue.c:EXPORT_SYMBOL_GPL(camellia_ecb_de=
c_16way);
arch/x86/crypto/camellia_aesni_avx_glue.c:asmlinkage void camellia_cbc_dec_=
16way(const void *ctx, u8 *dst, const u8 *src);
arch/x86/crypto/camellia_aesni_avx_glue.c:EXPORT_SYMBOL_GPL(camellia_cbc_de=
c_16way);

arch/x86/crypto/twofish-x86_64-asm_64-3way.S:SYM_FUNC_START(__twofish_enc_b=
lk_3way)
arch/x86/crypto/twofish.h:asmlinkage void __twofish_enc_blk_3way(const void=
 *ctx, u8 *dst, const u8 *src,
arch/x86/crypto/twofish_glue_3way.c:EXPORT_SYMBOL_GPL(__twofish_enc_blk_3wa=
y);


A few of the x86 asm functions used by C code are not referenced with
asmlinkage like all the others. They're not EXPORTed, though, so whether
they're indirectly used can be determined.

u32 crc32_pclmul_le_16(unsigned char const *buffer, size_t len, u32 crc32);

void clmul_ghash_mul(char *dst, const u128 *shash);

void clmul_ghash_update(char *dst, const char *src, unsigned int srclen,
                        const u128 *shash);