Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2350986rwb; Sat, 19 Nov 2022 14:14:34 -0800 (PST) X-Google-Smtp-Source: AA0mqf5rWf0NUeuzfUk6nQSKofrI02OcR137zdZMgj65mMnujRYV/+ztJkT2iwjEmNymSt0IG8Gm X-Received: by 2002:a17:902:6b44:b0:188:afa9:ba76 with SMTP id g4-20020a1709026b4400b00188afa9ba76mr5519126plt.58.1668896074685; Sat, 19 Nov 2022 14:14:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668896074; cv=none; d=google.com; s=arc-20160816; b=pOLPovkLpwpyc3pa1Vo1X0RL7y8ujAKMi1sWycDLpRAWoxdT3kQbK9REDifd/jp9zi daSq7OAnxqTFheOHZ3tnVar0KgpPfA30QneEwL3tRyBtt5C2zSyYehI1QxiWfNhNQywH fKWpRY3ykiiJ8fFAxlGfibEd0x7Sq2U1AIwiMUMsuqJyElIcr/0YFAL69LX7PqbGZZQK dsdswq/zpCAcvOAQXHeCp/1MbUWcy7rj95KJrCstugzZMzV/gJB1AxELZHc7goIaEp8Z zH2Z9gtCaJRN2e9SepZxtYAbn7Apo2R0ElA2aNIIV6SwxMc8Vbsn5D+Xf3FEhbVuEGTW 5XNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=D5VOb5boGkdAYN6wKDObbKOcC5cfqGCj4Tcvp7hhPw0=; b=WmW8Yi3qCZmaWPJ+NZEAydcwnw7JSuSubH6641WicH17Zpn+Wqsg+e+Y4fDFpsc5UG wWk2mrGlokwDiWnawZgupvguo0RYc5ofxa3V0LGO8TNUvmS1xcaaRWYZ/1X/vLRH7H3W x0njsRYCqJJaHdeTONntWEJwGVIr67VT+0n6MObm7DiB1Ub/uI2csilVtN2HSukhcpqa EOUJWUgyYbwRKzyZz4xAiWL9b95T5p3XqIimEp+3ShP1+ao0wUEJzGS+ioTgSVl8d5PW 8kpFAfUIRtqk4yoJ/LEIaOko4rCh8HW/ei7VzAFP2+BVaJvOLYERKAfwltQWVRxHpkUB 61xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F5DfA8zj; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m13-20020a637d4d000000b0043a20d57b46si7676294pgn.826.2022.11.19.14.14.12; Sat, 19 Nov 2022 14:14:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=F5DfA8zj; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232895AbiKSWMm (ORCPT + 99 others); Sat, 19 Nov 2022 17:12:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232799AbiKSWMl (ORCPT ); Sat, 19 Nov 2022 17:12:41 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E04E815806 for ; Sat, 19 Nov 2022 14:12:39 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id j16so13568836lfe.12 for ; Sat, 19 Nov 2022 14:12:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=D5VOb5boGkdAYN6wKDObbKOcC5cfqGCj4Tcvp7hhPw0=; b=F5DfA8zjOi7beeJdVQtVgCup1BtOIitT3erlErg9wAmPCv42ZXpSQnLI84+iykBhXw 0MQFsyMUhsDEv+vO8W+4DxirGQcVpNaUzgk6qsb7rS8f+xBUoUdMptcQRzSxVEBYtY9v chwetUJsG8oIFJ8aypQpc3Vt7cvSiy5/efvCAQzhsVTeT1iW8CeiU05lIyTHnCNqHcmr Mwak19tK12UGG0bd30rKm2qhWmu13CVFFOLibvZ0j8MChzbcbU9FLKgZkQAkZtxY1qIi NAakEpbDLAwXSRXeo44aD5v6IPQzOr6qScdTEbjrI40shdUglBhRYRb0FQeiGJXkKoyB 86vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D5VOb5boGkdAYN6wKDObbKOcC5cfqGCj4Tcvp7hhPw0=; b=1RlxOcBSuQlPWBjSfSKa5EBhy4uzDTIhD/O6rzcHE4u5/eA37FO0jOYpuyDgY3A2Eo yRFaNtKa6kgeuAZw1d0gpoV5TRMMIIqAI72K+IUXIuotWzmBRSV7khsYj8zEDNBz4Wz8 6gledisychi2/lcf/cnL11MUwu54bxVV3E6SEbiLpoAV55LW9/6E8awmdRJ6+fAHEXmP VQhg1cIZ4KYQxzBOT6Gvwaux7NN2HpIbiTt+EmnZvfhKuJV22ngNN7mhmyunj7nPsRyS 0BnBvBAzzXsHwh7/qmMOY0nffm8fSKgbVTlK1sGK7U7JOQhhjtIMiqJ+jfkLEA5iJUSq /WiA== X-Gm-Message-State: ANoB5pn80MZxHS9OXRxzMdasTJYK0pYbGjf0/b6xxYN3X0lLgBkDJwYl iJ4CjsKcCxAr1mAsBvTqZ4pCzPDFUdo9Ng== X-Received: by 2002:a05:6512:b9a:b0:4ae:611c:6549 with SMTP id b26-20020a0565120b9a00b004ae611c6549mr4843424lfv.231.1668895957890; Sat, 19 Nov 2022 14:12:37 -0800 (PST) Received: from Fecusia.lan (c-05d8225c.014-348-6c756e10.bbcust.telenor.se. [92.34.216.5]) by smtp.gmail.com with ESMTPSA id u3-20020a05651220c300b00496d3e6b131sm1234254lfr.234.2022.11.19.14.12.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Nov 2022 14:12:36 -0800 (PST) From: Linus Walleij To: linux-crypto@vger.kernel.org, Herbert Xu , "David S . Miller" Cc: phone-devel@vger.kernel.org, Stefan Hansson , Lionel Debieve , Maxime Coquelin , Alexandre Torgue , Linus Walleij Subject: [PATCH v1 0/4] crypto: stm32 - reuse for Ux500 Date: Sat, 19 Nov 2022 23:12:15 +0100 Message-Id: <20221119221219.1232541-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Experimenting by taking some small portions of the Ux500 CRYP driver and adding to the STM32 driver, it turns out we can support both platforms with the more modern STM32 driver. Upsides: - We delete ~2400 lines of code and 8 files with intact crypto support for Ux500 and not properly maintained and supported. - The STM32 driver is more modern and compact thanks to using things like the crypto engine. Caveats: - The STM32 driver does not support DMA. On the U8500 this only works with AES (DES support is broken with DMA). If this is desired to be kept I can migrate it to the STM32 driver as well. I have looked at doing the same for the Ux500 hash, which is related but I am reluctant about this one, because the Ux500 hardware has no interrupt and only supports polling. I have a series of modernizations for that driver that I have worked on and will think about how to move forward. Linus Walleij (4): dt-bindings: crypto: Let STM32 define Ux500 CRYP crypto: stm32 - enable drivers to be used on Ux500 crypto: stm32/cryp - enable for use with Ux500 crypto: ux500/cryp - delete driver .../bindings/crypto/st,stm32-cryp.yaml | 32 + drivers/crypto/Makefile | 2 +- drivers/crypto/stm32/Kconfig | 4 +- drivers/crypto/stm32/stm32-cryp.c | 334 +++- drivers/crypto/ux500/Kconfig | 10 - drivers/crypto/ux500/Makefile | 1 - drivers/crypto/ux500/cryp/Makefile | 10 - drivers/crypto/ux500/cryp/cryp.c | 394 ---- drivers/crypto/ux500/cryp/cryp.h | 315 ---- drivers/crypto/ux500/cryp/cryp_core.c | 1600 ----------------- drivers/crypto/ux500/cryp/cryp_irq.c | 45 - drivers/crypto/ux500/cryp/cryp_irq.h | 31 - drivers/crypto/ux500/cryp/cryp_irqp.h | 125 -- drivers/crypto/ux500/cryp/cryp_p.h | 122 -- 14 files changed, 315 insertions(+), 2710 deletions(-) delete mode 100644 drivers/crypto/ux500/cryp/Makefile delete mode 100644 drivers/crypto/ux500/cryp/cryp.c delete mode 100644 drivers/crypto/ux500/cryp/cryp.h delete mode 100644 drivers/crypto/ux500/cryp/cryp_core.c delete mode 100644 drivers/crypto/ux500/cryp/cryp_irq.c delete mode 100644 drivers/crypto/ux500/cryp/cryp_irq.h delete mode 100644 drivers/crypto/ux500/cryp/cryp_irqp.h delete mode 100644 drivers/crypto/ux500/cryp/cryp_p.h -- 2.38.1