Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221119221219.1232541-1-linus.walleij@linaro.org>
 <20221119221219.1232541-3-linus.walleij@linaro.org> <b0b346ca-7b47-758a-c9e7-e7fda2b0856b@foss.st.com>
In-Reply-To: <b0b346ca-7b47-758a-c9e7-e7fda2b0856b@foss.st.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Mon, 21 Nov 2022 15:05:43 +0100
Message-ID: <CACRpkdYf3RbPe3FL4wyxAJK0QJ1UqFMhLD=dNJm8VkO4YtZoeA@mail.gmail.com>
Subject: Re: [PATCH v1 2/4] crypto: stm32 - enable drivers to be used on Ux500
To:     Lionel DEBIEVE <lionel.debieve@foss.st.com>
Cc:     linux-crypto@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        phone-devel@vger.kernel.org, Stefan Hansson <newbyte@disroot.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Nov 21, 2022 at 2:36 PM Lionel DEBIEVE
<lionel.debieve@foss.st.com> wrote:

> One short comment.

>  config CRYPTO_DEV_STM32_HASH
>   tristate "Support for STM32 hash accelerators"
> - depends on ARCH_STM32
> + depends on ARCH_STM32 || ARCH_U8500
>
> I'm not seeing any compatible update in the HASH driver for Ux500.

Correct, I'm just enabling it to be compiled in right now. I haven't
figured out if I will reuse the hash for ux500 as well or just keep
the old driver as it is using polling only. Need to experiment and
figure out what gives the smallest and understandable amount
of code to maintain.

It doesn't hurt to enable it to be compiled in, ideally all depends
on ARCH ... should be removed and replaced with
ARCH_nnn || COMPILE_TEST anyway.

But if you insist I can drop this oneliner.

Yours,
Linus Walleij