Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221119221219.1232541-1-linus.walleij@linaro.org>
 <20221119221219.1232541-4-linus.walleij@linaro.org> <8f55596e-12e3-8968-ebe5-e90be38ca5cb@foss.st.com>
In-Reply-To: <8f55596e-12e3-8968-ebe5-e90be38ca5cb@foss.st.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Mon, 21 Nov 2022 15:07:42 +0100
Message-ID: <CACRpkdYr3RKidNUjJQG88wEua0OvMYRTHe_48W7N35C5MSsSKQ@mail.gmail.com>
Subject: Re: [PATCH v1 3/4] crypto: stm32/cryp - enable for use with Ux500
To:     Lionel DEBIEVE <lionel.debieve@foss.st.com>
Cc:     linux-crypto@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        phone-devel@vger.kernel.org, Stefan Hansson <newbyte@disroot.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Nov 21, 2022 at 2:35 PM Lionel DEBIEVE
<lionel.debieve@foss.st.com> wrote:

> + writel_relaxed(readl_relaxed(cryp->regs + CRYP_CR) | CR_KEYRDEN, cryp->regs + CRYP_CR);
>
> Why are you still using CRYP_CR here, would it be better to use cryp->caps->cr to keep compatibility?

I noticed that the first two registers were not moved in the memory map so
I just kept CR and SR as hard defines.

It could be argued that the code will be containing one less memory reference
and addition so it is more efficient, but it's so little so I am fine
to change it
to an offset in the caps if you prefer it to be uniform.

Yours,
Linus Walleij