Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5635260rwb; Tue, 22 Nov 2022 02:50:25 -0800 (PST) X-Google-Smtp-Source: AA0mqf4mROiTDBcQgUG7n1+UB2EPTuqjSJDL/1U4RdjXbFWyyRTTPilT5QfmHg7xb+0rnMiQ/k0k X-Received: by 2002:a17:906:b08b:b0:78d:e608:f064 with SMTP id x11-20020a170906b08b00b0078de608f064mr19376639ejy.34.1669114225701; Tue, 22 Nov 2022 02:50:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669114225; cv=none; d=google.com; s=arc-20160816; b=pxTaoiAPriIh3xkpVknGvAoPUEbvQ5UeryVh+5sO5SRJ+WnB7hyrYMW9M92Y6Pa5xN 36yn0DMUYSSATKtnj08wMv7HVjaADqwxKPFVNzUjtQwJcQ2w9XL88s5xSHuAkdInsKzO sBOHNKtMxOGJpZw6ig7S4OYn+B5eLBd5rarsmeU+0B2cDWhoYbo51NflUf35VC5gUjmj yxT5LJmz0l4x8+Bol6WpxuHzRn3aOHWSyuglws5b+C9UOOhW4TI/abgnbvuYOd6RxtDL wHBkquzeDdZs7NP4J4QkiQ/JU1tFqHRXe8vd6VMF6mqbCspS0kGe1oCv5kYYSyId1sR3 abAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=izVDKDv7Rl1i97cUDM6TUAYXEE94cHxeCRcaeu34Lpc=; b=mihURdqWFoCC7624HmREjjMgFmdeADTMz3gIXO2cwrHdO/Iq7ReuDaM85gXiodFQAy I+eK0TR6f0bs+ZOY5pyLwstw57OhoIaxZ/BU1pfB2IGenxGMwK9Ush0/HdMrPb9CZK6I Nd8SCFwiMRa5QEJdwO5W+sTSLjLbx0DBLRs47Db3pMeaB6ZlrxSJBESvFnS8jKrv8igj xQG2Qwkxmy4LsybzWJalWDZmaty8GBHj63j1S8YToVOFy2gDdEDRdsIkLeCwthBJsE/I 2iWewFiJqUr0JZYtCvZDSNzM6xaRXyGFzWIpqjEVCcumR2iEsA+ai7DOC8/50PrbisL9 DnWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="eVUoi/0O"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gs12-20020a1709072d0c00b007a00aaf659csi64907ejc.198.2022.11.22.02.50.01; Tue, 22 Nov 2022 02:50:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="eVUoi/0O"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230242AbiKVKrD (ORCPT + 99 others); Tue, 22 Nov 2022 05:47:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232875AbiKVKqh (ORCPT ); Tue, 22 Nov 2022 05:46:37 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A84A92AF7; Tue, 22 Nov 2022 02:44:25 -0800 (PST) Received: from zn.tnic (p200300ea9733e79b329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e79b:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 0631F1EC04E2; Tue, 22 Nov 2022 11:44:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1669113864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=izVDKDv7Rl1i97cUDM6TUAYXEE94cHxeCRcaeu34Lpc=; b=eVUoi/0OHuA53lMtrGjsdYDHp5hLMccabq4+OoUJGJ1FsI7Bw0SSo5TnN7EiSYVkP+uTeU YRq1nJxO653ALTWHR635+ACjmdJCuBxPNWOHrtzBvDlusLgHvwYaT3/ewl+ymQKv1ColJ3 3RClyvioX09qkHn5g39bRQO3uwV6W7U= Date: Tue, 22 Nov 2022 11:44:23 +0100 From: Borislav Petkov To: "Kalra, Ashish" Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, michael.roth@amd.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org Subject: Re: [PATCH Part2 v6 14/49] crypto: ccp: Handle the legacy TMR allocation when SNP is enabled Message-ID: References: <3a51840f6a80c87b39632dc728dbd9b5dd444cd7.1655761627.git.ashish.kalra@amd.com> <380c9748-1c86-4763-ea18-b884280a3b60@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Nov 22, 2022 at 04:32:18AM -0600, Kalra, Ashish wrote: > Please note that in both cases, these non-reclaimed pages cannot be > freed/returned back to the page allocator. You keep repeating "these pages". Which pages? What if you specify the wrong, innocent pages because the kernel is wrong? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette