Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Gaurav Jain <gaurav.jain@nxp.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        Horia Geanta <horia.geanta@nxp.com>,
        Pankaj Gupta <pankaj.gupta@nxp.com>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: RE: [EXT] [PATCH] crypto: caam - Use helper to set reqsize
Thread-Topic: [EXT] [PATCH] crypto: caam - Use helper to set reqsize
Thread-Index: AQHY/laFgIwbb5s0xUS+DAkaxiVoxa5KytEg
Date:   Tue, 22 Nov 2022 11:17:01 +0000
Message-ID: <AM0PR04MB6004FB2D687CB6D99AA3BFE9E70D9@AM0PR04MB6004.eurprd04.prod.outlook.com>
References: <Y3yZI18QRK0kdaX0@gondor.apana.org.au>
In-Reply-To: <Y3yZI18QRK0kdaX0@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+exnLEKB6MjW7t9AB+v9uBXIHhCUFbKZlUzMMpCs+FIqPQ613A6iY8lAoDu/?=
 =?us-ascii?Q?IRB5QX1th9qOggIRRs/OJ2EFZ/f9N8NDL8rwcH90j0ShcoXomwNCukklSCHd?=
 =?us-ascii?Q?L2R0Ku+oj0yZfYQV6zbXX9gVF68CLxbvHOlUWLccIfP95YaQ9WTLl1mA/ZJj?=
 =?us-ascii?Q?pfeo0ulAotSNHhUyEhAXOc5I3YDE6LsYED8ayGaLkzt6rP+S1gFsiATDxMla?=
 =?us-ascii?Q?UhTdUCND8JCAy+4kAllEQ9WjgXMdUweyXgN9taAIqNMNb/qXUocgWkknJ/4k?=
 =?us-ascii?Q?fHEPNjKq9J+PdNGfZoxFt5eMvOR7K5wi6c1HYFJPInZ01Tc45RDjhHA2PjHZ?=
 =?us-ascii?Q?Li71jrxzEqCCV2mpyr/QPYiSQMZG3Gp3BJNZTKbghCJ3upP131oO6c/+jxpP?=
 =?us-ascii?Q?M6+LRfzSTErVvsDORqjBiZVT+TY1OTt/lowt+lAGvGlKw2Fuxzrrl0YVwpSm?=
 =?us-ascii?Q?yqGJ3LtHM8qzkpLHO1KJIHJF0lGqfvoC+qM7gycEXPR69pwnAnoVz+vT/GSv?=
 =?us-ascii?Q?eHswpDqTBK7aeo1MPQKOvN0Q7n3rKf5VU88NTSwOJzWbaYjFR1kLGwjmIKzN?=
 =?us-ascii?Q?2+oSlcpX5Dk0T38Mes4O/KAM7ggM/QNDGO4UPqWRodMo+J1lJvIzzskKbAnD?=
 =?us-ascii?Q?rnA+5bqXS9OHyJhiOfD0aCsMrFC4hxe2ij36wuSVeyPZdhQsxwtxoEADW34d?=
 =?us-ascii?Q?Nhu2DeI9Lm2qz57O3QQ/zZk7db9gL53hs7YBu/FW5ZtKHv9ld69A4RsEGHYS?=
 =?us-ascii?Q?t0FKzYo6zAhbWSWnIu6OdBnC48c3hHkGzhv8zF5wFmJ1eO2vNULaRT0tate6?=
 =?us-ascii?Q?A4cpDXbG9P9yyUebZyR6FuVei9htsYR6Cry8BCy8thV1KclK7Dy3Jtmug2Ay?=
 =?us-ascii?Q?Rp5EpeWJQWXNho3b9q0Lr/nqjK+0a1eOqQOOuApsxRcrpaXkL/uoS1vXiE3Y?=
 =?us-ascii?Q?0i80wnQkq4FzduHd1LhIaiNOoJKdXP7eo72sBf6nY8y6QMNbNWhD2vzXqru5?=
 =?us-ascii?Q?k0tcRV8y/1K1GK7skB3OpwDi8IF+wSiFwMgEl0dEGeZi8jnbwVfLP0NRWyZ7?=
 =?us-ascii?Q?Uf4IANxcGzQXOXlr50POvsnRUx2uKa1BhlCQl7FW/H7C3ZCmq+ICKF9f5hcb?=
 =?us-ascii?Q?S2/o3RtmY0wlIy+L9iZZpDFUQ78DTCtNoGMTJdrGU4BwAeMph8qquh6/mcXe?=
 =?us-ascii?Q?0Qsy1s3QjnVBL+Hq5Xo7JbUatFKluosKD5aXTEI6fP2CdvBk8c7ckP5CVimY?=
 =?us-ascii?Q?cSx0E098UR95/mTaL2197D0QTPAwVpBEmE1kv+AUh6LuEOTnZ64fUauHX4yx?=
 =?us-ascii?Q?NUOkvzcufnnUddeKWxME4VyxaczBEkEcPl3EMZaHckfo9hgkdcfLM3+baIOn?=
 =?us-ascii?Q?ZrZTYZTdlHuZSHGy6/AsetA9NpwUMYKqPz7cZvx2QZMFSmPn85gT/8KweSBQ?=
 =?us-ascii?Q?TqUMoqcVeXRZ3Tb2P6jLHEGl17fgnzx13puavo2/zPxAr3QIfjUpSlMHrD4O?=
 =?us-ascii?Q?uvNeAnAaWLhfuT+GkWWfuOjPamD2UecLfV4wsj5nPBE1F96ZPAyavLMlaQaj?=
 =?us-ascii?Q?RBoK3dNWO2x2d6P1xxPIM0XExScPBR9OHlWjytcg?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6004.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9c982ac-6168-491c-b5bb-08dacc7b141a
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2022 11:17:01.6060
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1Hz++jTAMkPdYOf4aYncoZk67DEbdk1f7dF7scUz5MlWo9SafPuZUvAjXrfTJmkmuiwvT6WJRxKeuw11z5FDDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6917
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Reviewed-by: Gaurav Jain <gaurav.jain@nxp.com>

> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Tuesday, November 22, 2022 3:11 PM
> To: Horia Geanta <horia.geanta@nxp.com>; Pankaj Gupta
> <pankaj.gupta@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>; Linux Crypto
> Mailing List <linux-crypto@vger.kernel.org>
> Subject: [EXT] [PATCH] crypto: caam - Use helper to set reqsize
>=20
> Caution: EXT Email
>=20
> The value of reqsize must only be changed through the helper.
>=20
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>=20
> diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/caam/caampkc.=
c
> index 886727576710..642846693d7c 100644
> --- a/drivers/crypto/caam/caampkc.c
> +++ b/drivers/crypto/caam/caampkc.c
> @@ -1099,6 +1099,8 @@ static int caam_rsa_init_tfm(struct crypto_akcipher
> *tfm)  {
>         struct caam_rsa_ctx *ctx =3D akcipher_tfm_ctx(tfm);
>=20
> +       akcipher_set_reqsize(tfm, sizeof(struct caam_rsa_req_ctx));
> +
>         ctx->dev =3D caam_jr_alloc();
>=20
>         if (IS_ERR(ctx->dev)) {
> @@ -1141,7 +1143,6 @@ static struct caam_akcipher_alg caam_rsa =3D {
>                 .max_size =3D caam_rsa_max_size,
>                 .init =3D caam_rsa_init_tfm,
>                 .exit =3D caam_rsa_exit_tfm,
> -               .reqsize =3D sizeof(struct caam_rsa_req_ctx),
>                 .base =3D {
>                         .cra_name =3D "rsa",
>                         .cra_driver_name =3D "rsa-caam",
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fgondor=
.ap
> ana.org.au%2F~herbert%2F&amp;data=3D05%7C01%7Cgaurav.jain%40nxp.com%
> 7Ca470497faa5540d2b14508dacc6da6d8%7C686ea1d3bc2b4c6fa92cd99c5c301
> 635%7C0%7C0%7C638047068575576790%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> 3000%7C%7C%7C&amp;sdata=3DvTJzDwXqxU3VydsCSr2myyfTiY3DQ2IFc8Qyxads
> BkA%3D&amp;reserved=3D0
> PGP Key:
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fgondor=
.ap
> ana.org.au%2F~herbert%2Fpubkey.txt&amp;data=3D05%7C01%7Cgaurav.jain%40
> nxp.com%7Ca470497faa5540d2b14508dacc6da6d8%7C686ea1d3bc2b4c6fa92c
> d99c5c301635%7C0%7C0%7C638047068575576790%7CUnknown%7CTWFpbGZ
> sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0
> %3D%7C3000%7C%7C%7C&amp;sdata=3DgJ0koAZ3Rw6SNDquvcLWMat6IkOGbO
> wn94sM8XlMtq4%3D&amp;reserved=3D0