Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp10176041rwb; Fri, 25 Nov 2022 01:49:04 -0800 (PST) X-Google-Smtp-Source: AA0mqf45IRt2s+LXVp0b1gIi/lS3qmQi+5EG7foT8IPxMr3Ied0ohR7tYIhxHCh8Se0ZBBz3ce4J X-Received: by 2002:a05:6402:364:b0:461:ac48:a5ec with SMTP id s4-20020a056402036400b00461ac48a5ecmr34513054edw.193.1669369744681; Fri, 25 Nov 2022 01:49:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669369744; cv=none; d=google.com; s=arc-20160816; b=m399DPfFVRsbaqhvt6KsscKemth00zDPOBP4QooK40drAX5V9eeEUDG3JL4gnUjpld 1fH/90SqKa/akvGSDvF9sdupTav4FpP36GCjBBLxyRYI7vDGJDDzCcC2cDNcdIkSicjA tN5QrjjkFQVR6Kkei/JIvXk3qXQIWDwy73YDEJ9eAtQhYBAjUWWeTp7swDAYUHJ9/WyM mhhWWC1kOEToTg9lNbf4nFw0OwqjkbK2HhfTJMgpOD5DBSU7Kgi+CsW1UkcFYJNojSUV h6+Uv9usPM0hSyhwR6uA7FDvi1Q+GVYYEv5egCPAUGJ901thqpDtz+ounpiHoSYHdoS7 6kzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date; bh=a/VZ7J2vXNLalq6/UaYMXPAfdVnt5kUqJt79vrYl+/w=; b=EUiPqDEguzQlp0JqfsltEtog7AXgSBf9GMN1JDw54QBfMqj7+eA3OJujotEuVWlRE5 62QV/PnSY88y1NStkprepFLaz7WTGTM+nl5OTUjT5trMNAm6A3346d1TwrJFYQM6GYoK QkbLAkjIwqFeirUYcnxq9eP6J7qYJ4+KnZsHS0G7JPyiUukTfbQJSV/iuZmXIKwmTLvc QkeNCvR0nmnoPjcAezvcvgNzfx6vkURVYh3vm6F6GnKm2f1oALx1gOd66OKqUmFC4i1L Me3h/5og5gL59kkmluLl6Sx5xSAasRqS47oWNJ2himKN9yDRgm5zKPhweBmAWj32fOKW up9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k17-20020a508ad1000000b0046a2d069892si2538792edk.158.2022.11.25.01.48.36; Fri, 25 Nov 2022 01:49:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229926AbiKYJsR (ORCPT + 99 others); Fri, 25 Nov 2022 04:48:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbiKYJrK (ORCPT ); Fri, 25 Nov 2022 04:47:10 -0500 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B27F3D92A for ; Fri, 25 Nov 2022 01:46:04 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oyVHU-000hyT-CY; Fri, 25 Nov 2022 17:46:01 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 25 Nov 2022 17:46:00 +0800 Date: Fri, 25 Nov 2022 17:46:00 +0800 From: Herbert Xu To: Eric Biggers Cc: linux-crypto@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, samitolvanen@google.com Subject: Re: [PATCH v2 00/12] crypto: CFI fixes Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221118194421.160414-1-ebiggers@kernel.org> X-Newsgroups: apana.lists.os.linux.cryptoapi X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Eric Biggers wrote: > This series fixes some crashes when CONFIG_CFI_CLANG (Control Flow > Integrity) is enabled, with the new CFI implementation that was merged > in 6.1 and is supported on x86. Some of them were unconditional > crashes, while others depended on whether the compiler optimized out the > indirect calls or not. This series also simplifies some code that was > intended to work around limitations of the old CFI implementation and is > unnecessary for the new CFI implementation. > > Changed in v2: > - Added patch "crypto: x86/sm4 - fix crash with CFI enabled" > - Restored accidentally-deleted include of > - Tweaked some commit messages and added Reviewed-by and Acked-by tags > > Eric Biggers (12): > crypto: x86/aegis128 - fix possible crash with CFI enabled > crypto: x86/aria - fix crash with CFI enabled > crypto: x86/nhpoly1305 - eliminate unnecessary CFI wrappers > crypto: x86/sha1 - fix possible crash with CFI enabled > crypto: x86/sha256 - fix possible crash with CFI enabled > crypto: x86/sha512 - fix possible crash with CFI enabled > crypto: x86/sm3 - fix possible crash with CFI enabled > crypto: x86/sm4 - fix crash with CFI enabled > crypto: arm64/nhpoly1305 - eliminate unnecessary CFI wrapper > crypto: arm64/sm3 - fix possible crash with CFI enabled > crypto: arm/nhpoly1305 - eliminate unnecessary CFI wrapper > Revert "crypto: shash - avoid comparing pointers to exported functions > under CFI" > > arch/arm/crypto/nh-neon-core.S | 2 +- > arch/arm/crypto/nhpoly1305-neon-glue.c | 11 ++--------- > arch/arm64/crypto/nh-neon-core.S | 5 +++-- > arch/arm64/crypto/nhpoly1305-neon-glue.c | 11 ++--------- > arch/arm64/crypto/sm3-neon-core.S | 3 ++- > arch/x86/crypto/aegis128-aesni-asm.S | 9 +++++---- > arch/x86/crypto/aria-aesni-avx-asm_64.S | 13 +++++++------ > arch/x86/crypto/nh-avx2-x86_64.S | 5 +++-- > arch/x86/crypto/nh-sse2-x86_64.S | 5 +++-- > arch/x86/crypto/nhpoly1305-avx2-glue.c | 11 ++--------- > arch/x86/crypto/nhpoly1305-sse2-glue.c | 11 ++--------- > arch/x86/crypto/sha1_ni_asm.S | 3 ++- > arch/x86/crypto/sha1_ssse3_asm.S | 3 ++- > arch/x86/crypto/sha256-avx-asm.S | 3 ++- > arch/x86/crypto/sha256-avx2-asm.S | 3 ++- > arch/x86/crypto/sha256-ssse3-asm.S | 3 ++- > arch/x86/crypto/sha256_ni_asm.S | 3 ++- > arch/x86/crypto/sha512-avx-asm.S | 3 ++- > arch/x86/crypto/sha512-avx2-asm.S | 3 ++- > arch/x86/crypto/sha512-ssse3-asm.S | 3 ++- > arch/x86/crypto/sm3-avx-asm_64.S | 3 ++- > arch/x86/crypto/sm4-aesni-avx-asm_64.S | 7 ++++--- > arch/x86/crypto/sm4-aesni-avx2-asm_64.S | 7 ++++--- > crypto/shash.c | 18 +++--------------- > include/crypto/internal/hash.h | 8 +++++++- > 25 files changed, 70 insertions(+), 86 deletions(-) > > > base-commit: 75df46b598b5b46b0857ee7d2410deaf215e23d1 All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt