Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Nov 2022 10:04:28 +0000
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     <linux-crypto@vger.kernel.org>, <qat-linux@intel.com>,
        Vlad Dronov <vdronov@redhat.com>
Subject: Re: [PATCH v2 11/11] crypto: qat - add resubmit logic for
 decompression
Message-ID: <Y4CTLD7BdfFt5T5X@gcabiddu-mobl1.ger.corp.intel.com>
References: <20221123121032.71991-1-giovanni.cabiddu@intel.com>
 <20221123121032.71991-12-giovanni.cabiddu@intel.com>
 <Y4BKgx2axzqsjWch@gondor.apana.org.au>
 <Y4CO3O21Kx/Ywi6S@gcabiddu-mobl1.ger.corp.intel.com>
 <Y4CRBasSFNhXywKj@gondor.apana.org.au>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y4CRBasSFNhXywKj@gondor.apana.org.au>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ADDT00TysDK5AGAmEIGbEOt8ZlF3uoyOP0JxgPbZWvUGLRufm5M091IChNLA?=
 =?us-ascii?Q?7u4mtTb+QqhdwNIhJSr34OBUwpdx+PDsG0o160OSCsI4SLHtUQ6DHCfB3Jse?=
 =?us-ascii?Q?EboL3C5RNnWRCRLUMvU2xm5LMwhTOem867OQYmFehKUO4ssDY/jM45GBtNww?=
 =?us-ascii?Q?rYMbqohcO7yugegABOkGZ5fbtFl9UNfOW6J9zvGuHKgAb2c1FcB/0+j15IC9?=
 =?us-ascii?Q?wiAVKSpQ4JWD/0szL2vFXJSL1zbfGMKuYb/7xuES3oC3jRn5utHWWmd0cShm?=
 =?us-ascii?Q?NFdI8giL45kBb2++wCrB7WMF6/XlthM/2MYHlWW7RU2rzkoCdsJGItAcWtoJ?=
 =?us-ascii?Q?wB/jRbgjc6bM2GVSUwSQadOVqyboJAwb4vgNF+++cQ0xIFrPA4+6yn68Ozw8?=
 =?us-ascii?Q?7fFQPO1Dz35Q4oExAMiRDtJoDMsvp3O8HpqEZ27ds9ZT4vOPcqeadfL06aur?=
 =?us-ascii?Q?27mgee28SRRTgdHxoVsmB4wKwhVy9MkZcY/LcbKiPpDFIZ+ktcJo04Ts0PFM?=
 =?us-ascii?Q?0g2+oH7HvwAmgpAxdl4FOvrHb68kVvv71LIaaDbWrnepaB59JjEHCGNErRrK?=
 =?us-ascii?Q?QARWP++Jt/Z/QuNN+sI0WyDIMwLvqXB3ZW9IPNYUl48k+mPW6tyMPSMMTk/Q?=
 =?us-ascii?Q?nXErRnZyNBTB7CT2izpuJRm0cnmENqJD+SqFw//f93aOU7oy9b7cfHDMHfpB?=
 =?us-ascii?Q?PXvlppu39MQtlLsbUQ5fGYu7mIu13FIwpPs7Zf+a+t/91kzNdk8TsHMO7MVp?=
 =?us-ascii?Q?rvju3HsAr/zJMxaKwrVwPen1r+CPB5liVh0nrsaOJr89O4lCnIGaDJ7sMS35?=
 =?us-ascii?Q?/7BupYkXyzXUfzOWJkw/B1LQkWePqLU8ky0bPSzL9T91U4GbYIr9jGCiQsrX?=
 =?us-ascii?Q?n5Znat7r2m/oigXWUS5jcs67Mj/dGi3SeSJGpsHI0xdtIUFrN0aiXYN3udeF?=
 =?us-ascii?Q?PFl0jgdoN0vcKgdY1K3OKGhW9A6FIzbB+pLl1rhGFY1XDClsX1IJ0n6sRhso?=
 =?us-ascii?Q?Hze07Ewjfcs0kYBjdMC88x9UyRDRFw2b4JKG6gAX7diIB93xYvfoT8N5yUHj?=
 =?us-ascii?Q?GeZ0yuhkTE/AADHpby68xigOxIvU5VNBzroUpWX6/GfsvSNDFlSyA5JA2FT+?=
 =?us-ascii?Q?pwWnVMKqAr01MJOegznaytcY77GD483x3+/lCCEyRIjpkVAsHGIaQhGqvSd8?=
 =?us-ascii?Q?vpdkJB5P6h/DOgWLhIWP2tyEvFFAZBnosfUCIXijTHzrhSN2U61WgjDjHiHf?=
 =?us-ascii?Q?tabvuwIJyKbYDi/RODobpi/iN1nfNadTr4tfomYblBuGPWE04XYEa1EKa3Bm?=
 =?us-ascii?Q?yJ3tecq+qbxC0U9E4mV3P+50L0ECijlVxBaBABp43tNg+KEuFUwrTECQIAKe?=
 =?us-ascii?Q?XevTRnqIl3jlFAOmR6hjyMT47JOsX2RO/iYpo+WYT+nd6FlXeZCZmZyTpGgr?=
 =?us-ascii?Q?V6xPppF4rgX/A90OPR0EoPjewSLzcKjPdkHAYNzEirohERL4NAxpZEwTBdBX?=
 =?us-ascii?Q?DWYntfci35WDrG0y/9a6CrGtPCuQA9cnK0eD7ARlFB5KnqYZV++6zjr/OYLw?=
 =?us-ascii?Q?Yr7lUAlt+7dFiQT+sDGe5YIQCx/zkkwzvbACyQqluxWPqP9p6dnFC3X8u0/E?=
 =?us-ascii?Q?lg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 62d5bb30-dd39-40a5-1c10-08dacecc73f8
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 10:04:35.4571
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1fSIY7amLLATSpiH2lodrcYduU8cegMwWiXm+GcgAXHS/HATrYv8e+A4Kb/vnWEL9UTfXE8Li2e23N5N0S+ut+CAmhwV3Il6/yZXAAtoRbQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5563
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Fri, Nov 25, 2022 at 05:55:17PM +0800, Herbert Xu wrote:
> On Fri, Nov 25, 2022 at 09:46:04AM +0000, Giovanni Cabiddu wrote:
> >
> > I wanted a cap on the number of retries. What if the input is a zip
> > bomb [1]?
> 
> OK, but in that case we should just have a flat limit.  In which
> case it also makes no sense to double when retrying (as the limit
> is so small), if the first decompression fails, we should go straight
> to the limit.
Just double checking if I understood correctly.
At the first iteration, i.e. first call to decompress, allocate a
destination buffer of 2 * src_len rounded up to 4K. If this job fails
allocate a destination buffer of 128K and retry. If this fails, terminate.

Thanks,

-- 
Giovanni