Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp10216434rwb; Fri, 25 Nov 2022 02:20:24 -0800 (PST) X-Google-Smtp-Source: AA0mqf5ajEVbOntMjM5R14cn2JV3OZpf4Wz2F8IGye7P5VtILML370r1/NhsSobgy49/eDdudA0m X-Received: by 2002:a65:644b:0:b0:477:6a44:ae9b with SMTP id s11-20020a65644b000000b004776a44ae9bmr18676220pgv.591.1669371624261; Fri, 25 Nov 2022 02:20:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669371624; cv=none; d=google.com; s=arc-20160816; b=nrq+heYy93RxwM8I3qIx/fFfe5KQQkzt9HwLD4zGD+yuu6FKWddzsuy6ZPeZsL+dRw oqDxuaBgtCSXsjfzcE8uEnNGucp1pd/P82idf2tdWrR9+DK9ryK43kA6KkZgQ5cUuu1I 42G+4+icLURpc+3SNrQECnCwEW+v1rR4t21deH2D2E1Zgg5wWqLSCFcKSM+KZdCR8Bh/ TCjdJNhZ9Xv+B5yR7XcSqCefz9KLfVMsq7Q8BqhYcZCNEN5oi25ST9nws3/VzTelbj5t 56qpXhFR7VF6AxtsIYIO41zT2fSA3fKNl47X9mj0FbwwPuQULOah4DypHkrlU8LBFUpz +d7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=z4Jy1PyWAljNgPbjCAupw5NYx5Xa1ASHhu462fvh4RE=; b=R/IO7MvQUq0wucoxAibupUm38JZ9eRfJ03WA2q4sc8p9Q4yLN7bEsl8g0Fr66xzK42 LM++iC07x28giUj7JjhtHCdDSeCLJWjTfAaz6yry7yGixonq8bjiUygvGbKnlHAGvvQm 1WWKBJ9cYWSjft2eNsDRzDzdFKQ/fqmihEIS0LrgFpSPXhBw9gkZ1OxnVJLuCcPixp8R lf+bWGi8FAg/0oMLSCrAOei15cKNsDbUEbHuwpX7xkeUtmSyR2CLLO7siqZg8/2j9tjn xxfBYkyRgvY5fEs78yfwsz/r9NhEFHgDGCm1568EYuylpY2+E/hh2o8ZQSz3Al8fXlze deZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pm5-20020a17090b3c4500b0021872a7d873si2645280pjb.57.2022.11.25.02.20.10; Fri, 25 Nov 2022 02:20:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229825AbiKYKH5 (ORCPT + 99 others); Fri, 25 Nov 2022 05:07:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbiKYKH4 (ORCPT ); Fri, 25 Nov 2022 05:07:56 -0500 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0181312AC9 for ; Fri, 25 Nov 2022 02:07:51 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1oyVcR-000ii5-6t; Fri, 25 Nov 2022 18:07:40 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 25 Nov 2022 18:07:39 +0800 Date: Fri, 25 Nov 2022 18:07:39 +0800 From: Herbert Xu To: Giovanni Cabiddu Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com, Vlad Dronov Subject: Re: [PATCH v2 11/11] crypto: qat - add resubmit logic for decompression Message-ID: References: <20221123121032.71991-1-giovanni.cabiddu@intel.com> <20221123121032.71991-12-giovanni.cabiddu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Nov 25, 2022 at 10:04:28AM +0000, Giovanni Cabiddu wrote: > > Just double checking if I understood correctly. > At the first iteration, i.e. first call to decompress, allocate a > destination buffer of 2 * src_len rounded up to 4K. If this job fails > allocate a destination buffer of 128K and retry. If this fails, terminate. Right, that's what I was suggesting. Oh and please add the limit to include/crypto/acompress.h so that it's part of the API. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt