Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Nov 2022 10:14:37 +0000
From:   Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     <linux-crypto@vger.kernel.org>, <qat-linux@intel.com>,
        Vlad Dronov <vdronov@redhat.com>
Subject: Re: [PATCH v2 11/11] crypto: qat - add resubmit logic for
 decompression
Message-ID: <Y4CVjUAvXx9AIBBa@gcabiddu-mobl1.ger.corp.intel.com>
References: <20221123121032.71991-1-giovanni.cabiddu@intel.com>
 <20221123121032.71991-12-giovanni.cabiddu@intel.com>
 <Y4BKgx2axzqsjWch@gondor.apana.org.au>
 <Y4CO3O21Kx/Ywi6S@gcabiddu-mobl1.ger.corp.intel.com>
 <Y4CRBasSFNhXywKj@gondor.apana.org.au>
 <Y4CTLD7BdfFt5T5X@gcabiddu-mobl1.ger.corp.intel.com>
 <Y4CT61fknX5aNvpa@gondor.apana.org.au>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y4CT61fknX5aNvpa@gondor.apana.org.au>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xSGZuh/mp+Ico8QGutPNJ/dwOQDjzUSSFyRX+9/9736PU+tPyt6o6WtOh8FC?=
 =?us-ascii?Q?7Du9eQ4mViunAdcQzetSJtTUBLtpYWLqMQLjqZmVmOOIOsgLWEnHanLEV8EI?=
 =?us-ascii?Q?wUC+kST969MzG2IzU9nbMw94Nz5PU49oXOj3L6zL/9DcrfNnrQYbt9WdeHwo?=
 =?us-ascii?Q?evdJztv0rM/d/RU/NqPjsmYrI3hlZoZ458N5DLimor4SIBAH0uO6xmdGqs4X?=
 =?us-ascii?Q?iGq9TaOKjVjWm3lNnNUh/DDsN8ufPPvWK4ejJnynPqWoWpR1xyL12RuU69S/?=
 =?us-ascii?Q?7Z8oAokfjHklwHpCX0pyBqSB4sSNfKeoAFQFNyB9ge3FDB3hLAB8NOVOJCaD?=
 =?us-ascii?Q?xtS+GTklz8FIbZ9CMqheowZBVpjDLlOWyc+qvf9sVt9ElBYP256Nd6xIkrTJ?=
 =?us-ascii?Q?I1POfFUlJf+//DmyR6hc9+JLzxGHqqHSGmi31dqnuqTEJqXLC2VLQHpHyfA0?=
 =?us-ascii?Q?ax9z354zikDvpyAUoffia8VlmwnU4QyoYBdp/fK4oIneILCKefSIgR3b+JOS?=
 =?us-ascii?Q?uyGcD/BPH42LvtQ+S4zhEjrjzd8u2YwfNV7/PjaaGtJoZfPSN6yqA/6ZYWDm?=
 =?us-ascii?Q?EGB5ky3HT7lQ+cTI2ZVmE5BQnnrEchxl0up4LsWL7jx4+iQk+GySsoAVUrKo?=
 =?us-ascii?Q?o8DH6/AquWnHM88xzHVuiOrRAyeXYt6z1QLv9q/MVOB8NsYV4D/5VRC7br3u?=
 =?us-ascii?Q?Skny0OymF8XPKdjBagJdMs72k0F6QZ3jmIxsNr87XNDdf8Eg5R+UZYH9xZ1/?=
 =?us-ascii?Q?K9bPzl8iavQ15HSEqtoiHgxnIvNzbszEJpjJrl3TFSRgOcW7dH6dyvPe+V6x?=
 =?us-ascii?Q?PfRcwEjrJQ/th+JKv9MTJuNK7kXvaRUQGsoAB/RP94R1iJyuOB7PfVzNzcuz?=
 =?us-ascii?Q?nDE1dGn2GbHmdCldpbaQKJuSgH93QGEoISDSeTAPdz2T1nT1ohHDPB2P2zsf?=
 =?us-ascii?Q?YdfumvO6cnVLb9N6mILNtnP1rhM3zaYhRIavsJlGrt3I2NM3KVY4dyraCJFh?=
 =?us-ascii?Q?Ap7PnIcLIYc7b2/x+X2oNpJg/skwrOpZmLsTaSlu4q3uBW9ME7x7D9dJw3Jv?=
 =?us-ascii?Q?PKNJYRj9x9z/sxQf9Mvv3WzFKl9DPPKbidCcVFTg3IwAJmibR7Fhh0HgLW+/?=
 =?us-ascii?Q?xWw4kE3XPthvgyp/PE06hHeav4WEY2twFkXOP8njXjz1uynxLOzwAPLUtcII?=
 =?us-ascii?Q?Sni/1/bZR8i/+vxRCVdMfijMPD19sAdzWtiEVdRQgzb0PQpRLKff46vGcW6q?=
 =?us-ascii?Q?FJwDxmfGEnO+I+D8XRUmQqvbN45yjxP0Tsya7MhYEbf02jRvMUivCgqZH3rP?=
 =?us-ascii?Q?xI7rxbrQ8jLbmBtwTe9VV0ncMno1XHSFX86zJY9ug8xazyyTWLguMWelU95p?=
 =?us-ascii?Q?TLOuY+6d17DapUTdTjEdpzewsetxkdYcORnK17Z0wZngu/PPWUqMoo7qdqio?=
 =?us-ascii?Q?iemwO75gJNdidXNKY/3c6jK1VSkwom5nX5aIIhXzT8LvciiibJmbah6G9Lku?=
 =?us-ascii?Q?V5ZsADnBuGnwnqNpgR24FkT1WbF+LFVV3ccWo1pP+hUX2DGYu5tiwGalZo2R?=
 =?us-ascii?Q?x+r6IXCO/KcevX/WYbS55/+32TzaVu22AtaDH4Iz3X3KeY8urs0CNiqih8nw?=
 =?us-ascii?Q?/A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d126dcab-0a53-4f8a-8770-08dacecdde8e
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 10:14:42.4784
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H9qVsSolajL2DzN8QIGn3nscw+UgqSl/LDXgxyvpIP87izYdeDl+9+qlqH6dTJIGeS2xnK03vO6XGMO6yHrx5CgEand/yWVzp1Jh4na+ttk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4823
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Fri, Nov 25, 2022 at 06:07:39PM +0800, Herbert Xu wrote:
> On Fri, Nov 25, 2022 at 10:04:28AM +0000, Giovanni Cabiddu wrote:
> >
> > Just double checking if I understood correctly.
> > At the first iteration, i.e. first call to decompress, allocate a
> > destination buffer of 2 * src_len rounded up to 4K. If this job fails
> > allocate a destination buffer of 128K and retry. If this fails, terminate.
> 
> Right, that's what I was suggesting.
> 
> Oh and please add the limit to include/crypto/acompress.h so that
> it's part of the API.
Yes, that is what I was going to do. Is the name of the define ok with
you?

diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h
index cb3d6b1c655d..bc16e0208169 100644
--- a/include/crypto/acompress.h
+++ b/include/crypto/acompress.h
@@ -11,6 +11,7 @@
 #include <linux/crypto.h>

 #define CRYPTO_ACOMP_ALLOC_OUTPUT      0x00000001
+#define CRYPTO_ACOMP_NULL_DST_LIMIT    131072

 /**
   * struct acomp_req - asynchronous (de)compression request


Thanks,

-- 
Giovanni