Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 27 Nov 2022 18:14:50 +0200
From:   Ido Schimmel <idosch@nvidia.com>
To:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc:     Jiri Pirko <jiri@nvidia.com>, netdev@vger.kernel.org,
        Jakub Kicinski <kuba@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        Boris Brezillon <bbrezillon@kernel.org>,
        Arnaud Ebalard <arno@natisbad.org>,
        Srujana Challa <schalla@marvell.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Michael Chan <michael.chan@broadcom.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Dimitris Michailidis <dmichail@fungible.com>,
        Yisen Zhuang <yisen.zhuang@huawei.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Geetha sowjanya <gakula@marvell.com>,
        Jerin Jacob <jerinj@marvell.com>,
        hariprasad <hkelam@marvell.com>,
        Subbaraya Sundeep <sbhatta@marvell.com>,
        Taras Chornyi <tchornyi@marvell.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        Petr Machata <petrm@nvidia.com>,
        Simon Horman <simon.horman@corigine.com>,
        Shannon Nelson <snelson@pensando.io>, drivers@pensando.io,
        Ariel Elior <aelior@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        Vadim Fedorenko <vadfed@fb.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Vadim Pasternak <vadimp@mellanox.com>,
        Shalom Toledo <shalomt@mellanox.com>,
        linux-crypto@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
        linux-rdma@vger.kernel.org, oss-drivers@corigine.com,
        Jiri Pirko <jiri@mellanox.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Hao Chen <chenhao288@hisilicon.com>,
        Guangbin Huang <huangguangbin2@huawei.com>,
        Minghao Chi <chi.minghao@zte.com.cn>,
        Shijith Thotton <sthotton@marvell.com>,
        Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next v3 1/5] mlxsw: minimal: fix
 mlxsw_m_module_get_drvinfo() to correctly report driver name
Message-ID: <Y4OM+q5yqCE4/aGs@shredder>
References: <20221122154934.13937-1-mailhol.vincent@wanadoo.fr>
 <20221127130919.638324-1-mailhol.vincent@wanadoo.fr>
 <20221127130919.638324-2-mailhol.vincent@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221127130919.638324-2-mailhol.vincent@wanadoo.fr>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Gk1TiVgGIyTPh0Or+nBkvBDkW2eJRSuIfK0BnRgEptz0vMU+ZE3GtpcRTvhF?=
 =?us-ascii?Q?oNBxHODpUHW53ysP/XOMvF8pJu87jPV6SW7VLdIkB9s7B9iBvR9NZ+O8EQFs?=
 =?us-ascii?Q?u509BM0NbIuC7KFq5fawMNG4QomF0S1vCMHUwJO1oR+qlTv2lij41vULCYoF?=
 =?us-ascii?Q?9G3ZGZ3ejvt9ZfgMDgoeS0lfhsEnJBRObX+/qe7D7hFKnl8GvEb3um8sxsAI?=
 =?us-ascii?Q?FBOOgP8untzNBi03Gplznpvbc6whEpOSliudJaqn2195ol1EexB62khZOcoX?=
 =?us-ascii?Q?KzV6NXTNpcYhy2+OID5BhAAYksUxaoc5FdZDTxvEgLOlfELVhQTI8euFzGi2?=
 =?us-ascii?Q?R3/EIkO8s+N0JLZK1pHEVIt8n/MEzTtBe1RQjJGD70Y/kMlYGaSlZgDBqXz8?=
 =?us-ascii?Q?M6szP34GU3Tgm0td7VZ4G4kdSfdMmnqrZlAtjf7uQhG2tDPHGQHhKoqnQQ1e?=
 =?us-ascii?Q?cTueStHMjYW8b+m+NHIdEN4H2B1DtyjgErOWTzdmxoET1DUbSe6zE340ZJmt?=
 =?us-ascii?Q?L3Ul303AiNN48ACSNDaFvUsuYP0eXdr7b4y96LEo/QxBxdbOicb3zAVsa9WJ?=
 =?us-ascii?Q?J3euw6e327PXK0qg4KZYlPB69FSld9KSGxnyoUitceD4ZDCUx/pDJ2EHJYhp?=
 =?us-ascii?Q?uAjr7/qZBM3C65Ov/6/gdlpOnKieB4zYnnTKqx4d6FLvrE5H2NRmhvcv1EtC?=
 =?us-ascii?Q?3MZMjftLc7u3QmKTNcnrG6EuYVLCMcXHvQznDTNMALcJrQyhDNo3Uhg94k9F?=
 =?us-ascii?Q?P2EDvWuay5JEQSUtZJYe8VLfcNv3IjB6qQ0wkVpPpAcLvP+2ppoJjzkpJW9r?=
 =?us-ascii?Q?1krDh/Cjcqx5x6ni0gljS82AwjPEvAJqh9zlSasUVTog4tj+30a96OjVX9A4?=
 =?us-ascii?Q?1+VOZ3iHBXUczGcMXAtDVKWb+txF0QrvP4/TQdE5BFLspU3uMe5jZRbznVun?=
 =?us-ascii?Q?qOjCRTP5Gv3pOWO/ilRpTI+Ph+fA+0DTMv6Rx5CXf8O5ZhUi4Q/YCACjI5+e?=
 =?us-ascii?Q?Rezw/1CuYiPsWvoKw6N4Q036ZLLprGOY3mb4S5HxI9yp3E2yDtpKMh2aILbi?=
 =?us-ascii?Q?TqvpnwXXnp5vHFWlweSQNCGtmk3il2urI6n7Wj9ZFhoGFj6v7GFH79h0xnfJ?=
 =?us-ascii?Q?Vqo4dPz4yJYdqrSEeHD1vW3e1AVn/1FszuZYuzrxELVo7BIzyrum+lpjO8Kq?=
 =?us-ascii?Q?qXi3nhxl62BWrYIELKY0jnQRAd4XShEDN6t46ad7fkpLBCG7ZSekXyLGM5wi?=
 =?us-ascii?Q?bqytTbAIrxuPFvtsZujPkTKUs7TStNfnozmSH5u5r1HSTD01+TVoyK5xMdbx?=
 =?us-ascii?Q?DchjMvImoJYpGW+63AHpHbfSfLbqcnU/Lam9qKXEKZgY/5ITzBAaG4yYU1YK?=
 =?us-ascii?Q?zty1qrnR+hfpahwAfUFE9GtsBnlO3xkAg8hwKz93WYHMuJy2ZMNmoTbJPkVV?=
 =?us-ascii?Q?+piITgHQpe2yAhB5wOZj0g+59x7kZBXJk6lVJlKXz3J/PU8cZBg2DfozfqZc?=
 =?us-ascii?Q?6SEeck+S/BePz+q2odpxftxT8KUeZTvkctN7r1xUuK8+7tgkDdlHsziMpBD1?=
 =?us-ascii?Q?Fbo8PXsFaGp00mVBCbPrlvj+o0lD2I96vohZMP/0?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1cf44b4-4c4b-4d59-4b97-08dad0928629
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2022 16:14:57.6146
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aZkPKq7blycgB3wI9zPk2fzNJhlJb4OamcpPd2liP4pBmICq66NKXrYhlIRwEmfNcZV+Jz8lW0peIvGK5iiIag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4887
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Sun, Nov 27, 2022 at 10:09:15PM +0900, Vincent Mailhol wrote:
> Currently, mlxsw_m_module_get_drvinfo() reports the device_kind. The
> device_kind is not necessarily the same as the device_name. For
> example, the mlxsw_i2c implementation sets up the device_kind as
> ic2_client::name in [1] which indicates the type of the device
> (e.g. chip name), not the actual driver name.
> 
> Fix it so that it correctly reports the driver name.
> 
> [1] mlxsw_i2c_probe() from drivers/net/ethernet/mellanox/mlxsw/i2c.c
> Link: https://elixir.bootlin.com/linux/v6.1-rc1/source/drivers/net/ethernet/mellanox/mlxsw/i2c.c#L714

Before the series:

# ethtool -i eth2 | grep driver
driver: mlxsw_minimal

After the series:

# ethtool -i eth2 | grep driver
driver: mlxsw_minimal

See:
https://elixir.bootlin.com/linux/v6.1-rc1/source/drivers/net/ethernet/mellanox/mlxsw/minimal.c#L721

The current code is consistent with the PCI driver:
https://elixir.bootlin.com/linux/v6.1-rc1/source/drivers/net/ethernet/mellanox/mlxsw/spectrum_ethtool.c#L17

Which also correctly reports the driver name.

So I prefer to keep the code as-is.

Thanks

> 
> Fixes: 9bbd7efbc055 ("mlxsw: i2c: Extend initialization with querying firmware info")
> CC: Shalom Toledo <shalomt@mellanox.com>
> CC: Ido Schimmel <idosch@mellanox.com>
> CC: Vadim Pasternak <vadimp@mellanox.com>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> ---
>  drivers/net/ethernet/mellanox/mlxsw/minimal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/minimal.c b/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> index 6b56eadd736e..9b37ddbe0cba 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> @@ -92,7 +92,7 @@ static void mlxsw_m_module_get_drvinfo(struct net_device *dev,
>  	struct mlxsw_m_port *mlxsw_m_port = netdev_priv(dev);
>  	struct mlxsw_m *mlxsw_m = mlxsw_m_port->mlxsw_m;
>  
> -	strscpy(drvinfo->driver, mlxsw_m->bus_info->device_kind,
> +	strscpy(drvinfo->driver, dev_driver_string(dev->dev.parent),
>  		sizeof(drvinfo->driver));
>  	snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
>  		 "%d.%d.%d",
> -- 
> 2.37.4
>