Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 27 Nov 2022 18:17:04 +0200
From:   Ido Schimmel <idosch@nvidia.com>
To:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc:     Jiri Pirko <jiri@nvidia.com>, netdev@vger.kernel.org,
        Jakub Kicinski <kuba@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        Boris Brezillon <bbrezillon@kernel.org>,
        Arnaud Ebalard <arno@natisbad.org>,
        Srujana Challa <schalla@marvell.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Michael Chan <michael.chan@broadcom.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Dimitris Michailidis <dmichail@fungible.com>,
        Yisen Zhuang <yisen.zhuang@huawei.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Geetha sowjanya <gakula@marvell.com>,
        Jerin Jacob <jerinj@marvell.com>,
        hariprasad <hkelam@marvell.com>,
        Subbaraya Sundeep <sbhatta@marvell.com>,
        Taras Chornyi <tchornyi@marvell.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        Petr Machata <petrm@nvidia.com>,
        Simon Horman <simon.horman@corigine.com>,
        Shannon Nelson <snelson@pensando.io>, drivers@pensando.io,
        Ariel Elior <aelior@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        Vadim Fedorenko <vadfed@fb.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Vadim Pasternak <vadimp@mellanox.com>,
        Shalom Toledo <shalomt@mellanox.com>,
        linux-crypto@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
        linux-rdma@vger.kernel.org, oss-drivers@corigine.com,
        Jiri Pirko <jiri@mellanox.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Hao Chen <chenhao288@hisilicon.com>,
        Guangbin Huang <huangguangbin2@huawei.com>,
        Minghao Chi <chi.minghao@zte.com.cn>,
        Shijith Thotton <sthotton@marvell.com>,
        Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next v3 2/5] mlxsw: core: fix
 mlxsw_devlink_info_get() to correctly report driver name
Message-ID: <Y4ONgD4dAj8yU2/+@shredder>
References: <20221122154934.13937-1-mailhol.vincent@wanadoo.fr>
 <20221127130919.638324-1-mailhol.vincent@wanadoo.fr>
 <20221127130919.638324-3-mailhol.vincent@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221127130919.638324-3-mailhol.vincent@wanadoo.fr>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vqR66Kr10oDz6Pi5Roizh7dW0QGb+Jd0tYnzrllsWL946TBPNwG+Pw88AWRn?=
 =?us-ascii?Q?oDOMesSd8mi/M3j+5PrZKKTK17khXdMfolw0ojHU3BfWfVMhgJ9QqrMPHeqT?=
 =?us-ascii?Q?kmfWxFq6nmrAumkwfPw2K59Lzn+GsEIGGQK1QbRgziygVGqfZzkGW0EFDy76?=
 =?us-ascii?Q?2xAHqetaj0GlIoLdAVg8qo6X8wX7mu7XaykITRhmIFipdZmb1aAhe2FVzLA2?=
 =?us-ascii?Q?UeoaVnwfmsHghJnl6ABguKujbUYv0KzynJ81IG0a5exx1X//jkDwcyz6C1W5?=
 =?us-ascii?Q?ZBhVmdaZV4egckqnSBtzJZRijIkEGLFrLkkeCHASlqQkDPe/88J/8/NMA7zS?=
 =?us-ascii?Q?hiSyIOIKG1bB4Jec2oZ2Xm8SsIZoPaYvLQsrqNydcvTlYFn+UF7mLt8K136y?=
 =?us-ascii?Q?4ng1xqN7pbJyyjwMPRZBkv+o4RraZaKdKq85uFkdC2ML+trBPKuC09RwDaq0?=
 =?us-ascii?Q?cam0WZHyF9kdgdw1b27nzqXzGTK64H5SdxR8h0YbDjl3J+2J+Ew6KHE7WIt1?=
 =?us-ascii?Q?er0LmonfHK7tP4qio6SGLp5YQeLUAy7O5G6xooqYddVi9gyKfCGeWy539hYQ?=
 =?us-ascii?Q?GLp+XgE8lhzXZl1HVdJ6og4JAdvGrII0EQ4c54jpLjdcBBX3X3prwj/O59x+?=
 =?us-ascii?Q?JO+MSVO8EbjSJ1hLjQeaeH0vcncJ5AcrjRZGiuPDEdjga0IWhw19nX/dBxIK?=
 =?us-ascii?Q?TER97hG4ZL++DmnSsGH8R6OG1NdpTWIv57uP/JtbASHz77Qi1yGjfbiZZ6IS?=
 =?us-ascii?Q?HG9RFTDbNReCBZpq9++dJI7XGINJzKFF+RevNhqhOnr4Hgwnd30f6nLhFg3e?=
 =?us-ascii?Q?ury/CXqew2q2DuLTTQOIYaub7a54+KXWMoalM0JC/H+3GobwPdBJ11Dxx2ga?=
 =?us-ascii?Q?MeKS5hGG2kUjPCU1Ak9DASVmqCEn7aIWpt0BUtosXa/OPSV4vUiP9pbOxNYZ?=
 =?us-ascii?Q?my+RJPnZgff8jBB+iVQ/cjDrNrBIHj/CIWDvJjydY/fNmjCIv3MWcAZruuM0?=
 =?us-ascii?Q?2b0mJ9DOpYtM9TIJywwIzEXZTulFPVJqCiWH0jSdEiRT7FULoCST3WYx7Cjq?=
 =?us-ascii?Q?pSnj7QmXZKxqMVO25fMdHasUxlaSG4je7xF/oDSV4Fzd4YPTLbKC3GQIhzF0?=
 =?us-ascii?Q?v1uG8KKTlcBEtn0C793HVNufXgJn6wIAfmf9pfz8cefWwhv4Cxtfe0Z1pfVj?=
 =?us-ascii?Q?lkq58WjzhLoxVKIbdH2SHpLMZI+lnjpXo9whRGjpDcKzR8lb9P2JmKpCWjU0?=
 =?us-ascii?Q?1WKeSkRtZrENgJPJgdkrvc4DnkzewQF1jNPFdxOQ8gIfqEkaoYtdFwymI/Bm?=
 =?us-ascii?Q?CS2H8bl1XV1SMAhZguwcy+s7jATMWFw4jcRSIJj9nCWc/cgfqPsKNgNXwKGF?=
 =?us-ascii?Q?Z2T3Tso0iD5XK6b0VWsbE38hz5KvmIteV6BIoSB8FK1Yb3bTUnkvNMRd9apt?=
 =?us-ascii?Q?7FW4XvGkzMI07TzlCJdcic4+E7R/YjiHf5g2qtUugGTxKMXonmRalkLrk6qo?=
 =?us-ascii?Q?SIFBIqZLlnLwsbESizjymIeiauRoLtMgCmZB9F9pSeVUm8B/ugmM8RXqERDE?=
 =?us-ascii?Q?GywmSrHJbSvaNwaLbvd7mDVHITVWrHv0/p8hyJwl?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0df3b66-9821-4889-3b7a-08dad092d53a
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2022 16:17:08.8918
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fWDqn+zjWp7BA9y7OOZ3dP5DsLDCcCgQKd8B89JwIPzjH9MtlLJ4sjBXX5pPe+X4f5vkY7sLIiSzSBiajWGs1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4887
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Sun, Nov 27, 2022 at 10:09:16PM +0900, Vincent Mailhol wrote:
> Currently, mlxsw_devlink_info_get() reports the device_kind. The
> device_kind is not necessarily the same as the device_name. For
> example, the mlxsw_i2c implementation sets up the device_kind as
> ic2_client::name in [1] which indicates the type of the device

s/ic2/i2c/

> (e.g. chip name).
> 
> Fix it so that it correctly reports the driver name.
> 
> [1] mlxsw_i2c_probe() from drivers/net/ethernet/mellanox/mlxsw/i2c.c
> Link: https://elixir.bootlin.com/linux/v6.1-rc1/source/drivers/net/ethernet/mellanox/mlxsw/i2c.c#L714

Same comment as before.

Before the series:

# devlink dev info i2c/2-0048 | grep driver
  driver mlxsw_minimal

After the series:

# devlink dev info i2c/2-0048 | grep driver
  driver mlxsw_minimal

> 
> Fixes: a9c8336f6544 ("mlxsw: core: Add support for devlink info command")
> CC: Shalom Toledo <shalomt@mellanox.com>
> CC: Ido Schimmel <idosch@mellanox.com>
> CC: Vadim Pasternak <vadimp@mellanox.com>
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> ---
>  drivers/net/ethernet/mellanox/mlxsw/core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
> index a83f6bc30072..d8b1bb03cdb0 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/core.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
> @@ -1453,6 +1453,7 @@ mlxsw_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req,
>  		       struct netlink_ext_ack *extack)
>  {
>  	struct mlxsw_core *mlxsw_core = devlink_priv(devlink);
> +	struct device *dev = mlxsw_core->bus_info->dev;
>  	char fw_info_psid[MLXSW_REG_MGIR_FW_INFO_PSID_SIZE];
>  	u32 hw_rev, fw_major, fw_minor, fw_sub_minor;
>  	char mgir_pl[MLXSW_REG_MGIR_LEN];
> @@ -1460,7 +1461,7 @@ mlxsw_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req,
>  	int err;
>  
>  	err = devlink_info_driver_name_put(req,
> -					   mlxsw_core->bus_info->device_kind);
> +					   dev_driver_string(dev->parent));
>  	if (err)
>  		return err;
>  
> -- 
> 2.37.4
>