Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp13879165rwb; Sun, 27 Nov 2022 13:11:14 -0800 (PST) X-Google-Smtp-Source: AA0mqf5PMr8XMSIrAB3auu+o1d+MSgeS++5BEedOSh3Whs0I/vC3tivsI7aPPe8xjkAqhMWKK1hg X-Received: by 2002:a17:907:9951:b0:7b2:7e7a:11c1 with SMTP id kl17-20020a170907995100b007b27e7a11c1mr25094870ejc.684.1669583474241; Sun, 27 Nov 2022 13:11:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669583474; cv=none; d=google.com; s=arc-20160816; b=Z4FOmodudex8cH5wNRBq2pnGLkJ2qgoJ49OH95xzIOqk8zhh1StEQ8RNnqW6ivMNUl F20ZttZHNKWFyG80LW1+GFYPQ07NZ28A8hoJGbpR2hyt/xTM9HPVadagpByM9h3m0PWy 1HgC/Z0plDV8AwgtpxRsAJigYVFgEdmPIBjXAMIVy5FjBLvk6D663lmWugTlQ7j3rj+/ 1Ir6RwOiuxd4PT+EVsllzBPefQNxmqpxEOMSSW9PqrxK0OXRyy6Nasj7kuje8hsybitY Kikynz0H8uO36JfbJSfwkEdbX1vkK5npzcomwOYxZxIVOg6rzKifgRYp7NB1ioLNdXkf 2l/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=BGhm6cpbKo9B3LXXwq8ZJuHQNeT6jZpwZxXKPXPJoUM=; b=NJj5dBFJ0FQNg2IIlU01WRpxuLfUowRoFrdngJbPVSQpARyfUJWV8LGNzAEdr9QptB OT1HhfOO3+B7T+qAzn5eQ7a5A00zyZm+9xx8x8sGdWXIVOYSI+G8OauPfBwo1URkOF2O Vughtn8k/O9C5Bzvbn9nydAzwk33JuEPPlCYheuj+r8jHDjklBDOrISarbw8iWcYN9hP V0ZvME+DmoNmsKTFLbmXq463kKbJ6GqT4p2GBf1VLIJgTtlmjiYjEnVvgGsT6yWpG1V3 X+UqyVljLMLZFgfqM0Ir7o5u3oqab6lPW1JdSSAqLpvQ7vIzIn6BNIJ5Eklb8l/p7CbD LxYA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g14-20020a056402090e00b00447d6f244c6si9033835edz.248.2022.11.27.13.10.42; Sun, 27 Nov 2022 13:11:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229637AbiK0VIt (ORCPT + 99 others); Sun, 27 Nov 2022 16:08:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbiK0VIq (ORCPT ); Sun, 27 Nov 2022 16:08:46 -0500 X-Greylist: delayed 479 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 27 Nov 2022 13:08:41 PST Received: from cavan.codon.org.uk (cavan.codon.org.uk [176.126.240.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2656B853 for ; Sun, 27 Nov 2022 13:08:41 -0800 (PST) Received: by cavan.codon.org.uk (Postfix, from userid 1000) id 00784424A4; Sun, 27 Nov 2022 21:00:40 +0000 (GMT) Date: Sun, 27 Nov 2022 21:00:40 +0000 From: Matthew Garrett To: "Jason A. Donenfeld" Cc: linux-efi@vger.kernel.org, linux-crypto@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, ardb@kernel.org Subject: Re: [PATCH v3 1/5] efi: vars: prohibit reading random seed variables Message-ID: <20221127210040.GA32253@srcf.ucam.org> References: <20221122020404.3476063-1-Jason@zx2c4.com> <20221122020404.3476063-2-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221122020404.3476063-2-Jason@zx2c4.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_05, HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Nov 22, 2022 at 03:04:00AM +0100, Jason A. Donenfeld wrote: > In anticipation of putting random seeds in EFI variables, it's important > that the random GUID namespace of variables remains hidden from > userspace. We accomplish this by not populating efivarfs with entries > from that GUID, as well as denying the creation of new ones in that > GUID. What's the concern here? Booting an older kernel would allow a malicious actor to either read the seed variable or set it to a value under their control, so we can't guarantee that the information is secret.