Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Jiri Pirko <jiri@nvidia.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "Jakub Kicinski" <kuba@kernel.org>
CC:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Boris Brezillon" <bbrezillon@kernel.org>,
        Arnaud Ebalard <arno@natisbad.org>,
        Srujana Challa <schalla@marvell.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Michael Chan <michael.chan@broadcom.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        "Dimitris Michailidis" <dmichail@fungible.com>,
        Yisen Zhuang <yisen.zhuang@huawei.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        "Linu Cherian" <lcherian@marvell.com>,
        Geetha sowjanya <gakula@marvell.com>,
        "Jerin Jacob" <jerinj@marvell.com>,
        hariprasad <hkelam@marvell.com>,
        "Subbaraya Sundeep" <sbhatta@marvell.com>,
        Taras Chornyi <tchornyi@marvell.com>,
        "Saeed Mahameed" <saeedm@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        "Ido Schimmel" <idosch@nvidia.com>,
        Petr Machata <petrm@nvidia.com>,
        Simon Horman <simon.horman@corigine.com>,
        Shannon Nelson <snelson@pensando.io>,
        "drivers@pensando.io" <drivers@pensando.io>,
        Ariel Elior <aelior@marvell.com>,
        Manish Chopra <manishc@marvell.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        Vadim Fedorenko <vadfed@fb.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Vadim Pasternak <vadimp@mellanox.com>,
        "Shalom Toledo" <shalomt@mellanox.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "oss-drivers@corigine.com" <oss-drivers@corigine.com>,
        Jiri Pirko <jiri@mellanox.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Hao Chen <chenhao288@hisilicon.com>,
        "Guangbin Huang" <huangguangbin2@huawei.com>,
        Minghao Chi <chi.minghao@zte.com.cn>,
        Shijith Thotton <sthotton@marvell.com>
Subject: RE: [PATCH net-next v5 2/4] net: devlink: remove
 devlink_info_driver_name_put()
Thread-Topic: [PATCH net-next v5 2/4] net: devlink: remove
 devlink_info_driver_name_put()
Thread-Index: AQHZA4aDtuA/HeJz8UWj3YH70WnD9q5VCi+g
Date:   Tue, 29 Nov 2022 00:23:16 +0000
Message-ID: <CO1PR11MB5089EEF30335EC3CEDA8FCB7D6129@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <20221129000550.3833570-1-mailhol.vincent@wanadoo.fr>
 <20221129000550.3833570-3-mailhol.vincent@wanadoo.fr>
In-Reply-To: <20221129000550.3833570-3-mailhol.vincent@wanadoo.fr>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sQlJVbSoTGdLU0MZhUX9/x9IXHzc4q1ToIPRADf8/eiFPkF7hBS2VZZ0vqVH?=
 =?us-ascii?Q?SCbD25H1WfV+Gc5A/yKb7wkVPLBFpd2PCzQ3UImX57Nw9PuWUYmNur9qTEV1?=
 =?us-ascii?Q?54ruSOrvl/WMEVIgyQni/7yN4Dpxalf7NJn4PtH8Au7emy0ppMJ5WBiaKKpW?=
 =?us-ascii?Q?assas1S0qKIDxSD2YqKm/SqYtXG+2q4qiVUPRzSv9blm/QXbik+lW9W8A9ZO?=
 =?us-ascii?Q?4ysh0Oz7YHl0hOP94hDNOxgNfeAa9rjOnlo/87Xo7+LIr8si7xq022i08cJ7?=
 =?us-ascii?Q?crZZEVCzChkZ9uUOb/Qw0GAsjFqbVASrBbkHhWk/NFyzxuyb3a3v7NnjUyat?=
 =?us-ascii?Q?42Tn4nDM0Q+2ei6L69R9ZzFONaw2ByIJC0HIa/3AKL62XblKrriaHAfjTZwV?=
 =?us-ascii?Q?GRdK0LC0EVPq/QBWCmc4bUZeBL82YNEpTN8OPT2nhyd+RlYlHZMpOSnIBfFN?=
 =?us-ascii?Q?sxFLW3wIrCzzI32G/1paKAq9mwlvqsTDDdJCVi/444zo5gbDKORneKd5niOI?=
 =?us-ascii?Q?8g5iHLFtHZU6TrlkAYItdKZ0qWIndif3JPiFc1AZBPSILusSCX10upB7oiP5?=
 =?us-ascii?Q?iak8rDqW9V67e2FRyhE3kQ9MkYDonOdxiNs8oJtYkJbs+IjC1uhVOicXfZDK?=
 =?us-ascii?Q?MQ7UsemCXOXdshckYoCNTp9DuR3E9E6uKDH8j0r/rSa3UQ6NvPQbqrvz1T8B?=
 =?us-ascii?Q?VK8V711aKPAbCEAc7pNm5lCnWfACa0x6Vx/y+e0Dwj0eBN1LWNvz0a1LgDBg?=
 =?us-ascii?Q?fUqJCTQlkuu17Vzm1IbeK//+topsFh2TmwNviLJ5dONQT/SUtgMdskElEj/J?=
 =?us-ascii?Q?2EKkDMNU+G02DeJ1/OXw3tXz4q/Yc26HUXmgnJzenGvnhkM5OuUOGNDFgFGQ?=
 =?us-ascii?Q?K520ajTppfbvu9DIrbkNGBfYqsidFu9nUy9zEQeIj+4gWyEYGXjZ9VI200eg?=
 =?us-ascii?Q?PF+HgsFgpbRlBUVsAlz3LAmjy1BAJDBNfeaVXzdRSzi9XQVfZUcaTzCcic9z?=
 =?us-ascii?Q?ObSPzhA0qNasEw4u8/nsF98ULBtD+sxAW5zq10QRGx7qlQtyUva1nFLAO0Kp?=
 =?us-ascii?Q?8rJZgroWjp1SVi8WSVNDlHCpekwcz8q1m+bgdn5Dz9PycuVQkcC6UE1wK43u?=
 =?us-ascii?Q?dfHXUxhNQlLx+22ZjNx9g4myhre5l9GNucrSu7ObDhLrXMkb/VjIIq6QdD4a?=
 =?us-ascii?Q?EFaPX7FtbXRZcMLNUTveixKdUlZahbnT31H/Lgrbs0H5Io+zpYTMzJYlmaaC?=
 =?us-ascii?Q?tvcdm9fRlS/9Am/WkLSKgwdYzvB5xnXtheLFeu7I2E/1WailadSFEWlXMSk8?=
 =?us-ascii?Q?WZCnWyRz5mwVpfFCi8jEQ7EbqjjV/b+GDh1qk43VEGJfyilZfpADmnR/eVI7?=
 =?us-ascii?Q?rhntXZSTK0qIVRGk0JhWTNCebAE/qSK3XLRrJyfaNU70LuWzTmYwM8gBMBcd?=
 =?us-ascii?Q?kFjiia8wGFIfRhAaLay2314pKw0p3xa1gVGK0UeNjZrCzKOkkMs2II332+pw?=
 =?us-ascii?Q?xzXB2AbFFTBAf9UCn/Bf8OF93lAVzDCMCkWH4EcMlZswUVn8R+zjWeLXRnpP?=
 =?us-ascii?Q?raMQhRMROUQdnWeGhVecGYYasCQmrelJ+LK+iaBI?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9b2067e-431e-4bfe-7417-08dad19fe921
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 00:23:16.7479
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: us+OvaXSu42W24wfvyN/eb1wH2oaMU2d3s+uee8P/liUhGbspdnwhw801rfv7vJbZ7HofMHGExlAlREfyw/KUxzZhU22m0EDgZAMYxXcZuM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6201
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


> -----Original Message-----
> From: Vincent Mailhol <vincent.mailhol@gmail.com> On Behalf Of Vincent
> Mailhol
> Sent: Monday, November 28, 2022 4:06 PM
> To: Jiri Pirko <jiri@nvidia.com>; netdev@vger.kernel.org; Jakub Kicinski
> <kuba@kernel.org>
> Cc: David S . Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Paolo Abeni <pabeni@redhat.com>; linux-
> kernel@vger.kernel.org; Boris Brezillon <bbrezillon@kernel.org>; Arnaud E=
balard
> <arno@natisbad.org>; Srujana Challa <schalla@marvell.com>; Kurt Kanzenbac=
h
> <kurt@linutronix.de>; Andrew Lunn <andrew@lunn.ch>; Florian Fainelli
> <f.fainelli@gmail.com>; Vladimir Oltean <olteanv@gmail.com>; Michael Chan
> <michael.chan@broadcom.com>; Ioana Ciornei <ioana.ciornei@nxp.com>;
> Dimitris Michailidis <dmichail@fungible.com>; Yisen Zhuang
> <yisen.zhuang@huawei.com>; Salil Mehta <salil.mehta@huawei.com>;
> Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; Sunil Goutham <sgoutham@marvell.com>; Linu
> Cherian <lcherian@marvell.com>; Geetha sowjanya <gakula@marvell.com>;
> Jerin Jacob <jerinj@marvell.com>; hariprasad <hkelam@marvell.com>;
> Subbaraya Sundeep <sbhatta@marvell.com>; Taras Chornyi
> <tchornyi@marvell.com>; Saeed Mahameed <saeedm@nvidia.com>; Leon
> Romanovsky <leon@kernel.org>; Ido Schimmel <idosch@nvidia.com>; Petr
> Machata <petrm@nvidia.com>; Simon Horman <simon.horman@corigine.com>;
> Shannon Nelson <snelson@pensando.io>; drivers@pensando.io; Ariel Elior
> <aelior@marvell.com>; Manish Chopra <manishc@marvell.com>; Jonathan
> Lemon <jonathan.lemon@gmail.com>; Vadim Fedorenko <vadfed@fb.com>;
> Richard Cochran <richardcochran@gmail.com>; Vadim Pasternak
> <vadimp@mellanox.com>; Shalom Toledo <shalomt@mellanox.com>; linux-
> crypto@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-
> rdma@vger.kernel.org; oss-drivers@corigine.com; Jiri Pirko
> <jiri@mellanox.com>; Herbert Xu <herbert@gondor.apana.org.au>; Hao Chen
> <chenhao288@hisilicon.com>; Guangbin Huang
> <huangguangbin2@huawei.com>; Minghao Chi <chi.minghao@zte.com.cn>;
> Shijith Thotton <sthotton@marvell.com>; Vincent Mailhol
> <mailhol.vincent@wanadoo.fr>
> Subject: [PATCH net-next v5 2/4] net: devlink: remove
> devlink_info_driver_name_put()
>=20
> Now that the core sets the driver name attribute, drivers are not
> supposed to call devlink_info_driver_name_put() anymore. Remove it.
>=20

You could combine this patch with the previous one so that in the event of =
a cherry-pick its not possible to have this function while the core inserts=
 the driver name automatically.

I think that also makes it very clear that there are no remaining in-tree d=
rivers still calling the function.

I don't have a strong preference if we prefer it being separated.

Thanks,
Jake