Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Jiri Pirko <jiri@nvidia.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "Jakub Kicinski" <kuba@kernel.org>
CC:     Andrew Lunn <andrew@lunn.ch>,
        Shijith Thotton <sthotton@marvell.com>,
        Simon Horman <simon.horman@corigine.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Eric Dumazet <edumazet@google.com>,
        Jerin Jacob <jerinj@marvell.com>,
        Subbaraya Sundeep <sbhatta@marvell.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        "drivers@pensando.io" <drivers@pensando.io>,
        "Linu Cherian" <lcherian@marvell.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Leon Romanovsky <leon@kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        Shalom Toledo <shalomt@mellanox.com>,
        Srujana Challa <schalla@marvell.com>,
        Minghao Chi <chi.minghao@zte.com.cn>,
        Hao Chen <chenhao288@hisilicon.com>,
        Guangbin Huang <huangguangbin2@huawei.com>,
        Shannon Nelson <snelson@pensando.io>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "Vadim Fedorenko" <vadfed@fb.com>, Paolo Abeni <pabeni@redhat.com>,
        Yisen Zhuang <yisen.zhuang@huawei.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        Ariel Elior <aelior@marvell.com>,
        Ido Schimmel <idosch@nvidia.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Arnaud Ebalard <arno@natisbad.org>,
        Jiri Pirko <jiri@mellanox.com>,
        Michael Chan <michael.chan@broadcom.com>,
        Petr Machata <petrm@nvidia.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        "Dimitris Michailidis" <dmichail@fungible.com>,
        Manish Chopra <manishc@marvell.com>,
        Boris Brezillon <bbrezillon@kernel.org>,
        "oss-drivers@corigine.com" <oss-drivers@corigine.com>,
        Vadim Pasternak <vadimp@mellanox.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Taras Chornyi <tchornyi@marvell.com>,
        hariprasad <hkelam@marvell.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Geetha sowjanya <gakula@marvell.com>
Subject: RE: [Intel-wired-lan] [PATCH net-next v5 3/4] net: devlink: make the
 devlink_ops::info_get() callback optional
Thread-Topic: [Intel-wired-lan] [PATCH net-next v5 3/4] net: devlink: make the
 devlink_ops::info_get() callback optional
Thread-Index: AQHZA4aMUpovNpkURUqKWHrpaJfbO65VCqvQ
Date:   Tue, 29 Nov 2022 00:24:18 +0000
Message-ID: <CO1PR11MB5089701265DA7B1FF7CAB26BD6129@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <20221129000550.3833570-1-mailhol.vincent@wanadoo.fr>
 <20221129000550.3833570-4-mailhol.vincent@wanadoo.fr>
In-Reply-To: <20221129000550.3833570-4-mailhol.vincent@wanadoo.fr>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CXUYvMH7NUfgk7r8usRIhViUM/m+BfjC2aGbFBHh3T9xST23h/yrOocU2ZV6?=
 =?us-ascii?Q?+mPcCslKX9D0848nX/5OFmpsMwLAzqpow6Jda3JF06pnUhDM8S7+wTrstvNi?=
 =?us-ascii?Q?qwPe7RhnncjoEVUuYTR5Fb7IlvVvCprvXNfwLN5qs8lcgsxb/AZp9asjXbZX?=
 =?us-ascii?Q?3yxFnJB02iB6koWwNkx/qW/47YGwPdWEIFbFUtQB8RbcjHanRaN3T4T6JLF8?=
 =?us-ascii?Q?+WdEMhnUPsHXGj5s2S+yc53U90MuYq3swqo8UwnFMWp+loMLLoM1sFb//QED?=
 =?us-ascii?Q?pY58/qkcNsKPsEIXtguqWSseAkD47Vb1hyqbePH+dNdqIn3Fnwxvjc/Fs0Yh?=
 =?us-ascii?Q?jLt2jC57OqazcP+bxNVqRzrpEabouxCSoF2RhMni3DC+qFstUZytBnJO0Gnj?=
 =?us-ascii?Q?HFH9idVoTtCwHtYvGTGsncNXJd1crE7yzLFE3O/pAYDhidAhFHusCLvUW/Ct?=
 =?us-ascii?Q?rcxNPVz6SgNMRzLfu80/1zpIDnZxZjuMkOLOaijoNDWlVjwrpfBCnOTdBwfP?=
 =?us-ascii?Q?oy/hf1HJrw3cJ+bdjMF6q+WcX4ZJo3MDwonr5eTpgi5vudoAVsBtZpn5H5rI?=
 =?us-ascii?Q?q3qXevdkWAc5R2ahwFiIf0WZhrv4Pj/nfI50gHUObr77FQXsLmTl9xeOGr4c?=
 =?us-ascii?Q?iAZ68xOg3ddJxfDaXoK1Srm13Net0/tL6czachNydh7oRX/vibImfJn40ZC6?=
 =?us-ascii?Q?LC4ocOizsA/4PAGG8XWs6fZF9Ta14SVdc67qUtjXbP1ws77au6U/gLKZB+f2?=
 =?us-ascii?Q?kbVrC9+TicmIqlWL1erS8hek1b1wRpw1LeT5n7Le6eBt6TAcjyJv1oGEkdjm?=
 =?us-ascii?Q?nCy8Is/jqIHLut7yTAibjp6J6ekFyJdexRJIMZnVdIMssQBg579mo5KRwpps?=
 =?us-ascii?Q?g2vuuGKrJI5UeziLaJ2vrsKt/4jEv5IBDUt4p2aCfDRg80UvKGWUfPCfgQrJ?=
 =?us-ascii?Q?pgg96AeZlWA2X3TyFD5b8vUF+xu+EjUiysT9X/JMqBjXR85noNKMl95UNIxQ?=
 =?us-ascii?Q?kQgMTF1tLtB/5ebvYyy3SUf5Ez7l6AXV/1h19GEDi+HLdiQ7V48eNrZpK9wl?=
 =?us-ascii?Q?iea+qrD9x+IKpdG9IIRj5nssQh+XcUQbwFftec5xr8P/8tz+r/gelWBNlzGl?=
 =?us-ascii?Q?5W9yAjCkDJ9uP917rSC8tF13gSOnr3Bc+7c+GAsgPoFg6sBkqUyW3LkuLB1t?=
 =?us-ascii?Q?qwJqKwq2VFoQjmDTO3wi/V/Z2EPKTorGzva9WsXwd1ryGKbj6o+Vl8mt0ZzF?=
 =?us-ascii?Q?K8ygJRYYpO/nCGzzoYhz9aa/eJLwM7hS0qAaQ4vEnVVKBgWXbeXFJzPSTzYu?=
 =?us-ascii?Q?QdXxM8aW6edIcUST7Sv3rvTa7WQFVVzXhVkPxktQq66N57Vq/htAUT+uIoJz?=
 =?us-ascii?Q?kSydXSYJMpQxc5+7aKgJS4MdPbFwz1c2ZTHS6qKPnkiO7WM7kUYZNDGaOjhw?=
 =?us-ascii?Q?3pxrsAEVvGkLedlljrpMDpqDlVDzJ25q4MPVkOIwYqdunuMci/5QPJgq6vmN?=
 =?us-ascii?Q?MWVIMrMoTy3ZBg6A8d4Cag0/EfI+WgMvN+JfC93TJZ4fldXjNXDT0kKTh4eL?=
 =?us-ascii?Q?HSoXKcuwsbjRVNXb0MqBJs8O8aFU87FnHjX1wGRc?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1eef9d81-c4af-423b-9db5-08dad1a00dc9
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 00:24:18.2323
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9F/Xp2PLU1/BstF4x9p+T9yOusydmJwWWr2TNe4KQ+bXWPoXreCiUUOZOyfktxTsmzh9vte8H01enCG4J3P7BfmU2WHycN0FpqHHquyO/xU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4610
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Vincent Mailhol
> Sent: Monday, November 28, 2022 4:06 PM
> To: Jiri Pirko <jiri@nvidia.com>; netdev@vger.kernel.org; Jakub Kicinski
> <kuba@kernel.org>
> Cc: Andrew Lunn <andrew@lunn.ch>; Shijith Thotton <sthotton@marvell.com>;
> Simon Horman <simon.horman@corigine.com>; Kurt Kanzenbach
> <kurt@linutronix.de>; Eric Dumazet <edumazet@google.com>; Jerin Jacob
> <jerinj@marvell.com>; Subbaraya Sundeep <sbhatta@marvell.com>; Ioana
> Ciornei <ioana.ciornei@nxp.com>; drivers@pensando.io; Linu Cherian
> <lcherian@marvell.com>; Florian Fainelli <f.fainelli@gmail.com>; Herbert =
Xu
> <herbert@gondor.apana.org.au>; Leon Romanovsky <leon@kernel.org>; linux-
> rdma@vger.kernel.org; Shalom Toledo <shalomt@mellanox.com>; Srujana
> Challa <schalla@marvell.com>; Minghao Chi <chi.minghao@zte.com.cn>; Hao
> Chen <chenhao288@hisilicon.com>; Guangbin Huang
> <huangguangbin2@huawei.com>; Shannon Nelson <snelson@pensando.io>;
> intel-wired-lan@lists.osuosl.org; Vadim Fedorenko <vadfed@fb.com>; Paolo
> Abeni <pabeni@redhat.com>; Yisen Zhuang <yisen.zhuang@huawei.com>; Sunil
> Goutham <sgoutham@marvell.com>; Ariel Elior <aelior@marvell.com>; Ido
> Schimmel <idosch@nvidia.com>; Richard Cochran <richardcochran@gmail.com>;
> Arnaud Ebalard <arno@natisbad.org>; Jiri Pirko <jiri@mellanox.com>; Micha=
el
> Chan <michael.chan@broadcom.com>; Vincent Mailhol
> <mailhol.vincent@wanadoo.fr>; Petr Machata <petrm@nvidia.com>; Salil Meht=
a
> <salil.mehta@huawei.com>; Dimitris Michailidis <dmichail@fungible.com>;
> Manish Chopra <manishc@marvell.com>; Boris Brezillon
> <bbrezillon@kernel.org>; oss-drivers@corigine.com; Vadim Pasternak
> <vadimp@mellanox.com>; linux-kernel@vger.kernel.org; David S . Miller
> <davem@davemloft.net>; Taras Chornyi <tchornyi@marvell.com>; hariprasad
> <hkelam@marvell.com>; linux-crypto@vger.kernel.org; Jonathan Lemon
> <jonathan.lemon@gmail.com>; Vladimir Oltean <olteanv@gmail.com>; Saeed
> Mahameed <saeedm@nvidia.com>; Geetha sowjanya <gakula@marvell.com>
> Subject: [Intel-wired-lan] [PATCH net-next v5 3/4] net: devlink: make the
> devlink_ops::info_get() callback optional
>=20
> Some drivers only reported the driver name in their
> devlink_ops::info_get() callback. Now that the core provides this
> information, the callback became empty. For such drivers, just
> removing the callback would prevent the core from executing
> devlink_nl_info_fill() meaning that "devlink dev info" would not
> return anything.
>=20
> Make the callback function optional by executing
> devlink_nl_info_fill() even if devlink_ops::info_get() is NULL.
>=20
> N.B.: the drivers with devlink support which previously did not
> implement devlink_ops::info_get() will now also be able to report
> the driver name.
>=20

Makes sense to me.

Thanks,
Jake