Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp244576rwb; Thu, 1 Dec 2022 01:30:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf4dYkXiFSCfh/2eZJeOwohZvS2Nshy5sNmTTeq3vAWN2tF5y3ayW4f9CSrjFHuA9BXFIDBq X-Received: by 2002:a17:906:2b8f:b0:7a0:3125:f1e5 with SMTP id m15-20020a1709062b8f00b007a03125f1e5mr53810064ejg.314.1669887023091; Thu, 01 Dec 2022 01:30:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669887023; cv=none; d=google.com; s=arc-20160816; b=LZnzO1nyHc9H4iz9jxQh+I/kcnA2np7PGbgl+t6Kuza5mPRYxWZWmGnSLVElFwK7r1 xX18RcX/6VdwfCrsjMj+jw7K/LLD1bHCWsR3t7Qh9GWjsXnjk02exn2I6l2RwDxqQWX7 1Ftutvzmm3lOLpiHPqtl9yamOMrdxjczodua/w2QZekPaCSClbJae++mqEgCZ2wCza9r BRoGJNOT9IhmedEiJH3GlubQx0kS0sw3NNTLZq2n92BP150N+0lqVWEgtrLXVmGePeuZ 4uMi0BmrqrAfBF0ONzZV/SNSOJBHm63jBV+I3FxGw6nflOcUoYCaY8vNoyamHhikE8YZ 14Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=MkZOQIDhzz/ZdyYHDjJhV18ycZ3HPCl9kL7HnUmPXkQ=; b=A40Fz5UJmQ5LhNo/afHOIjHLGD/TdaoDRKvnzwIBzXSIaml+OILhgA0jf9Gx4flPYa oGJjMjjexuzUaZiy0Tg0zJ/mjM+p32gmEWjzJTWiu5QeAWbIZkJiT08gPUxDfujRis0d CiVlObhxdhg9lp7RlLi9Y6asYJz2xrqTAkMfTDKe6F8VxK+sIsZDelFePda1tyE07Bb2 Jd6mjFBi0q40yyQn5720DYRejfnazToDpTgsxHCXxkQTeEB2esFk5Ff9awRVgCk2x4Ac pegK8xttuoxbMqUUIfwO29Rq09M//1hPxy7/s+qZ0/TIUhn/yuUTyAXozdYXIEDQoquS KPfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Le4uia54; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 17-20020a170906059100b0073beb58e98dsi2651746ejn.276.2022.12.01.01.29.54; Thu, 01 Dec 2022 01:30:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Le4uia54; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229744AbiLAJ1k (ORCPT + 99 others); Thu, 1 Dec 2022 04:27:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229723AbiLAJ1j (ORCPT ); Thu, 1 Dec 2022 04:27:39 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D183C48 for ; Thu, 1 Dec 2022 01:27:31 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id b3so1590672lfv.2 for ; Thu, 01 Dec 2022 01:27:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MkZOQIDhzz/ZdyYHDjJhV18ycZ3HPCl9kL7HnUmPXkQ=; b=Le4uia54Oxpjs04IgYxInqhcUM1oreQs7cvQXaRwmX077/HQJuZEu3jMGfVNQpJgNE Onb/6iYKVkPVgX1O9QlqLwMSALb6UP2BLG4RJ0MpzoFBbTaXp16BFyI/xAzzTDJCO54u p8wG0PhdHHVsNDZsKJMP4JghIrx4VBq30/bfQvOELY2/Uqy1uNBJlLasLcC5vADjF3LK 0WjBC9tgxvhMIvOB3h4wirI458DoFsPvk3YSTsjlWHYIAZgUUg+/yCyAFAwNNpQY5GNA YA8K9uUiyI0uNihy8NPgPKdrB5jYqZuOmIM24eZXwb1ZZW38aODbHowKkt+w2wFAzz6B BHZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MkZOQIDhzz/ZdyYHDjJhV18ycZ3HPCl9kL7HnUmPXkQ=; b=OsSd9TWWq0Q6y/8kEsZKstWZnZqhME3Ds++wDyip2HarNBQpoNKD0bUE29s/XAXZ1o nZR0TQHAIzogn71mL69lFlykvPxCIMdw+IbVn6JQOhCx+Fx1szPU0D0y4/ePgrNZ3eG1 Vd8jPFKp31HeeeBe2YlEtgMsNqkUnNW5LpKKSC+G/lM2FGt0nH4tph16vWSOZqPTyj7F FGwkT9TKgErWlDqx38k0HIOqx2JY5CIfer+gHGMAV9rHgBdUCSxVqYnZhsQKA95jD/mY OC4H1tvOzFIzs8KjZXz0aYMyH+3iwSeBQXMqS5uW7fJbXWnTqgvkyM5YiJasdQOOj0Ud 0rQQ== X-Gm-Message-State: ANoB5pmUMrXq3zeCI++oc236ZDjdzRLv8rFdPllgLknYVVbq7SZpf390 uzA8aGdHGvkf9+afs87lRVpfDA== X-Received: by 2002:a19:6b1a:0:b0:4b4:3313:feaf with SMTP id d26-20020a196b1a000000b004b43313feafmr21542327lfa.365.1669886849819; Thu, 01 Dec 2022 01:27:29 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id a25-20020a056512201900b004b4e9580b1asm589093lfb.66.2022.12.01.01.27.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Dec 2022 01:27:28 -0800 (PST) Message-ID: <2886dd64-435d-1cdb-168d-5851c37dc538@linaro.org> Date: Thu, 1 Dec 2022 10:27:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto driver Content-Language: en-US To: JiaJie Ho , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski Cc: "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" References: <20221130055214.2416888-1-jiajie.ho@starfivetech.com> <20221130055214.2416888-6-jiajie.ho@starfivetech.com> <8a8f502e-e0ed-d638-0b56-74edcbca2134@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 01/12/2022 10:01, JiaJie Ho wrote: >>> + >>> + enable-side-channel-mitigation: >>> + description: Enable side-channel-mitigation feature for AES module. >>> + Enabling this feature will affect the speed performance of >>> + crypto engine. >>> + type: boolean >> >> Why exactly this is a hardware (DT) property, not runtime? >> > > This is a hardware setting provided in StarFive crypto engine only. > The crypto API doesn't control this setting during runtime and leaving this always on will impact speed performance. > So, I added this property to allow user to control this in dtb. Devicetree should not describe policies, so without justification it does not look like hardware property. Drop. Best regards, Krzysztof