Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp439883rwb; Thu, 1 Dec 2022 04:17:38 -0800 (PST) X-Google-Smtp-Source: AA0mqf5Vl9nJ1w1nwcO9L600PT7+kKq+1GB6Y7v7ozWwz+eWYMqNndxxl2Cqtj8tNW7xt15oWO+n X-Received: by 2002:a63:1d62:0:b0:477:d018:ef31 with SMTP id d34-20020a631d62000000b00477d018ef31mr31050942pgm.287.1669897058672; Thu, 01 Dec 2022 04:17:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669897058; cv=none; d=google.com; s=arc-20160816; b=iQjVIIZFDG8FNBgfMzuqjEsNwWUOBeNd1rN7YxxmPUE0cox2XahJH/xzC6IfxJlKW9 qyr9TEsiOlbydNHYjB49EWphn9wu0NZqza6VKEZNRQpYIVM2uo0Nrtm1P4Aiyc9lvuxh iJnhP44NyOcFvrIVu1MSON6ing83X9dV0Or7QKnq96Qq4tmMBxHCAU873SQm7wDK9bqP fcE6gbVnJAuDT8kI/0fLyYvcOyJA5nvkoBwkrPlOi4EvEGRdoCSRZPVhdCuPrp68Ol6N ry39xiXvRZqhCFd2/3ir4ghIGUsIYeEj9NozxwAnIZUYFKM222mq7Tz4rZLS6/cgzG7F fMNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Ho7uNSO98R/9+m0NjB+Wi/jGaB9RN8mWUe4DXfMSdCs=; b=n5gbDlnoujBQYKCDPZu7/RUkH8es4POobhevMqzu98IEmg06YvNkvTBXMJD0Q2aYQk Ooj+xDGIRpIcTz5PzzUoHz/OK+tr/krK8SXxzvpqH384ymHn3WoRf+xZExa4u7lnV1hE 3Aacr7HPn/ej5Dcwk/46kscfOzPZzufs2qpGDvgw03qq/83Vr5Y0OhYqgpsBSOfI+TGg QgBoT61uMrCaCDkYrfhrJq7ZHTrOgcUmFHwPf/G3a3afp/EajlqFwhstzmQbO8npgy/t 6+rQmef0SDTq32cCsVqfPz9Wzb27K6995776Rx79KyewZRGtE+iFzeKPoQCcjnAGsIwq xeWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q7-20020a056a00084700b005739d652a89si5035752pfk.223.2022.12.01.04.17.13; Thu, 01 Dec 2022 04:17:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231272AbiLAMKY (ORCPT + 99 others); Thu, 1 Dec 2022 07:10:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbiLAMKX (ORCPT ); Thu, 1 Dec 2022 07:10:23 -0500 Received: from formenos.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C78B294568; Thu, 1 Dec 2022 04:10:20 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1p0iOF-002pZT-AB; Thu, 01 Dec 2022 20:10:08 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Thu, 01 Dec 2022 20:10:07 +0800 Date: Thu, 1 Dec 2022 20:10:07 +0800 From: Herbert Xu To: Anders Roxell Cc: Kees Cook , Horia =?utf-8?Q?Geant=C4=83?= , Pankaj Gupta , Gaurav Jain , "David S. Miller" , linux-crypto@vger.kernel.org, kernel test robot , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] crypto/caam: Avoid GCC constprop bug warning Message-ID: References: <20221028210527.never.934-kees@kernel.org> <20221201115244.GC69385@mutt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221201115244.GC69385@mutt> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Dec 01, 2022 at 12:52:44PM +0100, Anders Roxell wrote: . > I think that was fixed in sparse release v0.5.1 [1]. The workaround 'if > (len)' was introduced back in 2011, and the sparse release v0.5.1 was > done in 2017. So it should probably be safe to remove the 'if (len)' or > what do you think? Could you please send a patch? :) Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt