Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Dec 2022 17:43:45 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Xiongfeng Wang <wangxiongfeng2@huawei.com>
Cc:     olivia@selenic.com, mpm@selenic.com, mb@bu3sch.de,
        linux-crypto@vger.kernel.org, yangyingliang@huawei.com
Subject: Re: [PATCH] hwrng: amd - Fix PCI device refcount leak
Message-ID: <Y4nI0X0u01uiTCV0@gondor.apana.org.au>
References: <20221123093949.115579-1-wangxiongfeng2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221123093949.115579-1-wangxiongfeng2@huawei.com>
Precedence: bulk

On Wed, Nov 23, 2022 at 05:39:49PM +0800, Xiongfeng Wang wrote:
>
> @@ -201,6 +207,8 @@ static void __exit amd_rng_mod_exit(void)
>  	release_region(priv->pmbase + PMBASE_OFFSET, PMBASE_SIZE);
>  
>  	kfree(priv);
> +
> +	pci_dev_put(priv->pcidev);

Oops, this doesn't look right.  Please fix and resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt