Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Dec 2022 18:11:56 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Taehee Yoo <ap420073@gmail.com>
Cc:     linux-crypto@vger.kernel.org, davem@davemloft.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        kirill.shutemov@linux.intel.com, richard@nod.at,
        viro@zeniv.linux.org.uk,
        sathyanarayanan.kuppuswamy@linux.intel.com, jpoimboe@kernel.org,
        elliott@hpe.com, x86@kernel.org, jussi.kivilinna@iki.fi,
        ebiggers@kernel.org
Subject: Re: [PATCH v6 2/4] crypto: aria: do not use magic number offsets of
 aria_ctx
Message-ID: <Y4nPbMHNQl++bItU@gondor.apana.org.au>
References: <20221121003955.2214462-1-ap420073@gmail.com>
 <20221121003955.2214462-3-ap420073@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221121003955.2214462-3-ap420073@gmail.com>
Precedence: bulk

On Mon, Nov 21, 2022 at 12:39:53AM +0000, Taehee Yoo wrote:
>
> +#if defined(CONFIG_CRYPTO_ARIA_AESNI_AVX_X86_64) ||  \
> +	defined(CONFIG_CRYPTO_ARIA_AESNI_AVX_X86_64_MODULE)

Why isn't this IS_ENABLED like the hunk below?

> +
> +	/* Offset for fields in aria_ctx */
> +	BLANK();
> +	OFFSET(ARIA_CTX_enc_key, aria_ctx, enc_key);
> +	OFFSET(ARIA_CTX_dec_key, aria_ctx, dec_key);
> +	OFFSET(ARIA_CTX_rounds, aria_ctx, rounds);
> +#endif
> +
>  	if (IS_ENABLED(CONFIG_KVM_INTEL)) {
>  		BLANK();
>  		OFFSET(VMX_spec_ctrl, vcpu_vmx, spec_ctrl);

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt