Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Dec 2022 18:20:44 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Shang XiaoJing <shangxiaojing@huawei.com>
Cc:     davem@davemloft.net, mgreer@animalcreek.com,
        linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: omap-sham - Use pm_runtime_resume_and_get() in
 omap_sham_probe()
Message-ID: <Y4nRfKFjZT5JS6eU@gondor.apana.org.au>
References: <20221124064940.19845-1-shangxiaojing@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221124064940.19845-1-shangxiaojing@huawei.com>
Precedence: bulk

On Thu, Nov 24, 2022 at 02:49:40PM +0800, Shang XiaoJing wrote:
> omap_sham_probe() calls pm_runtime_get_sync() and calls
> pm_runtime_put_sync() latter to put usage_counter. However,
> pm_runtime_get_sync() will increment usage_counter even it failed. Fix
> it by replacing it with pm_runtime_resume_and_get() to keep usage
> counter balanced.
> 
> Fixes: b359f034c8bf ("crypto: omap-sham - Convert to use pm_runtime API")
> Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
> ---
>  drivers/crypto/omap-sham.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt