Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] hwrng: amd - Fix PCI device refcount leak
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     <olivia@selenic.com>, <mpm@selenic.com>, <mb@bu3sch.de>,
        <linux-crypto@vger.kernel.org>, <yangyingliang@huawei.com>
References: <20221123093949.115579-1-wangxiongfeng2@huawei.com>
 <Y4nI0X0u01uiTCV0@gondor.apana.org.au>
From:   Xiongfeng Wang <wangxiongfeng2@huawei.com>
Message-ID: <4f27474d-7fe5-d1cb-0be8-387b0562e629@huawei.com>
Date:   Fri, 2 Dec 2022 18:59:13 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <Y4nI0X0u01uiTCV0@gondor.apana.org.au>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022/12/2 17:43, Herbert Xu wrote:
> On Wed, Nov 23, 2022 at 05:39:49PM +0800, Xiongfeng Wang wrote:
>>
>> @@ -201,6 +207,8 @@ static void __exit amd_rng_mod_exit(void)
>>  	release_region(priv->pmbase + PMBASE_OFFSET, PMBASE_SIZE);
>>  
>>  	kfree(priv);
>> +
>> +	pci_dev_put(priv->pcidev);
> 
> Oops, this doesn't look right.  Please fix and resubmit.

Ah, Sorry, my mistake! I will send another version with the fix of geode-rng.

Thanks,
Xiongfeng

> 
> Thanks,
>