Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     "Jason A. Donenfeld" <Jason@zx2c4.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "tim.c.chen@linux.intel.com" <tim.c.chen@linux.intel.com>,
        "ap420073@gmail.com" <ap420073@gmail.com>,
        "ardb@kernel.org" <ardb@kernel.org>,
        "David.Laight@aculab.com" <David.Laight@aculab.com>,
        "ebiggers@kernel.org" <ebiggers@kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 10/24] crypto: x86/poly - limit FPU preemption
Thread-Topic: [PATCH v4 10/24] crypto: x86/poly - limit FPU preemption
Thread-Index: AQHY+XHqfLLvXNGxcESumjNg7U4Mn65BZh+AgA36OwCACrj5IIAAU7WAgABtSRA=
Date:   Fri, 2 Dec 2022 16:15:23 +0000
Message-ID: <MW5PR84MB184215302DC8E824812D6B13AB179@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <20221103042740.6556-1-elliott@hpe.com>
 <20221116041342.3841-1-elliott@hpe.com>
 <20221116041342.3841-11-elliott@hpe.com> <Y3TF7/+DejcnN0eV@zx2c4.com>
 <Y4B/kjS0lgzdUJHG@gondor.apana.org.au>
 <MW5PR84MB1842C2D1EA00D5EF65784E25AB179@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
 <Y4nEcV4w3eOEFYze@gondor.apana.org.au>
In-Reply-To: <Y4nEcV4w3eOEFYze@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sH6aJeP/0dUD1QRls0gIGXp1qKEN+PX11ARbzeBW5zolRDHF3cmbq8/Qihrc?=
 =?us-ascii?Q?8Y8db8QU186J8jIOrOIpmVYx9d2s18K0Rg0oKQPb/GjJh7MhCsvvuLC8FBlb?=
 =?us-ascii?Q?vaHmONiRxTN4I5GFxIPP/GzQ7Xz3xDEFktAiLi6n7VJX0EwWX6mE/urai/dQ?=
 =?us-ascii?Q?xo/653sKC8AvShMS/aTFyHbOBBmx7lG3fAJQnY4EPijrxnzn9Y+5+pzUXS1I?=
 =?us-ascii?Q?hhltuib6NXxfgs85XYZIiF4xq1iiOHPxlnAUNlvK4TkpSqSKmCEJepEHPhEQ?=
 =?us-ascii?Q?ESEDweXGneyy86Ffh1hZbzDdRiWWoJuxJxaPEX9yvp3752BseAQIF2lTyqZo?=
 =?us-ascii?Q?y7c0/Hp/RJ6OzlNtegaMnhy/Rk7YwCAPqOUbDAK0lrSCm/W13K8720vLFb6N?=
 =?us-ascii?Q?/hrWQ3MZ0JU44OXtfFqWOUAlT77khpvbXNWpCbRK1nyQ+vlQq2T5WJAW2VBk?=
 =?us-ascii?Q?VDtUoWs7ZDQtXnATLbSnKvnNNy9Q15+tFUx42CzTrwMcuYHrtCtxY1mF63ow?=
 =?us-ascii?Q?oM8lM1YPZwCmquKNALC1oTTnh3rqcc6GD81oOycBa4STNYcCnXzc3PrzQtun?=
 =?us-ascii?Q?MPUYIn7qXrOnC9n0jlT1c58wbX9Fj/cPwb04/DBLIrw+NrNpDLOWGlUKUpnu?=
 =?us-ascii?Q?sdL6KfTlH4YxcUDza/LwR7VcFAdhK6ufQdGrCcbIEpjb7tBpY7klSEq7hEeK?=
 =?us-ascii?Q?ji/rEiXo1w78rDhICsJeRboXXd8JF4FSAFyEmR5dwIor5h4wXZCHEDoW7eXQ?=
 =?us-ascii?Q?G9HOGAWV9o8sEYzw2hCkhMjOAnPY1EUKLywQp/9Dh95hA14OG8t2J7+rH0yd?=
 =?us-ascii?Q?TfZ++2th/oSDhttrmBq2vU1MTirOshTA8GFxCpZs2QkmQNg7nqrIrIWM8SOT?=
 =?us-ascii?Q?dvReJw3D3rG0YxwA4FJeeErQJDzb/nwXfFZDKEpbD8gfL/66/IUx9ukQCIGl?=
 =?us-ascii?Q?11HVc0ZjXexqXJmrT2hX+3kgo9hLJ7MMMnj1WUv2Ne6ZOmhtq+vvEPwiTJVX?=
 =?us-ascii?Q?gD+9OKHr/DCOnaot5ab99plzF0OcPxbj6UWqYTXzC2+3oiO5/JRBhVem9WjO?=
 =?us-ascii?Q?ljd36D18KYIxT8nJLGUqL23X/AHV/TsV0D5caaKZpsleczz/W/pb+ntTRBhu?=
 =?us-ascii?Q?Kykxomv/241LIj5kfrZ5dXwhNGuKL3qoPGiYSJo8FXgUzdlrNZygUS5QZV1l?=
 =?us-ascii?Q?B1UPGgR8N8u/5CJe+zjNHfeo2FUtU8vDIAD0bOKvqKIbBLYHsAwgavRwwbEp?=
 =?us-ascii?Q?XWCqWBlIuIb2HsqA9r6V7eU974WvBnaJDeGB3BS9UgJ3NvN3Fv8raclsKPrG?=
 =?us-ascii?Q?H2gYoTzuo/XUUYiuWWzhyGEiqBJslNtWmou6WnNMUmfgsu+xNy+fkkPeOn1O?=
 =?us-ascii?Q?1m+kxcXlPg2k3w1BLNa/haqiEFsDKyq3TjIs2i69URepRYfNofHps/q5X0iF?=
 =?us-ascii?Q?wZu1mo+ogD7nolyV0PhDZJwUQnkb8yHp+kSTDrtSTIXCa0pGylOtOt/fs1Ql?=
 =?us-ascii?Q?zFwCXwpzTZYYbvR9MNyELNBXa7aDv0Nuh65T9cN4tfqpz82IIRxSNYjclbRo?=
 =?us-ascii?Q?zuUoqmNjsOTW5KbPuQA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 737d1436-cbe2-4a3e-d004-08dad4806a4b
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2022 16:15:23.0446
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YYhJLVg2h0TbmPwqZytKoxfzNjI80SdY/QBBQvFS/oy+OPVBCX6r0p2fYY4cuqNZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR84MB1656
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: I3fXUD89744EKoZKh0WCzS5zno4i3HvL
X-Proofpoint-GUID: I3fXUD89744EKoZKh0WCzS5zno4i3HvL
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-02_08,2022-12-01_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 phishscore=0 spamscore=0 priorityscore=1501 impostorscore=0 mlxscore=0
 malwarescore=0 mlxlogscore=919 suspectscore=0 adultscore=0 clxscore=1015
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2212020127
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Friday, December 2, 2022 3:25 AM
> To: Elliott, Robert (Servers) <elliott@hpe.com>
> Subject: Re: [PATCH v4 10/24] crypto: x86/poly - limit FPU preemption
>=20
> On Fri, Dec 02, 2022 at 06:21:02AM +0000, Elliott, Robert (Servers) wrote=
:
...
> BTW, just a minor nit but you can delete the cond_resched() call
> because kernel_fpu_end()/preempt_enable() will do it anyway.

That happens under
	CONFIG_PREEMPTION=3Dy
(from include/Linux/preempt.h and arch/x86/include/asm/preempt.h)

Is calling cond_resched() still helpful if that is not the configuration?