Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e0c38961-44cc-943b-8739-420867fdc5ce@gmail.com>
Date:   Sat, 3 Dec 2022 14:01:54 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v6 2/4] crypto: aria: do not use magic number offsets of
 aria_ctx
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     linux-crypto@vger.kernel.org, davem@davemloft.net,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        kirill.shutemov@linux.intel.com, richard@nod.at,
        viro@zeniv.linux.org.uk,
        sathyanarayanan.kuppuswamy@linux.intel.com, jpoimboe@kernel.org,
        elliott@hpe.com, x86@kernel.org, jussi.kivilinna@iki.fi,
        ebiggers@kernel.org
References: <20221121003955.2214462-1-ap420073@gmail.com>
 <20221121003955.2214462-3-ap420073@gmail.com>
 <Y4nPbMHNQl++bItU@gondor.apana.org.au>
Content-Language: en-US
From:   Taehee Yoo <ap420073@gmail.com>
In-Reply-To: <Y4nPbMHNQl++bItU@gondor.apana.org.au>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Herbert,
Thank you so much for your review!

On 12/2/22 19:11, Herbert Xu wrote:
 > On Mon, Nov 21, 2022 at 12:39:53AM +0000, Taehee Yoo wrote:
 >>
 >> +#if defined(CONFIG_CRYPTO_ARIA_AESNI_AVX_X86_64) ||  \
 >> +	defined(CONFIG_CRYPTO_ARIA_AESNI_AVX_X86_64_MODULE)
 >
 > Why isn't this IS_ENABLED like the hunk below?
 >
 >> +
 >> +	/* Offset for fields in aria_ctx */
 >> +	BLANK();
 >> +	OFFSET(ARIA_CTX_enc_key, aria_ctx, enc_key);
 >> +	OFFSET(ARIA_CTX_dec_key, aria_ctx, dec_key);
 >> +	OFFSET(ARIA_CTX_rounds, aria_ctx, rounds);
 >> +#endif
 >> +
 >>   	if (IS_ENABLED(CONFIG_KVM_INTEL)) {
 >>   		BLANK();
 >>   		OFFSET(VMX_spec_ctrl, vcpu_vmx, spec_ctrl);
 >
 > Thanks,

I missed cleaning it up.
I will use IS_ENABLED() instead of defined() in the v7.

Thanks a lot!
Taehee Yoo