Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6343631rwb; Mon, 5 Dec 2022 10:57:06 -0800 (PST) X-Google-Smtp-Source: AA0mqf55+NugUjPPSiqVoylOgKks0au/bjrjsDgW8sxVxJXJXgEFS/H7imJ0WOuyREE9BAEoa3Al X-Received: by 2002:a17:906:a983:b0:7b8:31b1:b23f with SMTP id jr3-20020a170906a98300b007b831b1b23fmr53954789ejb.591.1670266626283; Mon, 05 Dec 2022 10:57:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670266626; cv=none; d=google.com; s=arc-20160816; b=Jw3fiPqDGYCLJV+/3O+1i1agl9g6oo/GNzb09IOgrnoMQNUH88zdhJjIwz8zhrnpUQ hr8YIJ35MCeJQgSVgx09F8kwHjAf/RPD+tHO7kqDiXXqsP9+Sf9Mv6o7P/TmNENk9EfQ 8fRP2SY0TyXa7+g01MnyFdtMr8qA6AE9aUe3FNUTx4IQt9FyIQEydmSHjrq6GartnbZz bIFIIt4lKeooQXc9dZnXISHDZ5+vC05JAKTw2JnBtWJlYtX3F6ghdnVeMjaE+h6frW3+ gHyFZL3zscpjj/IqoRbc5lE4hBg1CKRoiOTUaCdSYVkeOd0QpEeIMBd6iqj9FkGzP6gV WS9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+uBKJVNJYw3pTg89I4Wru5rBtHkt0SHV5a0kfWhJUMs=; b=BE77tjTtPRkVmtzWr0AntGCvacSchNrH3wlYAcVlmfF4dkpZviJNVThZbuNaO0JU8c TFHDWPIuHOdRDDyj94++WwlRdy9GlvONVMOtqbVU/IG2w//tjYfRkGDUyaHojPMi7W5r 2BKvzrSVHJxS19fnWkVA+MFKOvuxD0Ufe6iyS6HgJ9ksXVYbwmzQN04/1qljiK+zFzHs MxRrKFk01Wyeu0fctz7tfujLaWuSF8DSro8gQbQSNN0RbXy0QTQRnAk7Bbudp//6VksA sJpHqHO10q4/xdtdfeJg18yE0SEONydcNXVFiVMjsO0g2I/UXYll7glHXMJ2ibgHDDJh RBlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b="i/q4yG4T"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g9-20020a1709065d0900b007811e006b46si11578469ejt.470.2022.12.05.10.56.36; Mon, 05 Dec 2022 10:57:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b="i/q4yG4T"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231965AbiLESlH (ORCPT + 99 others); Mon, 5 Dec 2022 13:41:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231994AbiLESkf (ORCPT ); Mon, 5 Dec 2022 13:40:35 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA2FC209B0; Mon, 5 Dec 2022 10:38:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4E9EE60025; Mon, 5 Dec 2022 18:38:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50F52C433C1; Mon, 5 Dec 2022 18:38:21 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="i/q4yG4T" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1670265498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+uBKJVNJYw3pTg89I4Wru5rBtHkt0SHV5a0kfWhJUMs=; b=i/q4yG4TRgcAfsp7bhNnqZhFDbgcrF2khLVdsny531uYWtiAIhVlrF0tPkXFrjyvCvWcFp RHvI2Qg7ASdNESHkEkaGsMx8gD9/hevhpNpAtWT2ChagkR35gDzAMEPdaeGR36DoJLiKeU RVcP4QY26axwZe0XMMLJEUYhhAzf1Ho= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id bb930d2a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 5 Dec 2022 18:38:18 +0000 (UTC) Date: Mon, 5 Dec 2022 19:38:16 +0100 From: "Jason A. Donenfeld" To: Florian Weimer Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, tglx@linutronix.de, linux-crypto@vger.kernel.org, linux-api@vger.kernel.org, x86@kernel.org, Greg Kroah-Hartman , Adhemerval Zanella Netto , Carlos O'Donell , Arnd Bergmann , Christian Brauner Subject: Re: [PATCH v11 1/4] random: add vgetrandom_alloc() syscall Message-ID: References: <20221205020046.1876356-1-Jason@zx2c4.com> <20221205020046.1876356-2-Jason@zx2c4.com> <87cz8xr96o.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87cz8xr96o.fsf@oldenburg.str.redhat.com> X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Dec 05, 2022 at 07:34:39PM +0100, Florian Weimer wrote: > > + * - Passing the first state to munmap(2), as described above. > > + * All other uses are undefined behavior, which is subject to change or removal > > Suggest: “Passing the first state *and total length* to munmap(2)” Will do. > Rest of the documentation looks good to me. It addresses my concerns > about future evolution of this interface. Great! So hopefully the api is more or less settled now, and we can turn attention to the glibc part. Jason